Re: [Xen-devel] [libvirt] [PATCH V4 0/3] Parser for xen-xl config format
On 01/13/2015 08:53 AM, Jim Fehlig wrote: > It's been a long, twisting road to V4 of the Xen xl parser. V3 [1] was > based on a flex-based parser that was copied from the Xen project and > proved to be a bit challenging to integrate properly with autotools. > But as it turns out, Xen provides an interface to the parser via libxlutil. > I hadn't realized this interface was available for external consumption > since the corresponding header file was never installed. Patch sent to > xen-devel [2] to install the header, but in the meantime need to declare > gthe imported libxlutil functions as extern (see patch 1). > > V4 uses libxlutil, which has simplified the series quite a bit and > eliminates the potential of the copied flex parser diverging from > the canonical source in xen.git. > > [1] https://www.redhat.com/archives/libvir-list/2014-December/msg00765.html > [2] http://lists.xen.org/archives/html/xen-devel/2015-01/msg00690.html Yay - this series compiled on RHEL 5, with no extra efforts on my part. I'll review the individual patches as well, but we're already looking better. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [libvirt] [PATCH V4 0/3] Parser for xen-xl config format
On 01/13/2015 10:53 AM, Jim Fehlig wrote: > It's been a long, twisting road to V4 of the Xen xl parser. V3 [1] was > based on a flex-based parser that was copied from the Xen project and > proved to be a bit challenging to integrate properly with autotools. > But as it turns out, Xen provides an interface to the parser via libxlutil. > I hadn't realized this interface was available for external consumption > since the corresponding header file was never installed. Patch sent to > xen-devel [2] to install the header, but in the meantime need to declare > gthe imported libxlutil functions as extern (see patch 1). > > V4 uses libxlutil, which has simplified the series quite a bit and > eliminates the potential of the copied flex parser diverging from > the canonical source in xen.git. > > [1] https://www.redhat.com/archives/libvir-list/2014-December/msg00765.html > [2] http://lists.xen.org/archives/html/xen-devel/2015-01/msg00690.html > > Jim Fehlig (1): > Introduce support for parsing/formatting Xen xl config format > > Kiarie Kahurani (2): > tests: Tests for the xen-xl parser > libxl: Add support for parsing/formating Xen XL config > > configure.ac | 3 + > po/POTFILES.in | 1 + > src/Makefile.am | 11 + > src/libvirt_xenxlconfig.syms | 12 + > src/libxl/libxl_driver.c | 32 ++- > src/xenconfig/xen_common.c | 3 +- > src/xenconfig/xen_xl.c | 515 > +++ > src/xenconfig/xen_xl.h | 35 +++ > tests/Makefile.am| 11 + > tests/testutilsxen.c | 50 > tests/testutilsxen.h | 9 +- > tests/xlconfigdata/test-new-disk.cfg | 26 ++ > tests/xlconfigdata/test-new-disk.xml | 51 > tests/xlconfigdata/test-spice.cfg| 32 +++ > tests/xlconfigdata/test-spice.xml| 45 +++ > tests/xlconfigtest.c | 225 +++ > tools/virsh.pod | 8 +- > 17 files changed, 1055 insertions(+), 14 deletions(-) > create mode 100644 src/libvirt_xenxlconfig.syms > create mode 100644 src/xenconfig/xen_xl.c > create mode 100644 src/xenconfig/xen_xl.h > create mode 100644 tests/xlconfigdata/test-new-disk.cfg > create mode 100644 tests/xlconfigdata/test-new-disk.xml > create mode 100644 tests/xlconfigdata/test-spice.cfg > create mode 100644 tests/xlconfigdata/test-spice.xml > create mode 100644 tests/xlconfigtest.c > My Coverity run was happy with the changes. John ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
