Re: [PATCH net] net/xen-netback: prevent UAF in xenvif_flush_hash()
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 23 Aug 2024 03:11:09 +0900 you wrote: > During the list_for_each_entry_rcu iteration call of xenvif_flush_hash, > kfree_rcu does not exist inside the rcu read critical section, so if > kfree_rcu is called when the rcu grace period ends during the iteration, > UAF occurs when accessing head->next after the entry becomes free. > > Therefore, to solve this, you need to change it to list_for_each_entry_safe. > > [...] Here is the summary with links: - [net] net/xen-netback: prevent UAF in xenvif_flush_hash() https://git.kernel.org/netdev/net-next/c/0fa5e94a1811 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 19 Apr 2024 12:08:38 +0100 you wrote: > Please, don't take directly, conflicts with io_uring. > > To have per request buffer notifications each zerocopy io_uring send > request allocates a new ubuf_info. However, as an skb can carry only > one uarg, it may force the stack to create many small skbs hurting > performance in many ways. > > [...] Here is the summary with links: - [io_uring-next/net-next,v2,1/4] net: extend ubuf_info callback to ops structure https://git.kernel.org/netdev/net-next/c/7ab4f16f9e24 - [io_uring-next/net-next,v2,2/4] net: add callback for setting a ubuf_info to skb https://git.kernel.org/netdev/net-next/c/65bada80dec1 - [io_uring-next/net-next,v2,3/4] io_uring/notif: simplify io_notif_flush() (no matching commit) - [io_uring-next/net-next,v2,4/4] io_uring/notif: implement notification stacking (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] xen-netfront: Add missing skb_mark_for_recycle
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski :
On Wed, 27 Mar 2024 13:14:56 +0100 you wrote:
> Notice that skb_mark_for_recycle() is introduced later than fixes tag in
> 6a5bcd84e886 ("page_pool: Allow drivers to hint on SKB recycling").
>
> It is believed that fixes tag were missing a call to page_pool_release_page()
> between v5.9 to v5.14, after which is should have used skb_mark_for_recycle().
> Since v6.6 the call page_pool_release_page() were removed (in 535b9c61bdef
> ("net: page_pool: hide page_pool_release_page()") and remaining callers
> converted (in commit 6bfef2ec0172 ("Merge branch
> 'net-page_pool-remove-page_pool_release_page'")).
>
> [...]
Here is the summary with links:
- [net] xen-netfront: Add missing skb_mark_for_recycle
https://git.kernel.org/netdev/net/c/037965402a01
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v4 bpf-next 0/2] mm: Enforce ioremap address space and introduce sparse vm_area
Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Mon, 4 Mar 2024 19:05:14 -0800 you wrote: > From: Alexei Starovoitov > > v3 -> v4 > - dropped VM_XEN patch for now. It will be in the follow up. > - fixed constant as pointed out by Mike > > v2 -> v3 > - added Christoph's reviewed-by to patch 1 > - cap commit log lines to 75 chars > - factored out common checks in patch 3 into helper > - made vm_area_unmap_pages() return void > > [...] Here is the summary with links: - [v4,bpf-next,1/2] mm: Enforce VM_IOREMAP flag and range in ioremap_page_range. https://git.kernel.org/bpf/bpf-next/c/3e49a866c9dc - [v4,bpf-next,2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages(). https://git.kernel.org/bpf/bpf-next/c/6b66b3a4ed5e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] xen-netback: properly sync TX responses
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski :
On Mon, 29 Jan 2024 14:03:08 +0100 you wrote:
> Invoking the make_tx_response() / push_tx_responses() pair with no lock
> held would be acceptable only if all such invocations happened from the
> same context (NAPI instance or dealloc thread). Since this isn't the
> case, and since the interface "spec" also doesn't demand that multicast
> operations may only be performed with no in-flight transmits,
> MCAST_{ADD,DEL} processing also needs to acquire the response lock
> around the invocations.
>
> [...]
Here is the summary with links:
- [net] xen-netback: properly sync TX responses
https://git.kernel.org/netdev/net/c/7b55984c96ff
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH 0/1] Add software timestamp capabilities to xen-netback device
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 10 Oct 2023 15:26:29 +0100 you wrote: > Hi all, > > during some experiment using PTP (ptp4l) between a Dom0 domain and a DomU > guest, > I noticed that the virtual interface brought up by the toolstack was not able > to be used as ptp4l interface on the Dom0 side, a brief investigation on the > drivers revealed that the backend driver doesn't have the SW timestamp > capabilities, so in order to provide them, I'm sending this patch. > > [...] Here is the summary with links: - [1/1] xen-netback: add software timestamp capabilities https://git.kernel.org/netdev/net-next/c/0b38d2ec2282 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xen-netback: use default TX queue size for vifs
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Thu, 5 Oct 2023 16:08:31 +0200 you wrote: > Do not set netback interfaces (vifs) default TX queue size to the ring size. > The TX queue size is not related to the ring size, and using the ring size > (32) > as the queue size can lead to packet drops. Note the TX side of the vif > interface in the netback domain is the one receiving packets to be injected > to the guest. > > Do not explicitly set the TX queue length to any value when creating the > interface, and instead use the system default. Note that the queue length can > also be adjusted at runtime. > > [...] Here is the summary with links: - xen-netback: use default TX queue size for vifs https://git.kernel.org/netdev/net/c/66cf7435a269 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v3] xen/netback: use same error messages for same errors
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Wed, 29 Mar 2023 10:02:59 +0200 you wrote: > Issue the same error message in case an illegal page boundary crossing > has been detected in both cases where this is tested. > > Suggested-by: Jan Beulich > Signed-off-by: Juergen Gross > --- > V2: > - new patch > V3: > - modify message text (Jan Beulich) > > [...] Here is the summary with links: - [v3] xen/netback: use same error messages for same errors https://git.kernel.org/netdev/net/c/2eca98e5b24d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH 0/2] xen/netback: fix issue introduced recently
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Mon, 27 Mar 2023 10:36:44 +0200 you wrote: > The fix for XSA-423 introduced a bug which resulted in loss of network > connection in some configurations. > > The first patch is fixing the issue, while the second one is removing > a test which isn't needed. > > Juergen Gross (2): > xen/netback: don't do grant copy across page boundary > xen/netback: remove not needed test in xenvif_tx_build_gops() > > [...] Here is the summary with links: - [1/2] xen/netback: don't do grant copy across page boundary https://git.kernel.org/netdev/net/c/05310f31ca74 - [2/2] xen/netback: remove not needed test in xenvif_tx_build_gops() https://git.kernel.org/netdev/net/c/8fb8ebf94877 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2 0/3] xen/netback: fix issue introduced recently
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 28 Mar 2023 15:10:44 +0200 you wrote: > The fix for XSA-423 introduced a bug which resulted in loss of network > connection in some configurations. > > The first patch is fixing the issue, while the second one is removing > a test which isn't needed. The third patch is making error messages > more uniform. > > [...] Here is the summary with links: - [v2,1/3] xen/netback: don't do grant copy across page boundary (no matching commit) - [v2,2/3] xen/netback: remove not needed test in xenvif_tx_build_gops() https://git.kernel.org/netdev/net/c/8fb8ebf94877 - [v2,3/3] xen/netback: use same error messages for same errors (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xen-netback: remove unused variables pending_idx and index
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sun, 26 Feb 2023 11:34:29 -0500 you wrote: > building with gcc and W=1 reports > drivers/net/xen-netback/netback.c:886:21: error: variable > ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] > 886 | u16 pending_idx; > | ^~~ > > pending_idx is not used so remove it. Since index was only > used to set pending_idx, remove index as well. > > [...] Here is the summary with links: - xen-netback: remove unused variables pending_idx and index https://git.kernel.org/netdev/net-next/c/ccf8f7d71424 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] xen/netback: don't call kfree_skb() under spin_lock_irqsave()
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni :
On Mon, 5 Dec 2022 22:13:33 +0800 you wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. So replace kfree_skb()
> with dev_kfree_skb_irq() under spin_lock_irqsave().
>
> Fixes: be81992f9086 ("xen/netback: don't queue unlimited number of packages")
> Signed-off-by: Yang Yingliang
>
> [...]
Here is the summary with links:
- [net] xen/netback: don't call kfree_skb() under spin_lock_irqsave()
https://git.kernel.org/netdev/net/c/9e6246518592
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] xen-netfront: Fix NULL sring after live migration
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 2 Dec 2022 08:52:48 + you wrote: > A NAPI is setup for each network sring to poll data to kernel > The sring with source host is destroyed before live migration and > new sring with target host is setup after live migration. > The NAPI for the old sring is not deleted until setup new sring > with target host after migration. With busy_poll/busy_read enabled, > the NAPI can be polled before got deleted when resume VM. > > [...] Here is the summary with links: - [net] xen-netfront: Fix NULL sring after live migration https://git.kernel.org/netdev/net/c/d50b7914fae0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/4] shrink struct ubuf_info
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Fri, 23 Sep 2022 17:39:00 +0100 you wrote: > struct ubuf_info is large but not all fields are needed for all > cases. We have limited space in io_uring for it and large ubuf_info > prevents some struct embedding, even though we use only a subset > of the fields. It's also not very clean trying to use this typeless > extra space. > > Shrink struct ubuf_info to only necessary fields used in generic paths, > namely ->callback, ->refcnt and ->flags, which take only 16 bytes. And > make MSG_ZEROCOPY and some other users to embed it into a larger struct > ubuf_info_msgzc mimicking the former ubuf_info. > > [...] Here is the summary with links: - [net-next,1/4] net: introduce struct ubuf_info_msgzc https://git.kernel.org/netdev/net-next/c/6eaab4dfdd30 - [net-next,2/4] xen/netback: use struct ubuf_info_msgzc https://git.kernel.org/netdev/net-next/c/b63ca3e822e7 - [net-next,3/4] vhost/net: use struct ubuf_info_msgzc https://git.kernel.org/netdev/net-next/c/dfff202be5ea - [net-next,4/4] net: shrink struct ubuf_info https://git.kernel.org/netdev/net-next/c/e7d2b510165f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xen-netback: use kstrdup instead of open-coding it
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 21 Sep 2022 02:16:17 + you wrote: > From: Minghao Chi > > use kstrdup instead of open-coding it. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > > [...] Here is the summary with links: - xen-netback: use kstrdup instead of open-coding it https://git.kernel.org/netdev/net-next/c/f948ac231333 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH -next] xen-netfront: make bounce_skb static
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 14 Sep 2022 14:43:39 +0800 you wrote: > The symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > ./drivers/net/xen-netfront.c:676:16: warning: symbol 'bounce_skb' was not > declared. Should it be static? > > Signed-off-by: ruanjinjie > > [...] Here is the summary with links: - [-next] xen-netfront: make bounce_skb static https://git.kernel.org/netdev/net-next/c/53ff25170980 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Thu, 1 Sep 2022 12:55:54 +0100 you wrote: > Removing 'hotplug-status' in backend_disconnected() means that it will be > removed even in the case that the frontend unilaterally disconnects (which > it is free to do at any time). The consequence of this is that, when the > frontend attempts to re-connect, the backend gets stuck in 'InitWait' > rather than moving straight to 'Connected' (which it can do because the > hotplug script has already run). > Instead, the 'hotplug-status' mode should be removed in netback_remove() > i.e. when the vif really is going away. > > [...] Here is the summary with links: - [net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed https://git.kernel.org/netdev/net/c/c55f34b6aec2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 13 Jul 2022 15:53:22 +0200 you wrote: > xenvif_rx_next_skb() is expecting the rx queue not being empty, but > in case the loop in xenvif_rx_action() is doing multiple iterations, > the availability of another skb in the rx queue is not being checked. > > This can lead to crashes: > > [40072.537261] BUG: unable to handle kernel NULL pointer dereference at > 0080 > [40072.537407] IP: xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.537534] PGD 0 P4D 0 > [40072.537644] Oops: [#1] SMP NOPTI > [40072.537749] CPU: 0 PID: 12505 Comm: v1-c40247-q2-gu Not tainted > 4.12.14-122.121-default #1 SLE12-SP5 > [40072.537867] Hardware name: HP ProLiant DL580 Gen9/ProLiant DL580 Gen9, > BIOS U17 11/23/2021 > [40072.537999] task: 880433b38100 task.stack: c90043d4 > [40072.538112] RIP: e030:xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.538217] RSP: e02b:c90043d43de0 EFLAGS: 00010246 > [40072.538319] RAX: RBX: c90043cd7cd0 RCX: > 00f7 > [40072.538430] RDX: RSI: 0006 RDI: > c90043d43df8 > [40072.538531] RBP: 003f R08: 77ff8000 R09: > 0008 > [40072.538644] R10: 7ff0 R11: 08f6 R12: > c90043ce2708 > [40072.538745] R13: R14: c90043d43ed0 R15: > 88043ea748c0 > [40072.538861] FS: () GS:88048460() > knlGS: > [40072.538988] CS: e033 DS: ES: CR0: 80050033 > [40072.539088] CR2: 0080 CR3: 000407ac8000 CR4: > 00040660 > [40072.539211] Call Trace: > [40072.539319] xenvif_rx_action+0x71/0x90 [xen_netback] > [40072.539429] xenvif_kthread_guest_rx+0x14a/0x29c [xen_netback] > > [...] Here is the summary with links: - [v2] xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue https://git.kernel.org/netdev/net/c/94e810067888 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/2] xen-netfront: XSA-403 follow-on
Hello: This series was applied to netdev/net-next.git (master) by Paolo Abeni : On Wed, 13 Jul 2022 11:18:03 +0200 you wrote: > While investigating the XSA, I did notice a few more things. The two > patches aren't really dependent on one another. > > 1: remove leftover call to xennet_tx_buf_gc() > 2: re-order error checks in xennet_get_responses() > > Jan Here is the summary with links: - [net-next,1/2] xen-netfront: remove leftover call to xennet_tx_buf_gc() https://git.kernel.org/netdev/net-next/c/ad39bafda736 - [net-next,2/2] xen-netfront: re-order error checks in xennet_get_responses() (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH Resend] xen/netback: do some code cleanup
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 8 Jun 2022 06:37:26 +0200 you wrote: > Remove some unused macros and functions, make local functions static. > > Signed-off-by: Juergen Gross > Acked-by: Wei Liu > --- > drivers/net/xen-netback/common.h| 12 > drivers/net/xen-netback/interface.c | 16 +--- > drivers/net/xen-netback/netback.c | 4 +++- > drivers/net/xen-netback/rx.c| 2 +- > 4 files changed, 5 insertions(+), 29 deletions(-) Here is the summary with links: - [Resend] xen/netback: do some code cleanup https://git.kernel.org/netdev/net-next/c/5834e72eda0b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni :
On Mon, 30 May 2022 13:34:59 +0200 you wrote:
> Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case
> of RING_HAS_UNCONSUMED_REQUESTS().
>
> Reported-by: Jan Beulich
> Fixes: 6fac592cca60 ("xen: update ring.h")
> Signed-off-by: Juergen Gross
>
> [...]
Here is the summary with links:
- xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()
https://git.kernel.org/netdev/net/c/09e545f73814
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] xen/netfront: destroy queues before real_num_tx_queues is zeroed
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller :
On Wed, 23 Feb 2022 22:19:54 +0100 you wrote:
> xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
> delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
> ("net-sysfs: update the queue counts in the unregistration path"),
> unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
> facts together means, that xennet_destroy_queues() called from
> xennet_remove() cannot do its job, because it's called after
> unregister_netdev(). This results in kfree-ing queues that are still
> linked in napi, which ultimately crashes:
>
> [...]
Here is the summary with links:
- [v2] xen/netfront: destroy queues before real_num_tx_queues is zeroed
https://git.kernel.org/netdev/net/c/dcf4ff7a48e7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2 1/2] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"
Hello: This series was applied to netdev/net.git (master) by Jakub Kicinski : On Tue, 22 Feb 2022 01:18:16 +0100 you wrote: > This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. > > The 'hotplug-status' node should not be removed as long as the vif > device remains configured. Otherwise the xen-netback would wait for > re-running the network script even if it was already called (in case of > the frontent re-connecting). But also, it _should_ be removed when the > vif device is destroyed (for example when unbinding the driver) - > otherwise hotplug script would not configure the device whenever it > re-appear. > > [...] Here is the summary with links: - [v2,1/2] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" https://git.kernel.org/netdev/net/c/0f4558ae9187 - [v2,2/2] Revert "xen-netback: Check for hotplug-status existence before watching" https://git.kernel.org/netdev/net/c/e8240addd0a3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH 1/1] xen/netfront: stop tx queues during live migration
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 22 Oct 2021 16:31:39 -0700 you wrote: > The tx queues are not stopped during the live migration. As a result, the > ndo_start_xmit() may access netfront_info->queues which is freed by > talk_to_netback()->xennet_destroy_queues(). > > This patch is to netif_device_detach() at the beginning of xen-netfront > resuming, and netif_device_attach() at the end of resuming. > > [...] Here is the summary with links: - [1/1] xen/netfront: stop tx queues during live migration https://git.kernel.org/netdev/net/c/042b2046d0f0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xen-netback: Remove redundant initialization of variable err
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed, 13 Oct 2021 17:51:42 +0100 you wrote:
> From: Colin Ian King
>
> The variable err is being initialized with a value that is never read, it
> is being updated immediately afterwards. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
>
> [...]
Here is the summary with links:
- xen-netback: Remove redundant initialization of variable err
https://git.kernel.org/netdev/net-next/c/bacc8daf97d4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net][RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 17 Sep 2021 08:27:10 +0200 you wrote: > When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the > special considerations for the head of the SKB no longer apply. Don't > mistakenly report ERROR to the frontend for the first entry in the list, > even if - from all I can tell - this shouldn't matter much as the overall > transmit will need to be considered failed anyway. > > Signed-off-by: Jan Beulich > Reviewed-by: Paul Durrant Here is the summary with links: - [net,RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case https://git.kernel.org/netdev/net/c/3ede7f84c7c2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2 0/4] xen: harden netfront against malicious backends
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 24 Aug 2021 12:28:05 +0200 you wrote: > Xen backends of para-virtualized devices can live in dom0 kernel, dom0 > user land, or in a driver domain. This means that a backend might > reside in a less trusted environment than the Xen core components, so > a backend should not be able to do harm to a Xen guest (it can still > mess up I/O data, but it shouldn't be able to e.g. crash a guest by > other means or cause a privilege escalation in the guest). > > [...] Here is the summary with links: - [v2,1/4] xen/netfront: read response from backend only once https://git.kernel.org/netdev/net-next/c/8446066bf8c1 - [v2,2/4] xen/netfront: don't read data from request on the ring page https://git.kernel.org/netdev/net-next/c/162081ec33c2 - [v2,3/4] xen/netfront: disentangle tx_skb_freelist https://git.kernel.org/netdev/net-next/c/21631d2d741a - [v2,4/4] xen/netfront: don't trust the backend response data blindly https://git.kernel.org/netdev/net-next/c/a884daa61a7d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xen-netback: Check for hotplug-status existence before watching
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 13 Apr 2021 16:25:12 +0100 you wrote:
> The logic in connect() is currently written with the assumption that
> xenbus_watch_pathfmt() will return an error for a node that does not
> exist. This assumption is incorrect: xenstore does allow a watch to
> be registered for a nonexistent node (and will send notifications
> should the node be subsequently created).
>
> As of commit 1f2565780 ("xen-netback: remove 'hotplug-status' once it
> has served its purpose"), this leads to a failure when a domU
> transitions into XenbusStateConnected more than once. On the first
> domU transition into Connected state, the "hotplug-status" node will
> be deleted by the hotplug_status_changed() callback in dom0. On the
> second or subsequent domU transition into Connected state, the
> hotplug_status_changed() callback will therefore never be invoked, and
> so the backend will remain stuck in InitWait.
>
> [...]
Here is the summary with links:
- xen-netback: Check for hotplug-status existence before watching
https://git.kernel.org/netdev/net/c/2afeec08ab5c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 16:39:01 +0100 you wrote: > shinfo already holds the result of skb_shinfo(skb) at this point - no > need to re-invoke the construct even twice. > > Signed-off-by: Jan Beulich Here is the summary with links: - xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating https://git.kernel.org/netdev/net/c/826d82170b53 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 18:17:49 +0800 you wrote: > Fix the following coccicheck warnings: > > ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is > equivalent to !A || B. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > > [...] Here is the summary with links: - drivers: net: xen-netfront: Simplify the calculation of variables https://git.kernel.org/netdev/net-next/c/e93fac3b5161 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [RESEND v2 0/7] Rid W=1 warnings in Ethernet
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 20:08:58 + you wrote: > Resending the stragglers again. > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > No changes since v2, just a rebase onto net-next. > > [...] Here is the summary with links: - [1/7] net: ethernet: smsc: smc91x: Fix function name in kernel-doc header https://git.kernel.org/netdev/net-next/c/7d2a92445e3f - [2/7] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers https://git.kernel.org/netdev/net-next/c/090c7ae8e0d0 - [3/7] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header https://git.kernel.org/netdev/net-next/c/935888cda820 - [4/7] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter https://git.kernel.org/netdev/net-next/c/e49e4647f3e2 - [5/7] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours https://git.kernel.org/netdev/net-next/c/807086021bf5 - [6/7] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours https://git.kernel.org/netdev/net-next/c/b51036321461 - [7/7] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters https://git.kernel.org/netdev/net-next/c/e242d5989965 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
