Re: [PATCH 0/3] Cleanup IOREQ server on exit
Maximilian Heyne writes ("Re: [PATCH 0/3] Cleanup IOREQ server on exit"):
> Could someone please have a look at this patch? It solves an actual issue:
> Try soft-reset with qemu-xen-traditional and it will fail.
Thanks. I reviewed this.
qemu is in deep freeze but the changes looked correct and are indeed
solving a regression. I convinced myself that they were appropriately
low risk, so
Acked-by: Ian Jackson
for all three and I have pushed them.
In theory a backport might be appropriate since this is a bugfix but
my inclination is to leave existing releases where they are, since
anyone using qemu-trad probably wants things super-stable. Contrary
opinions welcome.
It has been a very long time since I did an update of qemu trad so it
is possible that I have mangled the process somehow. We will see I
guess...
Thanks also to Paul for chasing me about this.
Regards,
Ian.
RE: [PATCH 0/3] Cleanup IOREQ server on exit
Ping v2?
> -Original Message-
> From: Maximilian Heyne
> Sent: 07 April 2020 10:16
> To: xen-devel@lists.xenproject.org
> Cc: Ian Jackson ; Paul Durrant
> Subject: Re: [PATCH 0/3] Cleanup IOREQ server on exit
>
> Could someone please have a look at this patch? It solves an actual issue:
> Try soft-reset with qemu-xen-traditional and it will fail.
>
> On 3/13/20 1:33 PM, Maximilian Heyne wrote:
> > Following up on commit 9c0eed61 ("qemu-trad: stop using the default IOREQ
> > server"), clean up the IOREQ server on exit. This fixes a bug with
> > soft-reset
> > that shows up as "bind interdomain ioctl error 22" because the event
> > channels
> > were not closed at the soft-reset and can't be bound again.
> >
> > For this I used the exit notifiers from QEMU that I backported together
> > with the
> > required generic notifier lists.
> >
> > Anthony Liguori (1):
> >Add support for generic notifier lists
> >
> > Gerd Hoffmann (1):
> >Add exit notifiers.
> >
> > Maximilian Heyne (1):
> >xen: cleanup IOREQ server on exit
> >
> > Makefile| 1 +
> > hw/xen_machine_fv.c | 11 +++
> > notify.c| 39 +++
> > notify.h| 43 +++
> > sys-queue.h | 5 +
> > sysemu.h| 5 +
> > vl.c| 20
> > 7 files changed, 124 insertions(+)
> > create mode 100644 notify.c
> > create mode 100644 notify.h
> >
>
>
>
> Amazon Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
> Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
> Sitz: Berlin
> Ust-ID: DE 289 237 879
>
RE: [PATCH 0/3] Cleanup IOREQ server on exit
> -Original Message- > From: Maximilian Heyne > Sent: 07 April 2020 10:16 > To: xen-devel@lists.xenproject.org > Cc: Ian Jackson ; Paul Durrant > Subject: Re: [PATCH 0/3] Cleanup IOREQ server on exit > > Could someone please have a look at this patch? It solves an actual issue: > Try soft-reset with qemu-xen-traditional and it will fail. > I'll take a look today. Ian, obviously we know that qemu trad is largely dead but this series does address a serious shortcoming. Could you take a look? Paul
Re: [PATCH 0/3] Cleanup IOREQ server on exit
Could someone please have a look at this patch? It solves an actual issue:
Try soft-reset with qemu-xen-traditional and it will fail.
On 3/13/20 1:33 PM, Maximilian Heyne wrote:
Following up on commit 9c0eed61 ("qemu-trad: stop using the default IOREQ
server"), clean up the IOREQ server on exit. This fixes a bug with soft-reset
that shows up as "bind interdomain ioctl error 22" because the event channels
were not closed at the soft-reset and can't be bound again.
For this I used the exit notifiers from QEMU that I backported together with the
required generic notifier lists.
Anthony Liguori (1):
Add support for generic notifier lists
Gerd Hoffmann (1):
Add exit notifiers.
Maximilian Heyne (1):
xen: cleanup IOREQ server on exit
Makefile| 1 +
hw/xen_machine_fv.c | 11 +++
notify.c| 39 +++
notify.h| 43 +++
sys-queue.h | 5 +
sysemu.h| 5 +
vl.c| 20
7 files changed, 124 insertions(+)
create mode 100644 notify.c
create mode 100644 notify.h
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
[Xen-devel] [PATCH 0/3] Cleanup IOREQ server on exit
Following up on commit 9c0eed61 ("qemu-trad: stop using the default IOREQ
server"), clean up the IOREQ server on exit. This fixes a bug with soft-reset
that shows up as "bind interdomain ioctl error 22" because the event channels
were not closed at the soft-reset and can't be bound again.
For this I used the exit notifiers from QEMU that I backported together with the
required generic notifier lists.
Anthony Liguori (1):
Add support for generic notifier lists
Gerd Hoffmann (1):
Add exit notifiers.
Maximilian Heyne (1):
xen: cleanup IOREQ server on exit
Makefile| 1 +
hw/xen_machine_fv.c | 11 +++
notify.c| 39 +++
notify.h| 43 +++
sys-queue.h | 5 +
sysemu.h| 5 +
vl.c| 20
7 files changed, 124 insertions(+)
create mode 100644 notify.c
create mode 100644 notify.h
--
2.16.6
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
