RE: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug

[Wei Chen]

Hi Jan,

> -Original Message-
> From: Jan Beulich 
> Sent: 2022年1月25日 0:30
> To: Wei Chen 
> Cc: Bertrand Marquis ; xen-
> de...@lists.xenproject.org; sstabell...@kernel.org; jul...@xen.org
> Subject: Re: [PATCH 10/37] xen/x86: use helpers to access/update
> mem_hotplug
> 
> On 23.09.2021 14:02, Wei Chen wrote:
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct
> acpi_srat_mem_affinity *ma)
> > memblk_nodeid[num_node_memblks] = node;
> > if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
> > __set_bit(num_node_memblks, memblk_hotplug);
> > -   if (end > mem_hotplug)
> > -   mem_hotplug = end;
> > +   if (end > mem_hotplug_boundary())
> > +   mem_hotplug_update_boundary(end);
> 
> Can the if() please be folded into mem_hotplug_update_boundary(),
> eliminating (at least for the purpose here) the need for the
> separate mem_hotplug_boundary()? As said on the previous patch,
> I think the two want folding.
> 

Yes, these changes would be more make sense. I will do it in next
version.

> Jan

Re: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug

[Jan Beulich]

On 23.09.2021 14:02, Wei Chen wrote:
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct 
> acpi_srat_mem_affinity *ma)
>   memblk_nodeid[num_node_memblks] = node;
>   if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
>   __set_bit(num_node_memblks, memblk_hotplug);
> - if (end > mem_hotplug)
> - mem_hotplug = end;
> + if (end > mem_hotplug_boundary())
> + mem_hotplug_update_boundary(end);

Can the if() please be folded into mem_hotplug_update_boundary(),
eliminating (at least for the purpose here) the need for the
separate mem_hotplug_boundary()? As said on the previous patch,
I think the two want folding.

Jan

RE: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug

[Wei Chen]

> -Original Message-
> From: Xen-devel  On Behalf Of
> Stefano Stabellini
> Sent: 2021年9月24日 8:32
> To: Wei Chen 
> Cc: xen-devel@lists.xenproject.org; sstabell...@kernel.org; jul...@xen.org;
> Bertrand Marquis ; jbeul...@suse.com;
> andrew.coop...@citrix.com; roger@citrix.com; w...@xen.org
> Subject: Re: [PATCH 10/37] xen/x86: use helpers to access/update
> mem_hotplug
> 
> +x86 maintainers
> 
> 
> On Thu, 23 Sep 2021, Wei Chen wrote:
> > We want to abstract code from acpi_numa_memory_affinity_init.
> > But mem_hotplug is coupled with x86. In this patch, we use
> > helpers to repace mem_hotplug direct accessing. This will
>  ^ replace
> 
> > allow most code can be common.
>   ^ to be
> 
> I think this patch could be merged with the previous patch
> 

Ok, I will do it, and fix above typos

> 
> > Signed-off-by: Wei Chen 
> > ---
> >  xen/arch/x86/srat.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
> > index 2f08fa4660..3334ede7a5 100644
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct
> acpi_srat_mem_affinity *ma)
> > memblk_nodeid[num_node_memblks] = node;
> > if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
> > __set_bit(num_node_memblks, memblk_hotplug);
> > -   if (end > mem_hotplug)
> > -   mem_hotplug = end;
> > +   if (end > mem_hotplug_boundary())
> > +   mem_hotplug_update_boundary(end);
> > }
> > num_node_memblks++;
> >  }
> > --
> > 2.25.1
> >

Re: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug

[Stefano Stabellini]

+x86 maintainers


On Thu, 23 Sep 2021, Wei Chen wrote:
> We want to abstract code from acpi_numa_memory_affinity_init.
> But mem_hotplug is coupled with x86. In this patch, we use
> helpers to repace mem_hotplug direct accessing. This will
 ^ replace

> allow most code can be common.
  ^ to be

I think this patch could be merged with the previous patch


> Signed-off-by: Wei Chen 
> ---
>  xen/arch/x86/srat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
> index 2f08fa4660..3334ede7a5 100644
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct 
> acpi_srat_mem_affinity *ma)
>   memblk_nodeid[num_node_memblks] = node;
>   if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
>   __set_bit(num_node_memblks, memblk_hotplug);
> - if (end > mem_hotplug)
> - mem_hotplug = end;
> + if (end > mem_hotplug_boundary())
> + mem_hotplug_update_boundary(end);
>   }
>   num_node_memblks++;
>  }
> -- 
> 2.25.1
> 

[PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug

[Wei Chen]

We want to abstract code from acpi_numa_memory_affinity_init.
But mem_hotplug is coupled with x86. In this patch, we use
helpers to repace mem_hotplug direct accessing. This will
allow most code can be common.

Signed-off-by: Wei Chen 
---
 xen/arch/x86/srat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index 2f08fa4660..3334ede7a5 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct 
acpi_srat_mem_affinity *ma)
memblk_nodeid[num_node_memblks] = node;
if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
__set_bit(num_node_memblks, memblk_hotplug);
-   if (end > mem_hotplug)
-   mem_hotplug = end;
+   if (end > mem_hotplug_boundary())
+   mem_hotplug_update_boundary(end);
}
num_node_memblks++;
 }
-- 
2.25.1