Re: [PATCH 2/2] Kbuild: simplify as-insn a little

[Anthony PERARD]

On Thu, Dec 07, 2023 at 11:49:04AM +0100, Jan Beulich wrote:
> As of 732571959f17 ("xen/build: use new $(c_flags) and $(a_flags)
> instead of $(CFLAGS)") -M options aren't part of CFLAGS anymore, and
> c_flags isn't supposed to be passed to this macro. Drop the now dead
> part of filtering.
> 
> Signed-off-by: Jan Beulich 

Reviewed-by: Anthony PERARD 

Thanks,

-- 
Anthony PERARD

[PATCH 2/2] Kbuild: simplify as-insn a little

[Jan Beulich]

As of 732571959f17 ("xen/build: use new $(c_flags) and $(a_flags)
instead of $(CFLAGS)") -M options aren't part of CFLAGS anymore, and
c_flags isn't supposed to be passed to this macro. Drop the now dead
part of filtering.

Signed-off-by: Jan Beulich 

--- a/xen/scripts/Kbuild.include
+++ b/xen/scripts/Kbuild.include
@@ -59,7 +59,7 @@ endef
 # as-insn: Check whether assembler supports an instruction.
 # Usage: cflags-y += $(call as-insn,CC FLAGS,"insn",option-yes,option-no)
 as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \
-   | $(filter-out -M% %.d -include 
%/include/xen/config.h,$(1)) \
+   | $(filter-out -include %/include/xen/config.h,$(1)) \
   -c -x c -o /dev/null - 2>&1),$(4),$(3))
 
 # as-option-add: Conditionally add options to flags