Re: [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state

2024-05-20 Thread Andrew Cooper 
On 17/05/2024 2:56 pm, Roger Pau Monne wrote:
> Use the same check that's used in dump_irqs().
>
> Signed-off-by: Roger Pau Monné 

Acked-by: Andrew Cooper

Re: [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state

2024-05-20 Thread Oleksii K. 
On Fri, 2024-05-17 at 15:56 +0200, Roger Pau Monne wrote:
> Use the same check that's used in dump_irqs().
> 
> Signed-off-by: Roger Pau Monné 
> ---
>  xen/arch/x86/msi.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
> index 19830528b65a..0c97fbb3fc03 100644
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -17,6 +17,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -1451,6 +1452,9 @@ static void cf_check dump_msi(unsigned char
> key)
>  unsigned long flags;
>  const char *type = "???";
>  
> +    if ( !(irq & 0x1f) )
> +    process_pending_softirqs();
> +
>  if ( !irq_desc_initialized(desc) )
>  continue;
>  

Release-acked-by: Oleksii Kurochko 

~ Oleksii

[PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state

2024-05-17 Thread Roger Pau Monne 
Use the same check that's used in dump_irqs().

Signed-off-by: Roger Pau Monné 
---
 xen/arch/x86/msi.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 19830528b65a..0c97fbb3fc03 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -17,6 +17,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1451,6 +1452,9 @@ static void cf_check dump_msi(unsigned char key)
 unsigned long flags;
 const char *type = "???";
 
+if ( !(irq & 0x1f) )
+process_pending_softirqs();
+
 if ( !irq_desc_initialized(desc) )
 continue;
 
-- 
2.44.0