Re: [PATCH v2] xen/arm: smmu: Set/clear IOMMU domain for device
On 18/08/2021 18:42, Julien Grall wrote:
On 18/08/2021 06:22, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
When a device is assigned/de-assigned it is required to properly set
IOMMU domain used to protect the device. This assignment was missing,
thus it was not possible to de-assign the device:
(XEN) Deassigning device :03:00.0 from dom2
(XEN) smmu: :03:00.0: not attached to domain 2
(XEN) d2: deassign (:03:00.0) failed (-3)
Fix this by assigning IOMMU domain on arm_smmu_assign_dev and reset it
to NULL on arm_smmu_deassign_dev.
Fixes: 06d1f7a278dd ("xen/arm: smmuv1: Keep track of S2CR state")
Signed-off-by: Oleksandr Andrushchenko
Signed-off-by: Oleksandr Tyshchenko
Reviewed-by: Julien Grall
I have just committed it.
Cheers,
--
Julien Grall
Re: [PATCH v2] xen/arm: smmu: Set/clear IOMMU domain for device
Hi Oleksandr,
On 18/08/2021 06:22, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
When a device is assigned/de-assigned it is required to properly set
IOMMU domain used to protect the device. This assignment was missing,
thus it was not possible to de-assign the device:
(XEN) Deassigning device :03:00.0 from dom2
(XEN) smmu: :03:00.0: not attached to domain 2
(XEN) d2: deassign (:03:00.0) failed (-3)
Fix this by assigning IOMMU domain on arm_smmu_assign_dev and reset it
to NULL on arm_smmu_deassign_dev.
Fixes: 06d1f7a278dd ("xen/arm: smmuv1: Keep track of S2CR state")
Signed-off-by: Oleksandr Andrushchenko
Signed-off-by: Oleksandr Tyshchenko
Reviewed-by: Julien Grall
Cheers,
--
Julien Grall
[PATCH v2] xen/arm: smmu: Set/clear IOMMU domain for device
From: Oleksandr Andrushchenko
When a device is assigned/de-assigned it is required to properly set
IOMMU domain used to protect the device. This assignment was missing,
thus it was not possible to de-assign the device:
(XEN) Deassigning device :03:00.0 from dom2
(XEN) smmu: :03:00.0: not attached to domain 2
(XEN) d2: deassign (:03:00.0) failed (-3)
Fix this by assigning IOMMU domain on arm_smmu_assign_dev and reset it
to NULL on arm_smmu_deassign_dev.
Fixes: 06d1f7a278dd ("xen/arm: smmuv1: Keep track of S2CR state")
Signed-off-by: Oleksandr Andrushchenko
Signed-off-by: Oleksandr Tyshchenko
---
v2:
Fixed NULL assignment out of refcount == 0 check for domain
Added "Fixes" tag
---
xen/drivers/passthrough/arm/smmu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/drivers/passthrough/arm/smmu.c
b/xen/drivers/passthrough/arm/smmu.c
index c234ad9c7f1e..c9dfc4caa0d6 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2768,6 +2768,7 @@ static int arm_smmu_assign_dev(struct domain *d, u8 devfn,
arm_smmu_destroy_iommu_domain(domain);
} else {
atomic_inc(>ref);
+ dev_iommu_domain(dev) = domain;
}
out:
@@ -2791,6 +2792,7 @@ static int arm_smmu_deassign_dev(struct domain *d, struct
device *dev)
spin_lock(_domain->lock);
arm_smmu_detach_dev(domain, dev);
+ dev_iommu_domain(dev) = NULL;
atomic_dec(>ref);
if (domain->ref.counter == 0)
--
2.25.1
