Re: [PATCH v2 07/47] xenbus/backend: dynamically allocate the xen-backend shrinker

[Muchun Song]

> On Jul 24, 2023, at 17:43, Qi Zheng  wrote:
> 
> Use new APIs to dynamically allocate the xen-backend shrinker.
> 
> Signed-off-by: Qi Zheng 

Reviewed-by: Muchun Song 

Thanks.

[PATCH v2 07/47] xenbus/backend: dynamically allocate the xen-backend shrinker

[Qi Zheng]

Use new APIs to dynamically allocate the xen-backend shrinker.

Signed-off-by: Qi Zheng 
---
 drivers/xen/xenbus/xenbus_probe_backend.c | 17 +++--
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/xen/xenbus/xenbus_probe_backend.c 
b/drivers/xen/xenbus/xenbus_probe_backend.c
index da96c260e26b..b4c3cf27af30 100644
--- a/drivers/xen/xenbus/xenbus_probe_backend.c
+++ b/drivers/xen/xenbus/xenbus_probe_backend.c
@@ -284,10 +284,7 @@ static unsigned long backend_shrink_memory_count(struct 
shrinker *shrinker,
return 0;
 }
 
-static struct shrinker backend_memory_shrinker = {
-   .count_objects = backend_shrink_memory_count,
-   .seeks = DEFAULT_SEEKS,
-};
+static struct shrinker *backend_memory_shrinker;
 
 static int __init xenbus_probe_backend_init(void)
 {
@@ -305,8 +302,16 @@ static int __init xenbus_probe_backend_init(void)
 
register_xenstore_notifier(&xenstore_notifier);
 
-   if (register_shrinker(&backend_memory_shrinker, "xen-backend"))
-   pr_warn("shrinker registration failed\n");
+   backend_memory_shrinker = shrinker_alloc(0, "xen-backend");
+   if (!backend_memory_shrinker) {
+   pr_warn("shrinker allocation failed\n");
+   return 0;
+   }
+
+   backend_memory_shrinker->count_objects = backend_shrink_memory_count;
+   backend_memory_shrinker->seeks = DEFAULT_SEEKS;
+
+   shrinker_register(backend_memory_shrinker);
 
return 0;
 }
-- 
2.30.2