Re: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending

2022-01-26 Thread Jan Beulich 
On 26.01.2022 09:31, Oleksandr Andrushchenko wrote:
> On 11.12.21 10:57, Oleksandr Andrushchenko wrote:
>> On 11.12.21 10:20, Roger Pau Monné wrote:
>>> I think this can be committed independently of the rest of the
>>> series?
>> I think so
> Could you please commit this one, so I don't have to keep it in the v6 of the 
> series?

Did you actually check before asking? See commit 7dc0233f534f from Dec 14th.

Jan

Re: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending

2022-01-26 Thread Oleksandr Andrushchenko 
Hi, Roger!

On 11.12.21 10:57, Oleksandr Andrushchenko wrote:
> Hi, Roger!
>
> On 11.12.21 10:20, Roger Pau Monné wrote:
>> On Fri, Dec 10, 2021 at 05:55:03PM +, Julien Grall wrote:
>>> Hi Oleksandr,
>>>
>>> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
 From: Oleksandr Andrushchenko 

 vpci_process_pending is defined with different attributes, e.g.
 with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
 Fix this by defining both of the definitions with __must_check.

 Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building 
 a shim-only binary")

 Signed-off-by: Oleksandr Andrushchenko 
>>> Reviewed-by: Julien Grall 
>> Reviewed-by: Roger Pau Monné 
>>
>> I think this can be committed independently of the rest of the
>> series?
> I think so
Could you please commit this one, so I don't have to keep it in the v6 of the 
series?

Thank you in advance,
Oleksandr
>> Thanks, Roger.
> Thank you,
> Oleksandr

Re: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending

2021-12-11 Thread Oleksandr Andrushchenko 
Hi, Roger!

On 11.12.21 10:20, Roger Pau Monné wrote:
> On Fri, Dec 10, 2021 at 05:55:03PM +, Julien Grall wrote:
>> Hi Oleksandr,
>>
>> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko 
>>>
>>> vpci_process_pending is defined with different attributes, e.g.
>>> with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
>>> Fix this by defining both of the definitions with __must_check.
>>>
>>> Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a 
>>> shim-only binary")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko 
>> Reviewed-by: Julien Grall 
> Reviewed-by: Roger Pau Monné 
>
> I think this can be committed independently of the rest of the
> series?
I think so
>
> Thanks, Roger.
Thank you,
Oleksandr

Re: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending

2021-12-11 Thread Roger Pau Monné 
On Fri, Dec 10, 2021 at 05:55:03PM +, Julien Grall wrote:
> Hi Oleksandr,
> 
> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko 
> > 
> > vpci_process_pending is defined with different attributes, e.g.
> > with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
> > Fix this by defining both of the definitions with __must_check.
> > 
> > Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a 
> > shim-only binary")
> > 
> > Signed-off-by: Oleksandr Andrushchenko 
> 
> Reviewed-by: Julien Grall 

Reviewed-by: Roger Pau Monné 

I think this can be committed independently of the rest of the
series?

Thanks, Roger.

Re: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending

2021-12-10 Thread Julien Grall 

Hi Oleksandr,

On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:

From: Oleksandr Andrushchenko 

vpci_process_pending is defined with different attributes, e.g.
with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
Fix this by defining both of the definitions with __must_check.

Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a 
shim-only binary")

Signed-off-by: Oleksandr Andrushchenko 


Reviewed-by: Julien Grall 

Cheers,

--
Julien Grall

[PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending

2021-11-25 Thread Oleksandr Andrushchenko 
From: Oleksandr Andrushchenko 

vpci_process_pending is defined with different attributes, e.g.
with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
Fix this by defining both of the definitions with __must_check.

Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a 
shim-only binary")

Signed-off-by: Oleksandr Andrushchenko 

---
Cc: Roger Pau Monné 

New in v4
---
 xen/include/xen/vpci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 9ea66e033f11..3f32de9d7eb3 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -247,7 +247,7 @@ static inline void vpci_write(pci_sbdf_t sbdf, unsigned int 
reg,
 ASSERT_UNREACHABLE();
 }
 
-static inline bool vpci_process_pending(struct vcpu *v)
+static inline bool __must_check vpci_process_pending(struct vcpu *v)
 {
 ASSERT_UNREACHABLE();
 return false;
-- 
2.25.1