RE: [PATCH v9 4/8] docs/specs: add missing definitions to libxc-migration-stream
> -Original Message- > From: Andrew Cooper > Sent: 02 October 2020 23:42 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; George Dunlap > ; Ian Jackson > ; Jan Beulich ; Julien Grall > ; Stefano > Stabellini ; Wei Liu > Subject: RE: [EXTERNAL] [PATCH v9 4/8] docs/specs: add missing definitions to > libxc-migration-stream > > CAUTION: This email originated from outside of the organization. Do not click > links or open > attachments unless you can confirm the sender and know the content is safe. > > > > On 24/09/2020 14:10, Paul Durrant wrote: > > From: Paul Durrant > > > > The STATIC_DATA_END, X86_CPUID_POLICY and X86_MSR_POLICY record types have > > sections explaining what they are but their values are not defined. Indeed > > their values are defined as "Reserved for future mandatory records." > > > > Also, the spec revision is adjusted to match the migration stream version > > and an END record is added to the description of a 'typical save record for > > and x86 HVM guest.' > > > > Signed-off-by: Paul Durrant > > Fixes: 6f71b5b1506 ("docs/migration Specify migration v3 and > > STATIC_DATA_END") > > Fixes: ddd273d8863 ("docs/migration: Specify X86_{CPUID,MSR}_POLICY > > records") > > Oops sorry. I swear I had these at one point. I can only presume it > got swallowed by a rebase at some point. > Can I take that as an R-b? Paul > ~Andrew
Re: [PATCH v9 4/8] docs/specs: add missing definitions to libxc-migration-stream
On 24/09/2020 14:10, Paul Durrant wrote: > From: Paul Durrant > > The STATIC_DATA_END, X86_CPUID_POLICY and X86_MSR_POLICY record types have > sections explaining what they are but their values are not defined. Indeed > their values are defined as "Reserved for future mandatory records." > > Also, the spec revision is adjusted to match the migration stream version > and an END record is added to the description of a 'typical save record for > and x86 HVM guest.' > > Signed-off-by: Paul Durrant > Fixes: 6f71b5b1506 ("docs/migration Specify migration v3 and STATIC_DATA_END") > Fixes: ddd273d8863 ("docs/migration: Specify X86_{CPUID,MSR}_POLICY records") Oops sorry. I swear I had these at one point. I can only presume it got swallowed by a rebase at some point. ~Andrew
Re: [PATCH v9 4/8] docs/specs: add missing definitions to libxc-migration-stream
On Thu, Sep 24, 2020 at 02:10:26PM +0100, Paul Durrant wrote: > From: Paul Durrant > > The STATIC_DATA_END, X86_CPUID_POLICY and X86_MSR_POLICY record types have > sections explaining what they are but their values are not defined. Indeed > their values are defined as "Reserved for future mandatory records." > > Also, the spec revision is adjusted to match the migration stream version > and an END record is added to the description of a 'typical save record for > and x86 HVM guest.' > > Signed-off-by: Paul Durrant > Fixes: 6f71b5b1506 ("docs/migration Specify migration v3 and STATIC_DATA_END") > Fixes: ddd273d8863 ("docs/migration: Specify X86_{CPUID,MSR}_POLICY records") Acked-by: Wei Liu
[PATCH v9 4/8] docs/specs: add missing definitions to libxc-migration-stream
From: Paul Durrant The STATIC_DATA_END, X86_CPUID_POLICY and X86_MSR_POLICY record types have sections explaining what they are but their values are not defined. Indeed their values are defined as "Reserved for future mandatory records." Also, the spec revision is adjusted to match the migration stream version and an END record is added to the description of a 'typical save record for and x86 HVM guest.' Signed-off-by: Paul Durrant Fixes: 6f71b5b1506 ("docs/migration Specify migration v3 and STATIC_DATA_END") Fixes: ddd273d8863 ("docs/migration: Specify X86_{CPUID,MSR}_POLICY records") --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu v7: - New in v7 --- docs/specs/libxc-migration-stream.pandoc | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/docs/specs/libxc-migration-stream.pandoc b/docs/specs/libxc-migration-stream.pandoc index 6b0c49e97a..8aeab3b11b 100644 --- a/docs/specs/libxc-migration-stream.pandoc +++ b/docs/specs/libxc-migration-stream.pandoc @@ -3,7 +3,7 @@ Andrew Cooper <> Wen Congyang <> Yang Hongyang <> -% Revision 2 +% Revision 3 Introduction @@ -227,7 +227,13 @@ type 0x: END 0x000F: CHECKPOINT_DIRTY_PFN_LIST (Secondary -> Primary) - 0x0010 - 0x7FFF: Reserved for future _mandatory_ + 0x0010: STATIC_DATA_END + + 0x0011: X86_CPUID_POLICY + + 0x0012: X86_MSR_POLICY + + 0x0013 - 0x7FFF: Reserved for future _mandatory_ records. 0x8000 - 0x: Reserved for future _optional_ @@ -732,6 +738,7 @@ A typical save record for an x86 HVM guest image would look like: * X86_TSC_INFO * HVM_PARAMS * HVM_CONTEXT +* END record HVM_PARAMS must precede HVM_CONTEXT, as certain parameters can affect the validity of architectural state in the context. -- 2.20.1