Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration

2023-08-08 Thread Jan Beulich 
On 08.08.2023 22:15, Stefano Stabellini wrote:
> On Tue, 8 Aug 2023, Jan Beulich wrote:
>> On 04.08.2023 23:39, Stefano Stabellini wrote:
>>> Hi Tamas,
>>>
>>> May I have your ack on this change?
>>
>> I see you committed this, and there is an ack in the commit, but I can't
>> see any ack on list (incl when checking mail archives, to exclude an
>> issue with my mailbox).
> 
> That is strange! Something appears to be wrong with xen-devel. Adding
> George in CC and attaching Tamas' reply.

Yet more strange: The attachment (as it arrived here) is zero size. But
I can see it at
https://lists.xen.org/archives/html/xen-devel/2023-08/msg00959.html
Part of the reason may be that it looks to have been a HTML mail (which
it shouldn't have been).

Jan

Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration

2023-08-08 Thread Stefano Stabellini 
On Tue, 8 Aug 2023, Jan Beulich wrote:
> On 04.08.2023 23:39, Stefano Stabellini wrote:
> > Hi Tamas,
> > 
> > May I have your ack on this change?
> 
> I see you committed this, and there is an ack in the commit, but I can't
> see any ack on list (incl when checking mail archives, to exclude an
> issue with my mailbox).

That is strange! Something appears to be wrong with xen-devel. Adding
George in CC and attaching Tamas' reply.


> > On Thu, 27 Jul 2023, Federico Serafini wrote:
> >> Change parameter name in monitor_domctl() declaration for
> >> consistency with the corresponding definition.
> >> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> >> of an object or function shall use the same names and type qualifiers".
> >>
> >> No functional changes.
> >>
> >> Signed-off-by: Federico Serafini 
> > 
> > Reviewed-by: Stefano Stabellini 
> > 
> > 
> >> ---
> >>  xen/include/xen/monitor.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
> >> index 6b17a93071..713d54f7c1 100644
> >> --- a/xen/include/xen/monitor.h
> >> +++ b/xen/include/xen/monitor.h
> >> @@ -27,7 +27,7 @@
> >>  struct domain;
> >>  struct xen_domctl_monitor_op;
> >>  
> >> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
> >> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
> >>  void monitor_guest_request(void);
> >>  
> >>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
> >> -- 
> >> 2.34.1
> >>
> >>
> > 
> --- Begin Message ---
On Fri, Aug 4, 2023, 11:39 PM Stefano Stabellini sstabell...@kernel.org> 
wrote:Hi Tamas,

May I have your ack on this change?


On Thu, 27 Jul 2023, Federico Serafini wrote:
> Change parameter name in monitor_domctl() declaration for
> consistency with the corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3: "All 
declarations
> of an object or function shall use the same names and type 
qualifiers".
> 
> No functional changes.
> 
> Signed-off-by: Federico Serafini federico.seraf...@bugseng.com>

Reviewed-by: Stefano Stabellini sstabell...@kernel.org>Acked-by: Tamas K Lengyel ta...@tklengyel.com>

--- End Message ---

Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration

2023-08-08 Thread Jan Beulich 
On 04.08.2023 23:39, Stefano Stabellini wrote:
> Hi Tamas,
> 
> May I have your ack on this change?

I see you committed this, and there is an ack in the commit, but I can't
see any ack on list (incl when checking mail archives, to exclude an
issue with my mailbox).

Jan

> On Thu, 27 Jul 2023, Federico Serafini wrote:
>> Change parameter name in monitor_domctl() declaration for
>> consistency with the corresponding definition.
>> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
>> of an object or function shall use the same names and type qualifiers".
>>
>> No functional changes.
>>
>> Signed-off-by: Federico Serafini 
> 
> Reviewed-by: Stefano Stabellini 
> 
> 
>> ---
>>  xen/include/xen/monitor.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
>> index 6b17a93071..713d54f7c1 100644
>> --- a/xen/include/xen/monitor.h
>> +++ b/xen/include/xen/monitor.h
>> @@ -27,7 +27,7 @@
>>  struct domain;
>>  struct xen_domctl_monitor_op;
>>  
>> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
>> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
>>  void monitor_guest_request(void);
>>  
>>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
>> -- 
>> 2.34.1
>>
>>
>

Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration

2023-08-04 Thread Stefano Stabellini 
Hi Tamas,

May I have your ack on this change?


On Thu, 27 Jul 2023, Federico Serafini wrote:
> Change parameter name in monitor_domctl() declaration for
> consistency with the corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> of an object or function shall use the same names and type qualifiers".
> 
> No functional changes.
> 
> Signed-off-by: Federico Serafini 

Reviewed-by: Stefano Stabellini 


> ---
>  xen/include/xen/monitor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
> index 6b17a93071..713d54f7c1 100644
> --- a/xen/include/xen/monitor.h
> +++ b/xen/include/xen/monitor.h
> @@ -27,7 +27,7 @@
>  struct domain;
>  struct xen_domctl_monitor_op;
>  
> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
>  void monitor_guest_request(void);
>  
>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
> -- 
> 2.34.1
> 
>

Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration

2023-07-27 Thread Luca Fancellu 



> On 27 Jul 2023, at 16:35, Federico Serafini  
> wrote:
> 
> Change parameter name in monitor_domctl() declaration for
> consistency with the corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> of an object or function shall use the same names and type qualifiers".
> 
> No functional changes.
> 
> Signed-off-by: Federico Serafini 

Reviewed-by: Luca Fancellu

[XEN PATCH] xen: change parameter name in monitor_domctl() declaration

2023-07-27 Thread Federico Serafini 
Change parameter name in monitor_domctl() declaration for
consistency with the corresponding definition.
This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
of an object or function shall use the same names and type qualifiers".

No functional changes.

Signed-off-by: Federico Serafini 
---
 xen/include/xen/monitor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
index 6b17a93071..713d54f7c1 100644
--- a/xen/include/xen/monitor.h
+++ b/xen/include/xen/monitor.h
@@ -27,7 +27,7 @@
 struct domain;
 struct xen_domctl_monitor_op;
 
-int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
+int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
 void monitor_guest_request(void);
 
 int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
-- 
2.34.1