Re: [XEN PATCH 00/15] build: cleanup build log, avoid user's CFLAGS, avoid too many include of Config.mk
On 23/05/2023 5:37 pm, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > br.build-system-xen-removing-config.mk-v1 > > Hi, > > This series of patch cleanup the remaining rules still displaying their > command > line. > > Then, some change are made in Config.mk to remove build-id stuff only used by > Xen build. > > Then, the variable AFLAGS and CFLAGS are been renamed XEN_AFLAGS and > XEN_CFLAGS > from the beginning to about inclusion of users CFLAGS as those are usually > made > for user space program, not kernel, especially in build environment for distro > packages. > > Last patch removes the inclusion of Config.mk from xen/Rules.mk, as this slow > down the build unnecessarily. xen/Makefile should do everything necessary to > setup the build of the hypervisor, and is its only entry point. Thankyou for doing this. I'm tempted to summarily ack it, but lets do things properly. One thing though, which I think might be a regression but I'm not sure. When doing an incremental build (second build with no change), we get: ... UPD include/xen/compile.h __ __ _ _ _ ___ _ _ _ \ \/ /___ _ __ | || | / |( _ ) _ _ _ __ ___| |_ __ _| |__ | | ___ \ // _ \ '_ \ | || |_ | |/ _ \ __| | | | '_ \/ __| __/ _` | '_ \| |/ _ \ / \ __/ | | | |__ _|| | (_) |__| |_| | | | \__ \ || (_| | |_) | | __/ /_/\_\___|_| |_| |_|(_)_|\___/ \__,_|_| |_|___/\__\__,_|_.__/|_|\___| make[2]: Nothing to be done for 'all'. make[4]: Nothing to be done for 'all'. CC common/version.o CC arch/x86/efi/boot.o ... Where I think those two "nothing to be done for 'all'" are new. I don't see them in a build from clean. ~Andrew P.S. I do have some other notes for further cleanup, but I'm not going to extend this current series with them.
[XEN PATCH 00/15] build: cleanup build log, avoid user's CFLAGS, avoid too many include of Config.mk
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-system-xen-removing-config.mk-v1 Hi, This series of patch cleanup the remaining rules still displaying their command line. Then, some change are made in Config.mk to remove build-id stuff only used by Xen build. Then, the variable AFLAGS and CFLAGS are been renamed XEN_AFLAGS and XEN_CFLAGS from the beginning to about inclusion of users CFLAGS as those are usually made for user space program, not kernel, especially in build environment for distro packages. Last patch removes the inclusion of Config.mk from xen/Rules.mk, as this slow down the build unnecessarily. xen/Makefile should do everything necessary to setup the build of the hypervisor, and is its only entry point. Thanks, Anthony PERARD (15): build: hide that we are updating xen/lib/x86 build: rework asm-offsets.* build step to use kbuild build, x86: clean build log for boot/ targets build: hide policy.bin commands build: introduce a generic command for gzip build: quiet for .allconfig.tmp target build: move XEN_HAS_BUILD_ID out of Config.mk build: use $(filechk, ) for all compat/.xlat/%.lst build: hide commands run for kconfig build: rename $(AFLAGS) to $(XEN_AFLAGS) build: rename CFLAGS to XEN_CFLAGS in xen/Makefile build: avoid Config.mk's CFLAGS build: fix compile.h compiler version command line Config.mk: move $(cc-option, ) to config/compiler-testing.mk build: remove Config.mk include from Rules.mk Config.mk | 39 +-- config/compiler-testing.mk | 25 + xen/Makefile| 75 + xen/Rules.mk| 7 +++- xen/arch/arm/Makefile | 2 +- xen/arch/arm/arch.mk| 8 +++- xen/arch/riscv/Makefile | 2 +- xen/arch/riscv/arch.mk | 4 +- xen/arch/x86/Makefile | 12 +++--- xen/arch/x86/arch.mk| 62 +++--- xen/arch/x86/boot/Makefile | 16 ++-- xen/build.mk| 24 +++- xen/common/Makefile | 8 ++-- xen/include/Makefile| 10 ++--- xen/scripts/Kbuild.include | 10 + xen/test/livepatch/Makefile | 4 +- xen/tools/kconfig/Makefile | 14 +++ xen/xsm/flask/Makefile | 9 - 18 files changed, 193 insertions(+), 138 deletions(-) create mode 100644 config/compiler-testing.mk -- Anthony PERARD