Re: [XEN PATCH 2/4] build: set PERL
On Thu, Jun 02, 2022 at 11:01:30AM +0200, Jan Beulich wrote: > On 01.06.2022 18:59, Anthony PERARD wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER:= $(word 1,$(shell which > > python3 python python2 2>/dev/null) > > export PYTHON ?= $(PYTHON_INTERPRETER) > > > > export CHECKPOLICY ?= checkpolicy > > +export PERL?= perl > > For the intended use, is there a minimum version requirement? If so, > it needs documenting in ./README (and it preferably wouldn't be any > newer than from around the times our other dependencies are). And > even when the uses are fully backwards compatible, I think the need > for the tool wants mentioning there. I don't think there's a minimum version. The script works in our Gitlab CI, or at least the builds don't break. Yes, it would be better to document the tool, I'll add it to the README. (We already use it in the toolstack, at least for libxl, so it was at least partially needed before.) Thanks, -- Anthony PERARD
Re: [XEN PATCH 2/4] build: set PERL
On 01.06.2022 18:59, Anthony PERARD wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER := $(word 1,$(shell which python3 > python python2 2>/dev/null) > export PYTHON?= $(PYTHON_INTERPRETER) > > export CHECKPOLICY ?= checkpolicy > +export PERL ?= perl For the intended use, is there a minimum version requirement? If so, it needs documenting in ./README (and it preferably wouldn't be any newer than from around the times our other dependencies are). And even when the uses are fully backwards compatible, I think the need for the tool wants mentioning there. Jan
[XEN PATCH 2/4] build: set PERL
We are going to use it in a moment. Signed-off-by: Anthony PERARD --- xen/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/Makefile b/xen/Makefile index 82f5310b12..a6650a2acc 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -22,6 +22,7 @@ PYTHON_INTERPRETER:= $(word 1,$(shell which python3 python python2 2>/dev/null) export PYTHON ?= $(PYTHON_INTERPRETER) export CHECKPOLICY ?= checkpolicy +export PERL?= perl $(if $(filter __%, $(MAKECMDGOALS)), \ $(error targets prefixed with '__' are only for internal use)) -- Anthony PERARD
