Re: [Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values
On 09/12/2019 10.50, Philippe Mathieu-Daudé wrote:
> Use definitions from "hw/pci/pci_regs.h".
> This also helps when using git-grep.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/pci-host/i440fx.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c
> index 0cc80b276d..414138595b 100644
> --- a/hw/pci-host/i440fx.c
> +++ b/hw/pci-host/i440fx.c
> @@ -376,13 +376,13 @@ typedef struct {
>
> /* Here we just expose minimal host bridge offset subset. */
> static const IGDHostInfo igd_host_bridge_infos[] = {
> -{0x08, 2}, /* revision id */
> -{0x2c, 2}, /* sybsystem vendor id */
> -{0x2e, 2}, /* sybsystem id */
> -{0x50, 2}, /* SNB: processor graphics control register */
> -{0x52, 2}, /* processor graphics control register */
> -{0xa4, 4}, /* SNB: graphics base of stolen memory */
> -{0xa8, 4}, /* SNB: base of GTT stolen memory */
> +{PCI_REVISION_ID, 2},
> +{PCI_SUBSYSTEM_VENDOR_ID, 2},
> +{PCI_SUBSYSTEM_ID,2},
> +{0x50,2}, /* SNB: processor graphics control
> register */
> +{0x52,2}, /* processor graphics control register */
> +{0xa4,4}, /* SNB: graphics base of stolen memory */
> +{0xa8,4}, /* SNB: base of GTT stolen memory */
> };
>
> static void host_pci_config_read(int pos, int len, uint32_t *val, Error
> **errp)
>
Reviewed-by: Thomas Huth
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values
Use definitions from "hw/pci/pci_regs.h".
This also helps when using git-grep.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/pci-host/i440fx.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c
index 0cc80b276d..414138595b 100644
--- a/hw/pci-host/i440fx.c
+++ b/hw/pci-host/i440fx.c
@@ -376,13 +376,13 @@ typedef struct {
/* Here we just expose minimal host bridge offset subset. */
static const IGDHostInfo igd_host_bridge_infos[] = {
-{0x08, 2}, /* revision id */
-{0x2c, 2}, /* sybsystem vendor id */
-{0x2e, 2}, /* sybsystem id */
-{0x50, 2}, /* SNB: processor graphics control register */
-{0x52, 2}, /* processor graphics control register */
-{0xa4, 4}, /* SNB: graphics base of stolen memory */
-{0xa8, 4}, /* SNB: base of GTT stolen memory */
+{PCI_REVISION_ID, 2},
+{PCI_SUBSYSTEM_VENDOR_ID, 2},
+{PCI_SUBSYSTEM_ID,2},
+{0x50,2}, /* SNB: processor graphics control register
*/
+{0x52,2}, /* processor graphics control register */
+{0xa4,4}, /* SNB: graphics base of stolen memory */
+{0xa8,4}, /* SNB: base of GTT stolen memory */
};
static void host_pci_config_read(int pos, int len, uint32_t *val, Error **errp)
--
2.21.0
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
