Re: [Xen-devel] [PATCH v2 07/22] golang/xenlight: define Mac builtin type

2019-12-04 Thread George Dunlap
On 11/15/19 7:44 PM, Nick Rosbrook wrote:
> From: Nick Rosbrook 
> 
> Define Mac as [6]byte and implement fromC, toC, and String functions.
> 
> Signed-off-by: Nick Rosbrook 

Reviewed-by: George Dunlap 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v2 07/22] golang/xenlight: define Mac builtin type

2019-11-15 Thread Nick Rosbrook
From: Nick Rosbrook 

Define Mac as [6]byte and implement fromC, toC, and String functions.

Signed-off-by: Nick Rosbrook 
---
Changes in v2:
- Fix the format string in String function to use %02x.
- Use a value reciever for the toC function.

 tools/golang/xenlight/xenlight.go | 35 +++
 1 file changed, 35 insertions(+)

diff --git a/tools/golang/xenlight/xenlight.go 
b/tools/golang/xenlight/xenlight.go
index 72afc3cf14..eb0d309543 100644
--- a/tools/golang/xenlight/xenlight.go
+++ b/tools/golang/xenlight/xenlight.go
@@ -181,6 +181,41 @@ func (d *Defbool) toC() (C.libxl_defbool, error) {
return c, nil
 }
 
+// Mac represents a libxl_mac, or simply a MAC address.
+type Mac [6]byte
+
+// String formats a Mac address to string representation.
+func (mac Mac) String() string {
+   s := "%02x:%02x:%02x:%02x:%02x:%02x"
+   opts := make([]interface{}, 6)
+
+   for i, v := range mac {
+   opts[i] = v
+   }
+
+   return fmt.Sprintf(s, opts...)
+}
+
+func (mac *Mac) fromC(cmac *C.libxl_mac) error {
+   b := (*[6]C.uint8_t)(unsafe.Pointer(cmac))
+
+   for i, v := range b {
+   mac[i] = byte(v)
+   }
+
+   return nil
+}
+
+func (mac Mac) toC() (C.libxl_mac, error) {
+   var cmac C.libxl_mac
+
+   for i, v := range mac {
+   cmac[i] = C.uint8_t(v)
+   }
+
+   return cmac, nil
+}
+
 type Context struct {
ctx*C.libxl_ctx
logger *C.xentoollog_logger_stdiostream
-- 
2.19.1


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel