Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On 06/13/2018 09:40 AM, Juergen Gross wrote:
On 13/06/18 08:13, Oleksandr Andrushchenko wrote:
On 06/13/2018 09:11 AM, Dmitry Torokhov wrote:
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
wrote:
On 06/13/2018 02:40 AM, Dmitry Torokhov wrote:
On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote:
On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
This is the sync up with the canonical definitions of the input,
sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to
individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device
needs
to be created
- set feature-disable-pointer to 1 if no pointer device needs
to be created
3. Move multi-touch device parameters to backend nodes: these are
described as a part of frontend's XenBus configuration nodes
while they belong to backend's configuration. Fix this by
moving
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with
display and input protocols.
Signed-off-by: Oleksandr Andrushchenko
Cc: Konrad Rzeszutek Wilk
Reviewed-by: Juergen Gross
I'm fine with this patch being added via the input tree with the
other
patches. In case I should take it via the Xen tree, please send me a
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
would want to merge them into your tree without waiting for them to
appear in mainline:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
ib/4.17-xen-kbdfront-runtime-config
Thanks.
Thank you,
I would prefer the fastest path of course
It will be part of 4.19 pull request; the immutable branch is for
Juergen if he does not want to wait till 4.19 merge window to get the
changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which
I assume will be faster?
As Dmitry has it already queued in the input tree I think this is fine.
I trust him to take the right decision for which kernel version those
patches are to be queued. They belong to the input tree after all.
Of course, no doubt here
Juergen
Thank you,
Oleksandr
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On 06/13/2018 09:25 AM, Dmitry Torokhov wrote:
On June 12, 2018 11:13:40 PM PDT, Oleksandr Andrushchenko
wrote:
On 06/13/2018 09:11 AM, Dmitry Torokhov wrote:
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
wrote:
On 06/13/2018 02:40 AM, Dmitry Torokhov wrote:
On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote:
On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
This is the sync up with the canonical definitions of the input,
sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to
individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device
needs
to be created
- set feature-disable-pointer to 1 if no pointer device
needs
to be created
3. Move multi-touch device parameters to backend nodes: these are
described as a part of frontend's XenBus configuration
nodes
while they belong to backend's configuration. Fix this by
moving
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align
with
display and input protocols.
Signed-off-by: Oleksandr Andrushchenko
Cc: Konrad Rzeszutek Wilk
Reviewed-by: Juergen Gross
I'm fine with this patch being added via the input tree with the
other
patches. In case I should take it via the Xen tree, please send me
a
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in
case
you
would want to merge them into your tree without waiting for them to
appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
ib/4.17-xen-kbdfront-runtime-config
Thanks.
Thank you,
I would prefer the fastest path of course
It will be part of 4.19 pull request; the immutable branch is for
Juergen if he does not want to wait till 4.19 merge window to get the
changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which
I assume will be faster?
We are in the tail end of 4.18 merge window so it should not make it in 4.18 no
matter what tree the patches will go through.
Hm, but these are updates and fixes (besides the last patch which adds
some more
functionality), so I thought this is still good to go in 4.18?
Thanks.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On June 12, 2018 11:13:40 PM PDT, Oleksandr Andrushchenko
wrote:
>On 06/13/2018 09:11 AM, Dmitry Torokhov wrote:
>> On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
> wrote:
>>> On 06/13/2018 02:40 AM, Dmitry Torokhov wrote:
On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote:
> On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko
>>
>> This is the sync up with the canonical definitions of the input,
>> sound and display protocols in Xen.
>>
>> Changes to kbdif:
>> 1. Add missing string constants for {feature|request}-raw-pointer
>> to align with the rest of the interface file.
>>
>> 2. Add new XenStore feature fields, so it is possible to
>>> individually
>> control set of exposed virtual devices for each guest OS:
>>- set feature-disable-keyboard to 1 if no keyboard device
>>> needs
>> to be created
>>- set feature-disable-pointer to 1 if no pointer device
>needs
>> to be created
>>
>> 3. Move multi-touch device parameters to backend nodes: these are
>> described as a part of frontend's XenBus configuration
>nodes
>> while they belong to backend's configuration. Fix this by
>>> moving
>> the parameters to the proper section.
>>
>> Unique-id field:
>> 1. Add unique-id XenBus entry for virtual input and display.
>>
>> 2. Change type of unique-id field to string for sndif to align
>with
>> display and input protocols.
>>
>> Signed-off-by: Oleksandr Andrushchenko
>>>
>> Cc: Konrad Rzeszutek Wilk
> Reviewed-by: Juergen Gross
>
> I'm fine with this patch being added via the input tree with the
>>> other
> patches. In case I should take it via the Xen tree, please send me
>a
> note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in
>case
>>> you
would want to merge them into your tree without waiting for them to
appear in mainline:
git pull
>git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
>>> ib/4.17-xen-kbdfront-runtime-config
Thanks.
>>> Thank you,
>>> I would prefer the fastest path of course
>> It will be part of 4.19 pull request; the immutable branch is for
>Juergen if he does not want to wait till 4.19 merge window to get the
>changes.
>Ah, I see. Juergen, can we please merge this via Xen tree then which
>I assume will be faster?
We are in the tail end of 4.18 merge window so it should not make it in 4.18 no
matter what tree the patches will go through.
Thanks.
--
Dmitry
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On 06/13/2018 09:11 AM, Dmitry Torokhov wrote:
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
wrote:
On 06/13/2018 02:40 AM, Dmitry Torokhov wrote:
On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote:
On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
This is the sync up with the canonical definitions of the input,
sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to
individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device
needs
to be created
- set feature-disable-pointer to 1 if no pointer device needs
to be created
3. Move multi-touch device parameters to backend nodes: these are
described as a part of frontend's XenBus configuration nodes
while they belong to backend's configuration. Fix this by
moving
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with
display and input protocols.
Signed-off-by: Oleksandr Andrushchenko
Cc: Konrad Rzeszutek Wilk
Reviewed-by: Juergen Gross
I'm fine with this patch being added via the input tree with the
other
patches. In case I should take it via the Xen tree, please send me a
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
would want to merge them into your tree without waiting for them to
appear in mainline:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
ib/4.17-xen-kbdfront-runtime-config
Thanks.
Thank you,
I would prefer the fastest path of course
It will be part of 4.19 pull request; the immutable branch is for Juergen if he
does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which
I assume will be faster?
Thanks.
Thank you,
Oleksandr
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
wrote:
>On 06/13/2018 02:40 AM, Dmitry Torokhov wrote:
>> On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote:
>>> On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
This is the sync up with the canonical definitions of the input,
sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to
>individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device
>needs
to be created
- set feature-disable-pointer to 1 if no pointer device needs
to be created
3. Move multi-touch device parameters to backend nodes: these are
described as a part of frontend's XenBus configuration nodes
while they belong to backend's configuration. Fix this by
>moving
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with
display and input protocols.
Signed-off-by: Oleksandr Andrushchenko
>
Cc: Konrad Rzeszutek Wilk
>>> Reviewed-by: Juergen Gross
>>>
>>> I'm fine with this patch being added via the input tree with the
>other
>>> patches. In case I should take it via the Xen tree, please send me a
>>> note.
>> Juergen,
>>
>> I created an immutable branch off v4.17 with these 3 patches in case
>you
>> would want to merge them into your tree without waiting for them to
>> appear in mainline:
>>
>> git pull git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
>ib/4.17-xen-kbdfront-runtime-config
>>
>> Thanks.
>>
>Thank you,
>I would prefer the fastest path of course
It will be part of 4.19 pull request; the immutable branch is for Juergen if he
does not want to wait till 4.19 merge window to get the changes.
Thanks.
--
Dmitry
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On 06/13/2018 02:40 AM, Dmitry Torokhov wrote:
On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote:
On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
This is the sync up with the canonical definitions of the input,
sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs
to be created
- set feature-disable-pointer to 1 if no pointer device needs
to be created
3. Move multi-touch device parameters to backend nodes: these are
described as a part of frontend's XenBus configuration nodes
while they belong to backend's configuration. Fix this by moving
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with
display and input protocols.
Signed-off-by: Oleksandr Andrushchenko
Cc: Konrad Rzeszutek Wilk
Reviewed-by: Juergen Gross
I'm fine with this patch being added via the input tree with the other
patches. In case I should take it via the Xen tree, please send me a
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case you
would want to merge them into your tree without waiting for them to
appear in mainline:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
ib/4.17-xen-kbdfront-runtime-config
Thanks.
Thank you,
I would prefer the fastest path of course
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote:
> On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko
> >
> > This is the sync up with the canonical definitions of the input,
> > sound and display protocols in Xen.
> >
> > Changes to kbdif:
> > 1. Add missing string constants for {feature|request}-raw-pointer
> >to align with the rest of the interface file.
> >
> > 2. Add new XenStore feature fields, so it is possible to individually
> >control set of exposed virtual devices for each guest OS:
> > - set feature-disable-keyboard to 1 if no keyboard device needs
> >to be created
> > - set feature-disable-pointer to 1 if no pointer device needs
> >to be created
> >
> > 3. Move multi-touch device parameters to backend nodes: these are
> > described as a part of frontend's XenBus configuration nodes
> > while they belong to backend's configuration. Fix this by moving
> > the parameters to the proper section.
> >
> > Unique-id field:
> > 1. Add unique-id XenBus entry for virtual input and display.
> >
> > 2. Change type of unique-id field to string for sndif to align with
> > display and input protocols.
> >
> > Signed-off-by: Oleksandr Andrushchenko
> > Cc: Konrad Rzeszutek Wilk
>
> Reviewed-by: Juergen Gross
>
> I'm fine with this patch being added via the input tree with the other
> patches. In case I should take it via the Xen tree, please send me a
> note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case you
would want to merge them into your tree without waiting for them to
appear in mainline:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
ib/4.17-xen-kbdfront-runtime-config
Thanks.
--
Dmitry
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On 06/12/2018 04:46 PM, Juergen Gross wrote:
On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
This is the sync up with the canonical definitions of the input,
sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs
to be created
- set feature-disable-pointer to 1 if no pointer device needs
to be created
3. Move multi-touch device parameters to backend nodes: these are
described as a part of frontend's XenBus configuration nodes
while they belong to backend's configuration. Fix this by moving
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with
display and input protocols.
Signed-off-by: Oleksandr Andrushchenko
Cc: Konrad Rzeszutek Wilk
Reviewed-by: Juergen Gross
I'm fine with this patch being added via the input tree with the other
patches. In case I should take it via the Xen tree, please send me a
note.
Thank you
Juergen
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
On 12/06/18 09:48, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko
>
> This is the sync up with the canonical definitions of the input,
> sound and display protocols in Xen.
>
> Changes to kbdif:
> 1. Add missing string constants for {feature|request}-raw-pointer
>to align with the rest of the interface file.
>
> 2. Add new XenStore feature fields, so it is possible to individually
>control set of exposed virtual devices for each guest OS:
> - set feature-disable-keyboard to 1 if no keyboard device needs
>to be created
> - set feature-disable-pointer to 1 if no pointer device needs
>to be created
>
> 3. Move multi-touch device parameters to backend nodes: these are
> described as a part of frontend's XenBus configuration nodes
> while they belong to backend's configuration. Fix this by moving
> the parameters to the proper section.
>
> Unique-id field:
> 1. Add unique-id XenBus entry for virtual input and display.
>
> 2. Change type of unique-id field to string for sndif to align with
> display and input protocols.
>
> Signed-off-by: Oleksandr Andrushchenko
> Cc: Konrad Rzeszutek Wilk
Reviewed-by: Juergen Gross
I'm fine with this patch being added via the input tree with the other
patches. In case I should take it via the Xen tree, please send me a
note.
Juergen
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
From: Oleksandr Andrushchenko
This is the sync up with the canonical definitions of the input,
sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs
to be created
- set feature-disable-pointer to 1 if no pointer device needs
to be created
3. Move multi-touch device parameters to backend nodes: these are
described as a part of frontend's XenBus configuration nodes
while they belong to backend's configuration. Fix this by moving
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with
display and input protocols.
Signed-off-by: Oleksandr Andrushchenko
Cc: Konrad Rzeszutek Wilk
---
include/xen/interface/io/displif.h | 8 +++
include/xen/interface/io/kbdif.h | 78 ++
include/xen/interface/io/sndif.h | 10 ++--
3 files changed, 71 insertions(+), 25 deletions(-)
diff --git a/include/xen/interface/io/displif.h
b/include/xen/interface/io/displif.h
index 596578d9be3e..fdc279dc4a88 100644
--- a/include/xen/interface/io/displif.h
+++ b/include/xen/interface/io/displif.h
@@ -189,6 +189,13 @@
*
*- Connector settings
*
+ * unique-id
+ * Values:
+ *
+ * After device instance initialization each connector is assigned a
+ * unique ID, so it can be identified by the backend by this ID.
+ * This can be UUID or such.
+ *
* resolution
* Values: x
*
@@ -368,6 +375,7 @@
#define XENDISPL_FIELD_EVT_CHANNEL "evt-event-channel"
#define XENDISPL_FIELD_RESOLUTION "resolution"
#define XENDISPL_FIELD_BE_ALLOC"be-alloc"
+#define XENDISPL_FIELD_UNIQUE_ID "unique-id"
/*
**
diff --git a/include/xen/interface/io/kbdif.h b/include/xen/interface/io/kbdif.h
index 2a9510ade701..b4439cf48220 100644
--- a/include/xen/interface/io/kbdif.h
+++ b/include/xen/interface/io/kbdif.h
@@ -51,6 +51,18 @@
* corresponding entries in XenStore and puts 1 as the value of the entry.
* If a feature is not supported then 0 must be set or feature entry omitted.
*
+ * feature-disable-keyboard
+ * Values:
+ *
+ * If there is no need to expose a virtual keyboard device by the
+ * frontend then this must be set to 1.
+ *
+ * feature-disable-pointer
+ * Values:
+ *
+ * If there is no need to expose a virtual pointer device by the
+ * frontend then this must be set to 1.
+ *
* feature-abs-pointer
* Values:
*
@@ -63,6 +75,22 @@
* Backends, which support reporting of multi-touch events
* should set this to 1.
*
+ * feature-raw-pointer
+ * Values:
+ *
+ * Backends, which support reporting raw (unscaled) absolute coordinates
+ * for pointer devices should set this to 1. Raw (unscaled) values have
+ * a range of [0, 0x7fff].
+ *
+ *--- Device Instance Parameters
+ *
+ * unique-id
+ * Values:
+ *
+ * After device instance initialization it is assigned a unique ID,
+ * so every instance of the frontend can be identified by the backend
+ * by this ID. This can be UUID or such.
+ *
*- Pointer Device Parameters
*
* width
@@ -77,6 +105,25 @@
* Maximum Y coordinate (height) to be used by the frontend
* while reporting input events, pixels, [0; UINT32_MAX].
*
+ *--- Multi-touch Device Parameters --
+ *
+ * multi-touch-num-contacts
+ * Values:
+ *
+ * Number of simultaneous touches reported.
+ *
+ * multi-touch-width
+ * Values:
+ *
+ * Width of the touch area to be used by the frontend
+ * while reporting input events, pixels, [0; UINT32_MAX].
+ *
+ * multi-touch-height
+ * Values:
+ *
+ * Height of the touch area to be used by the frontend
+ * while reporting input events, pixels, [0; UINT32_MAX].
+ *
*
*Frontend XenBus Nodes
*
@@ -98,6 +145,13 @@
*
* Request backend to report multi-touch events.
*
+ * request-raw-pointer
+ * Values:
+ *
+ * Request backend to report raw unscaled absolute pointer coordinates.
+ * This option is only valid if request-abs-pointer is also
