Re: [Xen-devel] clean up physical merging helpers
On 9/25/18 2:30 PM, Christoph Hellwig wrote: > Hi Jens, > > this series moves Xen special handling of block merges from arch hooks > into common code. A previous version has been reviewed by Boris. Applied, thanks. -- Jens Axboe ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] clean up physical merging helpers
Hi Jens, this series moves Xen special handling of block merges from arch hooks into common code. A previous version has been reviewed by Boris. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] clean up physical merging helpers
On Mon, Sep 24, 2018 at 10:25:45AM -0400, Boris Ostrovsky wrote: > Konrad is out this (and last) week, this looks good to me. Including > patch 13, although it's hard to say whether it may break some builds. I fixed up everything the buildbot reported (which was quite a bit as you can see in the patch), and the buildbot has been quiet for weeks now, so I think we should be fine. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] clean up physical merging helpers
On 9/20/18 10:39 AM, Jens Axboe wrote: > On 9/20/18 12:29 AM, Christoph Hellwig wrote: >> On Sat, Sep 15, 2018 at 08:47:13AM -0600, Jens Axboe wrote: > this series moves various helpers related to merging based on physical > addresses from the public headers into block/, moves the Xen special > case from arch hooks into common code, cleans up the code a bit, and > removes not nessecary includes from the block headers. ---end quoted text--- >>> It's a good cleanup, I like it. Would prefer if the arm/xen folks could >>> ack the first bits, >> Konread, can you look at the series (or delegate). Konrad is out this (and last) week, this looks good to me. Including patch 13, although it's hard to say whether it may break some builds. -boris >> >>> and 13/13 should probably just to in differently. >> I can't parse this setence. > The irony is thick :-) > > Anyway, s/to/go for that sentence. I don't mind carrying it if Konrad > is happy with it, but it could go in separately after this series is > merged. > ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] clean up physical merging helpers
On 9/20/18 12:29 AM, Christoph Hellwig wrote: > On Sat, Sep 15, 2018 at 08:47:13AM -0600, Jens Axboe wrote: this series moves various helpers related to merging based on physical addresses from the public headers into block/, moves the Xen special case from arch hooks into common code, cleans up the code a bit, and removes not nessecary includes from the block headers. >>> ---end quoted text--- >>> >> >> It's a good cleanup, I like it. Would prefer if the arm/xen folks could >> ack the first bits, > > Konread, can you look at the series (or delegate). > >> and 13/13 should probably just to in differently. > > I can't parse this setence. The irony is thick :-) Anyway, s/to/go for that sentence. I don't mind carrying it if Konrad is happy with it, but it could go in separately after this series is merged. -- Jens Axboe ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] clean up physical merging helpers
On Thu, Sep 20, 2018 at 08:29:46AM +0200, Christoph Hellwig wrote: > Konread, can you look at the series (or delegate). and next time I'll spell your name correctly, sorry :) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] clean up physical merging helpers
On Sat, Sep 15, 2018 at 08:47:13AM -0600, Jens Axboe wrote: > >> this series moves various helpers related to merging based on physical > >> addresses from the public headers into block/, moves the Xen special > >> case from arch hooks into common code, cleans up the code a bit, and > >> removes not nessecary includes from the block headers. > > ---end quoted text--- > > > > It's a good cleanup, I like it. Would prefer if the arm/xen folks could > ack the first bits, Konread, can you look at the series (or delegate). > and 13/13 should probably just to in differently. I can't parse this setence. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] clean up physical merging helpers
On 9/15/18 1:03 AM, Christoph Hellwig wrote: > Jens, any comments? > > On Tue, Sep 04, 2018 at 12:14:18PM -0700, Christoph Hellwig wrote: >> Hi Jens, >> >> this series moves various helpers related to merging based on physical >> addresses from the public headers into block/, moves the Xen special >> case from arch hooks into common code, cleans up the code a bit, and >> removes not nessecary includes from the block headers. > ---end quoted text--- > It's a good cleanup, I like it. Would prefer if the arm/xen folks could ack the first bits, and 13/13 should probably just to in differently. -- Jens Axboe ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] clean up physical merging helpers
Jens, any comments? On Tue, Sep 04, 2018 at 12:14:18PM -0700, Christoph Hellwig wrote: > Hi Jens, > > this series moves various helpers related to merging based on physical > addresses from the public headers into block/, moves the Xen special > case from arch hooks into common code, cleans up the code a bit, and > removes not nessecary includes from the block headers. ---end quoted text--- ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] clean up physical merging helpers
Hi Jens, this series moves various helpers related to merging based on physical addresses from the public headers into block/, moves the Xen special case from arch hooks into common code, cleans up the code a bit, and removes not nessecary includes from the block headers. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
