[xen-unstable bisection] complete test-xtf-amd64-amd64-4
branch xen-unstable xenbranch xen-unstable job test-xtf-amd64-amd64-4 testid xen-boot Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: e9c72d524fbdb109c45f24acce998f0bd552fb6f Bug not present: eac84d9d579011f311d502317b74dc56e788463d Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175175/ commit e9c72d524fbdb109c45f24acce998f0bd552fb6f Author: Wei Chen Date: Mon Dec 12 12:13:26 2022 +0100 xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This results in two lines of error-checking code in phys_to_nid that is not actually working and causing two compilation errors: 1. error: "MAX_NUMNODES" undeclared (first use in this function). This is because in the common header file, "MAX_NUMNODES" is defined after the common header file includes the ARCH header file, where phys_to_nid has attempted to use "MAX_NUMNODES". This error was resolved after we moved the phys_to_nid from x86 ARCH header file to common header file. 2. error: wrong type argument to unary exclamation mark. This is because, the error-checking code contains !node_data[nid]. But node_data is a data structure variable, it's not a pointer. So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to enable the two lines of error-checking code. And fix the left compilation errors by replacing !node_data[nid] to !node_data[nid].node_spanned_pages. Although NUMA allows one node can only have CPUs but without any memory. And node with 0 bytes of memory might have an entry in memnodemap[] theoretically. But that doesn't mean phys_to_nid can find any valid address from a node with 0 bytes memory. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Acked-by: Jan Beulich For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xen-boot.html Revision IDs in each graph node refer, respectively, to the Trees above. Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xen-boot --summary-out=tmp/175175.bisection-summary --basis-template=175148 --blessings=real,real-bisect,real-retry xen-unstable test-xtf-amd64-amd64-4 xen-boot Searching for failure / basis pass: 175154 fail [host=himrod0] / 175148 [host=italia1] 175144 [host=debina1] 175141 [host=pinot1] 175135 [host=godello0] 175126 [host=nocera1] 175104 [host=pinot0] 175091 [host=godello1] 175083 [host=sabro0] 175071 [host=huxelrebe0] 175066 [host=elbling0] 175062 ok. Failure / basis pass flights: 175154 / 175062 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 96993519424c3fef49fd00d80a271d986767a3cd 5e770502e81e6bde08f55db6b0f66fbc1013850d Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 a6da84524ceaf24ff997d03407b93f60c12857f3 5e770502e81e6bde08f55db6b0f66fbc1013850d Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7\ a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#a6da84524ceaf24ff997d03407b93f60c12857f3-96993519424c3fef49fd00d80a271d986767a3cd git://xenbits.xen.org/xtf.git#5e770502e81e6bde08f55db6b0f66fbc1013850d-5e770502e81e6bde08f55db6b0f66fbc1013850d Loaded 5001 nodes in revision graph Searching for test results: 175062 pass c3038e718a19fc596f7b1baba0f83d5
Re: [xen-unstable bisection] complete test-xtf-amd64-amd64-4
Ian, On 11.06.2021 04:21, osstest service owner wrote: > branch xen-unstable > xenbranch xen-unstable > job test-xtf-amd64-amd64-4 > testid xtf/test-pv32pae-selftest > > Tree: linux git://xenbits.xen.org/linux-pvops.git > Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git > Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git > Tree: qemuu git://xenbits.xen.org/qemu-xen.git > Tree: xen git://xenbits.xen.org/xen.git > Tree: xtf git://xenbits.xen.org/xtf.git > > *** Found and reproduced problem changeset *** > > Bug is in tree: xen git://xenbits.xen.org/xen.git > Bug introduced: 1a0f2fe2297d122a08fee2b26de5de995fdeca13 > Bug not present: 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/162627/ > > > commit 1a0f2fe2297d122a08fee2b26de5de995fdeca13 > Author: George Dunlap > Date: Thu May 6 13:38:02 2021 +0100 > > SUPPORT.md: Un-shimmed 32-bit PV guests are no longer supported > > The support status of 32-bit guests doesn't seem particularly useful. > > With it changed to fully unsupported outside of PV-shim, adjust the PV32 > Kconfig default accordingly. > > Reported-by: Jann Horn > Signed-off-by: George Dunlap > Signed-off-by: Jan Beulich as indicated upfront, and as now also confirmed by the large amount of failures in the two most recent full unstable flights, our defaulting to off of PV32 for non-shim Xen builds means in osstest PV32 needs to be turned on again, or all the 32-bit PV Dom0 / DomU tests (and xtf equivalents) would need to be disabled. This will eventually be needed on all branches which we would backport this change to (I expect this would be at least all fully maintained ones), and which have a PV32 setting (exists only as of 4.14). As I don't expect disabling any tests is a reasonable course of action, I think it's going to need to be the .config override. Could you please arrange for this? Jan
[xen-unstable bisection] complete test-xtf-amd64-amd64-4
branch xen-unstable xenbranch xen-unstable job test-xtf-amd64-amd64-4 testid xtf/test-pv32pae-selftest Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 1a0f2fe2297d122a08fee2b26de5de995fdeca13 Bug not present: 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/162627/ commit 1a0f2fe2297d122a08fee2b26de5de995fdeca13 Author: George Dunlap Date: Thu May 6 13:38:02 2021 +0100 SUPPORT.md: Un-shimmed 32-bit PV guests are no longer supported The support status of 32-bit guests doesn't seem particularly useful. With it changed to fully unsupported outside of PV-shim, adjust the PV32 Kconfig default accordingly. Reported-by: Jann Horn Signed-off-by: George Dunlap Signed-off-by: Jan Beulich For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-pv32pae-selftest.html Revision IDs in each graph node refer, respectively, to the Trees above. Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-pv32pae-selftest --summary-out=tmp/162627.bisection-summary --basis-template=162533 --blessings=real,real-bisect,real-retry xen-unstable test-xtf-amd64-amd64-4 xtf/test-pv32pae-selftest Searching for failure / basis pass: 162556 fail [host=huxelrebe0] / 162533 [host=fiano1] 162475 [host=godello0] 162422 [host=huxelrebe1] 162385 [host=godello1] 162343 [host=albana0] 162337 [host=chardonnay0] 162330 [host=godello1] 162325 [host=albana1] 162282 [host=elbling0] 162276 ok. Failure / basis pass flights: 162556 / 162276 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 e4fee66043120c954fc309bbb37813604c1c0eb7 5ead491e36af6cb8681fc1278bd36c756ad62ac2 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 57f68dfd2d111a2ad381df740543c901b41f2299 5ead491e36af6cb8681fc1278bd36c756ad62ac2 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#7ea428895af2840d85c524f0bd11a38\ aac308308-7ea428895af2840d85c524f0bd11a38aac308308 git://xenbits.xen.org/xen.git#57f68dfd2d111a2ad381df740543c901b41f2299-e4fee66043120c954fc309bbb37813604c1c0eb7 git://xenbits.xen.org/xtf.git#5ead491e36af6cb8681fc1278bd36c756ad62ac2-5ead491e36af6cb8681fc1278bd36c756ad62ac2 Loaded 5001 nodes in revision graph Searching for test results: 162276 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 57f68dfd2d111a2ad381df740543c901b41f2299 5ead491e36af6cb8681fc1278bd36c756ad62ac2 162282 [host=elbling0] 162325 [host=albana1] 162330 [host=godello1] 162337 [host=chardonnay0] 162343 [host=albana0] 162385 [host=godello1] 162422 [host=huxelrebe1] 162475 [host=godello0] 162533 [host=fiano1] 162556 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 e4fee66043120c954fc309bbb37813604c1c0eb7 5ead491e36af6cb8681fc1278bd36c756ad62ac2 162601 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 57f68dfd2d111a2ad381df740543c901b41f2299 5ead491e36af6cb8681fc1278bd36c756ad62ac2 162617 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273d
[xen-unstable bisection] complete test-xtf-amd64-amd64-4
branch xen-unstable xenbranch xen-unstable job test-xtf-amd64-amd64-4 testid xtf/test-pv32pae-selftest Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 4dc1815991420b809ce18dddfdf9c0af48944204 Bug not present: 2d824791504f4119f04f95bafffec2e37d319c25 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/159687/ commit 4dc1815991420b809ce18dddfdf9c0af48944204 Author: Jan Beulich Date: Fri Feb 19 17:19:56 2021 +0100 x86/PV: harden guest memory accesses against speculative abuse Inspired by https://lore.kernel.org/lkml/f12e7d3cecf41b2c29734ea45a393be21d4a8058.1597848273.git.jpoim...@redhat.com/ and prior work in that area of x86 Linux, suppress speculation with guest specified pointer values by suitably masking the addresses to non-canonical space in case they fall into Xen's virtual address range. Introduce a new Kconfig control. Note that it is necessary in such code to avoid using "m" kind operands: If we didn't, there would be no guarantee that the register passed to guest_access_mask_ptr is also the (base) one used for the memory access. As a minor unrelated change in get_unsafe_asm() the unnecessary "itype" parameter gets dropped and the XOR on the fixup path gets changed to be a 32-bit one in all cases: This way we avoid pointless REX.W or operand size overrides, or writes to partial registers. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-Acked-by: Ian Jackson For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-pv32pae-selftest.html Revision IDs in each graph node refer, respectively, to the Trees above. Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-pv32pae-selftest --summary-out=tmp/159687.bisection-summary --basis-template=159475 --blessings=real,real-bisect,real-retry xen-unstable test-xtf-amd64-amd64-4 xtf/test-pv32pae-selftest Searching for failure / basis pass: 159652 fail [host=godello0] / 159475 ok. Failure / basis pass flights: 159652 / 159475 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 60390ccb8b9b2dbf85010f8b47779bb231aa2533 8ab15139728a8efd3ebbb60beb16a958a6a93fa1 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 e8185c5f01c68f7d29d23a4a91bc1be1ff2cc1ca 8ab15139728a8efd3ebbb60beb16a958a6a93fa1 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#7ea428895af2840d85c524f0bd11a38\ aac308308-7ea428895af2840d85c524f0bd11a38aac308308 git://xenbits.xen.org/xen.git#e8185c5f01c68f7d29d23a4a91bc1be1ff2cc1ca-60390ccb8b9b2dbf85010f8b47779bb231aa2533 git://xenbits.xen.org/xtf.git#8ab15139728a8efd3ebbb60beb16a958a6a93fa1-8ab15139728a8efd3ebbb60beb16a958a6a93fa1 Loaded 5001 nodes in revision graph Searching for test results: 159475 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 e8185c5f01c68f7d29d23a4a91bc1be1ff2cc1ca 8ab15139728a8efd3ebbb60beb16a958a6a93fa1 159487 [host=godello1] 159491 [host=albana0] 159508 [host=albana1] 159526 [host=huxelrebe1] 159540 [host=elbling0] 159559 [host=fiano1] 159576 [host=chardonnay0] 159602 [host=elbling1] 159626 [host=chardonnay1] 159669 [host=chardonnay1] 159652 fail c3038e718a19fc596f
[xen-unstable bisection] complete test-xtf-amd64-amd64-4
branch xen-unstable
xenbranch xen-unstable
job test-xtf-amd64-amd64-4
testid xtf/test-pv64-xsa-221
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Tree: xtf git://xenbits.xen.org/xtf.git
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: 62bcdc4edbf6d8c6e8a25544d48de22ccf75310d
Bug not present: 112992b05b2d2ca63f3c78eefe1cf8d192d7303a
Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/154832/
commit 62bcdc4edbf6d8c6e8a25544d48de22ccf75310d
Author: Jan Beulich
Date: Tue Sep 22 15:50:09 2020 +0200
evtchn/x86: enforce correct upper limit for 32-bit guests
The recording of d->max_evtchns in evtchn_2l_init(), in particular with
the limited set of callers of the function, is insufficient. Neither for
PV nor for HVM guests the bitness is known at domain_create() time, yet
the upper bound in 2-level mode depends upon guest bitness. Recording
too high a limit "allows" x86 32-bit domains to open not properly usable
event channels, management of which (inside Xen) would then result in
corruption of the shared info and vCPU info structures.
Keep the upper limit dynamic for the 2-level case, introducing a helper
function to retrieve the effective limit. This helper is now supposed to
be private to the event channel code. The used in do_poll() and
domain_dump_evtchn_info() weren't consistent with port uses elsewhere
and hence get switched to port_is_valid().
Furthermore FIFO mode's setup_ports() gets adjusted to loop only up to
the prior ABI limit, rather than all the way up to the new one.
Finally a word on the change to do_poll(): Accessing ->max_evtchns
without holding a suitable lock was never safe, as it as well as
->evtchn_port_ops may change behind do_poll()'s back. Using
port_is_valid() instead widens some the window for potential abuse,
until we've dealt with the race altogether (see XSA-343).
This is XSA-342.
Reported-by: Julien Grall
Fixes: 48974e6ce52e ("evtchn: use a per-domain variable for the max
number of event channels")
Signed-off-by: Jan Beulich
Reviewed-by: Stefano Stabellini
Reviewed-by: Julien Grall
For bisection revision-tuple graph see:
http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-pv64-xsa-221.html
Revision IDs in each graph node refer, respectively, to the Trees above.
Running cs-bisection-step
--graph-out=/home/logs/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-pv64-xsa-221
--summary-out=tmp/154987.bisection-summary --basis-template=154611
--blessings=real,real-bisect --flight=154987 xen-unstable
test-xtf-amd64-amd64-4 xtf/test-pv64-xsa-221
Searching for failure / basis pass:
154634 fail [host=albana1] / 154611 [host=huxelrebe1] 154592 [host=godello1]
154576 [host=fiano1] 154556 [host=huxelrebe0] 154521 [host=chardonnay1] 154504
[host=elbling0] 154494 [host=albana0] 154481 [host=chardonnay0] 154465
[host=godello0] 154090 [host=godello0] 154058 [host=pinot1] 154036
[host=godello1] 154016 [host=rimava1] 153983 [host=fiano0] 153957 ok.
Failure / basis pass flights: 154634 / 153957
(tree with no url: minios)
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Tree: xtf git://xenbits.xen.org/xtf.git
Latest c3038e718a19fc596f7b1baba0f83d5146dc7784
c530a75c1e6a472b0eb9558310b518f0dfcd8860
3d273dd05e51e5a1ffba3d98c7437ee84e8f8764
ea6d3cd1ed79d824e605a70c3626bc437c386260
2785b2a9e04abc148e1c5259f4faee708ea356f4
17d372b763cb0b2e2e6b5a637c11f3997d2533fa
Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784
c530a75c1e6a472b0eb9558310b518f0dfcd8860
3d273dd05e51e5a1ffba3d98c7437ee84e8f8764
ea6d3cd1ed79d824e605a70c3626bc437c386260
b11910082d90bb1597f6679524eb726a33306672
17d372b763cb0b2e2e6b5a637c11f3997d2533fa
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784
git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860
git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764
git://xenbits.xen.org/qemu-xen.git#ea6d3cd1ed79d824e605a7
[xen-unstable bisection] complete test-xtf-amd64-amd64-4
branch xen-unstable
xenbranch xen-unstable
job test-xtf-amd64-amd64-4
testid xtf/test-hvm64-xsa-221
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Tree: xtf git://xenbits.xen.org/xtf.git
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: 62bcdc4edbf6d8c6e8a25544d48de22ccf75310d
Bug not present: 112992b05b2d2ca63f3c78eefe1cf8d192d7303a
Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/154832/
commit 62bcdc4edbf6d8c6e8a25544d48de22ccf75310d
Author: Jan Beulich
Date: Tue Sep 22 15:50:09 2020 +0200
evtchn/x86: enforce correct upper limit for 32-bit guests
The recording of d->max_evtchns in evtchn_2l_init(), in particular with
the limited set of callers of the function, is insufficient. Neither for
PV nor for HVM guests the bitness is known at domain_create() time, yet
the upper bound in 2-level mode depends upon guest bitness. Recording
too high a limit "allows" x86 32-bit domains to open not properly usable
event channels, management of which (inside Xen) would then result in
corruption of the shared info and vCPU info structures.
Keep the upper limit dynamic for the 2-level case, introducing a helper
function to retrieve the effective limit. This helper is now supposed to
be private to the event channel code. The used in do_poll() and
domain_dump_evtchn_info() weren't consistent with port uses elsewhere
and hence get switched to port_is_valid().
Furthermore FIFO mode's setup_ports() gets adjusted to loop only up to
the prior ABI limit, rather than all the way up to the new one.
Finally a word on the change to do_poll(): Accessing ->max_evtchns
without holding a suitable lock was never safe, as it as well as
->evtchn_port_ops may change behind do_poll()'s back. Using
port_is_valid() instead widens some the window for potential abuse,
until we've dealt with the race altogether (see XSA-343).
This is XSA-342.
Reported-by: Julien Grall
Fixes: 48974e6ce52e ("evtchn: use a per-domain variable for the max
number of event channels")
Signed-off-by: Jan Beulich
Reviewed-by: Stefano Stabellini
Reviewed-by: Julien Grall
For bisection revision-tuple graph see:
http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-hvm64-xsa-221.html
Revision IDs in each graph node refer, respectively, to the Trees above.
Running cs-bisection-step
--graph-out=/home/logs/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf--test-hvm64-xsa-221
--summary-out=tmp/154832.bisection-summary --basis-template=154611
--blessings=real,real-bisect xen-unstable test-xtf-amd64-amd64-4
xtf/test-hvm64-xsa-221
Searching for failure / basis pass:
154634 fail [host=albana1] / 154611 [host=huxelrebe1] 154592 [host=godello1]
154576 [host=fiano1] 154556 [host=huxelrebe0] 154521 [host=chardonnay1] 154504
[host=elbling0] 154494 [host=albana0] 154481 [host=chardonnay0] 154465
[host=godello0] 154090 [host=godello0] 154058 [host=pinot1] 154036
[host=godello1] 154016 [host=rimava1] 153983 [host=fiano0] 153957 ok.
Failure / basis pass flights: 154634 / 153957
(tree with no url: minios)
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Tree: xtf git://xenbits.xen.org/xtf.git
Latest c3038e718a19fc596f7b1baba0f83d5146dc7784
c530a75c1e6a472b0eb9558310b518f0dfcd8860
3d273dd05e51e5a1ffba3d98c7437ee84e8f8764
ea6d3cd1ed79d824e605a70c3626bc437c386260
2785b2a9e04abc148e1c5259f4faee708ea356f4
17d372b763cb0b2e2e6b5a637c11f3997d2533fa
Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784
c530a75c1e6a472b0eb9558310b518f0dfcd8860
3d273dd05e51e5a1ffba3d98c7437ee84e8f8764
ea6d3cd1ed79d824e605a70c3626bc437c386260
b11910082d90bb1597f6679524eb726a33306672
17d372b763cb0b2e2e6b5a637c11f3997d2533fa
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784
git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860
git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764
git://xenbits.xen.org/qemu-xen.git#ea6d3cd1ed79d824e605a70c3626bc4\
[Xen-devel] [xen-unstable bisection] complete test-xtf-amd64-amd64-4
branch xen-unstable xenbranch xen-unstable job test-xtf-amd64-amd64-4 testid xtf-fep Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: e9be34be5f9a1a6ecbf05ba9502cd705ae441476 Bug not present: 5e04bf333b954fcfd86eda3d258dc69bcf0586a3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/128703/ commit e9be34be5f9a1a6ecbf05ba9502cd705ae441476 Author: Roger Pau Monné Date: Tue Oct 9 16:27:13 2018 +0200 x86/vtd: fix iommu_share_p2m_table Commit 2916951c1 "mm / iommu: include need_iommu() test in iommu_use_hap_pt()" changed the check in iommu_share_p2m_table to use need_iommu(d) (as part of iommu_use_hap_pt) instead of iommu_enabled, which broke the check because at the point in domain construction where iommu_share_p2m_table is called need_iommu(d) will always return false. Fix this by reverting to the previous logic. While there turn the hap_enabled check into an ASSERT, since the only caller of iommu_share_p2m_table already performs the hap_enabled check before calling the function. Signed-off-by: Roger Pau Monné Reviewed-by: Paul Durrant Reviewed-by: Jan Beulich For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf-fep.html Revision IDs in each graph node refer, respectively, to the Trees above. Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-xtf-amd64-amd64-4.xtf-fep --summary-out=tmp/128703.bisection-summary --basis-template=128523 --blessings=real,real-bisect xen-unstable test-xtf-amd64-amd64-4 xtf-fep Searching for failure / basis pass: 128614 fail [host=elbling0] / 128523 [host=godello1] 128498 [host=huxelrebe0] 128478 [host=fiano0] 128464 [host=elbling1] 128445 [host=albana1] 128414 [host=albana0] 128354 [host=debina0] 128333 [host=pinot1] 128314 [host=chardonnay0] 128281 [host=joubertin0] 128267 [host=huxelrebe1] 128240 [host=rimava1] 128175 [host=italia0] 128118 [host=godello0] 128084 ok. Failure / basis pass flights: 128614 / 128084 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Tree: xtf git://xenbits.xen.org/xtf.git Latest e6abbe80c8838e9c0bdb51835e6218008fa49386 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 162fc8295f31240dc3670190a91e9bbc03b0d7be 089f9be25f4bb445f68241ba05ab4e17786e21a7 Basis pass 1244bbb3e92135d247e2dddfa6fe5e3e171a9635 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec 089f9be25f4bb445f68241ba05ab4e17786e21a7 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#1244bbb3e92135d247e2dddfa6fe5e3e171a9635-e6abbe80c8838e9c0bdb51835e6218008fa49386 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149-9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 git://xenbits.xen.org/qemu-xen.git#de5b678ca4dcdfa83e322491d478d66df56c1986-de5b678ca4dcdfa83e322491d478d66df56c1986 git://xenbits.xen.org/xen.git#940185b2f6f343251c2b83bd96e599398cea51ec-162fc8295f31240dc3670190a91e9bbc03b0d7be git://xenbits.xen.org/xtf.git#089f9be25f4bb445f68241ba05ab4e17786e21a7-089f9be25f4bb445f68241ba05ab4e17786e21a7 Loaded 2001 nodes in revision graph Searching for test results: 127956 [host=elbling1] 127966 [host=fiano0] 127997 [host=godello1] 128084 pass 1244bbb3e92135d247e2dddfa6fe5e3e171a9635 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec 089f9be25f4bb445f68241ba05ab4e17786e21a7 128033 [host=baroque0] 128118 [host=godello0] 128175 [host=italia0] 128240 [host=rimava1] 128267 [host=huxelrebe1] 128281 [host=joubertin0] 128314 [host=chardonnay0] 128333 [host=pinot1] 128354 [host=debina0] 128414 [host=albana0] 128445 [host=albana1] 128523 [host=godello1] 128478 [host=fiano0] 128464 [host=elbling1] 1284
