Re: [xen-unstable test] 164237: regressions - FAIL
Juergen Gross writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Does this mean we should de-support pvgrub? Or even remove it?
>
> BTW, I don't see any reason why someone would want to keep using pvgrub
> with grub-pv being available...
I went to change its status in SUPPORT.md and it wasn't in evidence.
I guess you might still want it to boot old guests.
I don't think it has any security implications because it runs in
guest context.
I have prepared a patch to SUPPORT.md which I will send in a moemnt.
Ian.
Re: [xen-unstable test] 164237: regressions - FAIL
Ian Jackson writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> I will (1) drop this test and (2) force push staging in the meantime.
Force pushed xen-unstable staging. osstest commit is below.
Ian.
>From 8dee6e333622d830b7a9373989f63b526a85cd94 Mon Sep 17 00:00:00 2001
From: Ian Jackson
Date: Thu, 19 Aug 2021 13:46:21 +0100
Subject: [OSSTEST PATCH] make-flight: Drop pvgrub (pvgrub1) tests
This is obsolete. In 2017 in 6abb2f113025 we wrote:
A consequence is that this test will test jessie forever. Eventually
jessie will rot so badly that this test fails and then we will no
longer be testing pvgrub1. Hopefully by then no-one will be using it.
This has now occurred.
I have verified with
OSSTEST_CONFIG=standalone-config-example eatmydata
./standalone-generate-dump-flight-runvars
that the only change is to drop jobs test-amd64-amd64-*-pvgrub.
CC: Jan Beulich
CC: Juergen Gross
CC: Jan Beulich
Signed-off-by: Ian Jackson
---
make-flight | 25 -
1 file changed, 25 deletions(-)
diff --git a/make-flight b/make-flight
index fb38bc50..e0d11c80 100755
--- a/make-flight
+++ b/make-flight
@@ -598,30 +598,6 @@ do_pygrub_tests () {
all_hostflags=$most_hostflags
}
-do_pvgrub_tests () {
- if [ $xenarch != amd64 -o $dom0arch != amd64 -o "$kern" != "" ]; then
-return
- fi
-
- job_create_test test-$xenarch$kern-$dom0arch-amd64-pvgrub \
-test-debian-di xl $xenarch $dom0arch\
- debian_arch=amd64 \
- debian_suite=jessie \
- debian_di_version=`getconfig_TftpDiVersion_suite jessie` \
- debian_method=netboot \
- debian_bootloader=pvgrub \
- all_hostflags=$most_hostflags \
-
- job_create_test test-$xenarch$kern-$dom0arch-i386-pvgrub \
-test-debian-di xl $xenarch $dom0arch\
- debian_arch=i386 \
- debian_suite=jessie \
- debian_di_version=`getconfig_TftpDiVersion_suite jessie` \
- debian_method=netboot \
- debian_bootloader=pvgrub \
- all_hostflags=$most_hostflags
-}
-
do_pv_debian_test_one () {
testname=$1; shift
recipe_sfx=$1; shift
@@ -945,7 +921,6 @@ test_matrix_do_one () {
#do_passthrough_tests
do_pygrub_tests
- do_pvgrub_tests
do_shadow_tests
--
2.20.1
Re: [xen-unstable test] 164237: regressions - FAIL
Juergen Gross writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Does this mean we should de-support pvgrub? Or even remove it?
I think so.
> BTW, I don't see any reason why someone would want to keep using pvgrub
> with grub-pv being available...
Precisely.
Ian.
Re: [xen-unstable test] 164237: regressions - FAIL
On 19.08.21 14:45, Ian Jackson wrote:
Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
Looks like this didn't sort itself (yet). Do you continue to be
convinced that it will, eventually?
Hooray for explanations in commit messages.
I will (1) drop this test and (2) force push staging in the meantime.
Ian.
commit 6abb2f113025c37e3e5c6bb590b8e5f60c39a861
Author: Wei Liu
Date: Thu Nov 2 15:15:04 2017 +
make-flight: guest should use jessie to test pvgrub
stretch has 64bit feature enabled for ext4, which pvgrub can't cope.
We want to continue to test pvgrub, so specify jessie in the guest
suite field.
A consequence is that this test will test jessie forever. Eventually
jessie will rot so badly that this test fails and then we will no
longer be testing pvgrub1. Hopefully by then no-one will be using it.
CC: Juergen Gross
Signed-off-by: Wei Liu
Acked-by: Ian Jackson
Does this mean we should de-support pvgrub? Or even remove it?
BTW, I don't see any reason why someone would want to keep using pvgrub
with grub-pv being available...
Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
Re: [xen-unstable test] 164237: regressions - FAIL
Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Looks like this didn't sort itself (yet). Do you continue to be
> convinced that it will, eventually?
Hooray for explanations in commit messages.
I will (1) drop this test and (2) force push staging in the meantime.
Ian.
commit 6abb2f113025c37e3e5c6bb590b8e5f60c39a861
Author: Wei Liu
Date: Thu Nov 2 15:15:04 2017 +
make-flight: guest should use jessie to test pvgrub
stretch has 64bit feature enabled for ext4, which pvgrub can't cope.
We want to continue to test pvgrub, so specify jessie in the guest
suite field.
A consequence is that this test will test jessie forever. Eventually
jessie will rot so badly that this test fails and then we will no
longer be testing pvgrub1. Hopefully by then no-one will be using it.
CC: Juergen Gross
Signed-off-by: Wei Liu
Acked-by: Ian Jackson
Re: [xen-unstable test] 164237: regressions - FAIL
Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Looks like this didn't sort itself (yet). Do you continue to be
> convinced that it will, eventually?
Indeed not. The error message is different now. The guest installer
reports
2021-08-18 18:14:09 Z 172.16.146.47:58906 <12>Aug 18 18:14:09
choose-mirror[2883]: WARNING **: broken mirror: invalid Suite in
Release file for jessie
which is bizarre. I didn't realise this test was using jessie,
which is ancient. These tests seem to be hardcoded to use jessie.
I'm going through the git history to see if I (or someone else) wrote
anything which might explai.
I suspect this might be obsolete pvgrub1.
> Additionally I'm puzzled by these having been in the "are not
> blocking" section up to flight 164202, and have since been in the
> "are blocking" one.
Probably, the Debian mirrors changed to drop jessie.
Ian.
Re: [xen-unstable test] 164237: regressions - FAIL
On 19.08.2021 05:07, osstest service owner wrote: > flight 164237 xen-unstable real [real] > flight 164246 xen-unstable real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/164237/ > http://logs.test-lab.xenproject.org/osstest/logs/164246/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-amd64-pvgrub 12 debian-di-install fail REGR. vs. > 164178 > test-amd64-amd64-i386-pvgrub 12 debian-di-installfail REGR. vs. > 164178 Looks like this didn't sort itself (yet). Do you continue to be convinced that it will, eventually? Additionally I'm puzzled by these having been in the "are not blocking" section up to flight 164202, and have since been in the "are blocking" one. Jan
[xen-unstable test] 164237: regressions - FAIL
flight 164237 xen-unstable real [real] flight 164246 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164237/ http://logs.test-lab.xenproject.org/osstest/logs/164246/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-amd64-pvgrub 12 debian-di-install fail REGR. vs. 164178 test-amd64-amd64-i386-pvgrub 12 debian-di-installfail REGR. vs. 164178 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 164178 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164178 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stopfail like 164178 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164178 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164178 test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 164178 test-armhf-armhf-libvirt-raw 15 saverestore-support-checkfail like 164178 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stopfail like 164178 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164178 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164178 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 164178 test-arm64-arm64-xl-seattle 15 migrate-support-checkfail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-checkfail never pass test-amd64-i386-libvirt 15 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-checkfail never pass test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-checkfail never pass test-amd64-i386-xl-pvshim14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-checkfail never pass test-arm64-arm64-xl 16 saverestore-support-checkfail never pass test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit1 15 migrate-support-checkfail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-checkfail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-checkfail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit2 15 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-checkfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-checkfail never pass test-armhf-armhf-xl-credit1 15 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 15 migrate-support-checkfail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 15 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-checkfail never pass test-armhf-armhf-xl-vhd 14 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-checkfail never pass test-armhf-armhf-xl 15 migrate-support-checkfail never pass test-armhf-armhf-xl 16 saverestore-support-checkfail never pass test-armhf-armhf-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-checkfail never pass version targeted for testing: xen 54c9736382e0d558a6acd820e44185e020131c48 baseline version: xen 5a88d524857e5bf78b077d30ea515fcaac061bfc Last test of basis 164178 2021-08-13 10:47:20 Z5 days Failing since164182 2021-08-14 00:39:12 Z5 days8 attempts Testing same since 164237 2021-08-18 07:24:21 Z0 days1
