Hi Jan,
> -Original Message-
> From: Jan Beulich
> Sent: 2022年1月18日 0:22
> To: Wei Chen
> Cc: Bertrand Marquis ; xen-
> de...@lists.xenproject.org; sstabell...@kernel.org; jul...@xen.org
> Subject: Re: [PATCH 19/37] xen/x86: promote VIRTUAL_BUG_ON to ASSERT in
>
> On 23.09.2021 14:02, Wei Chen wrote:
> > VIRTUAL_BUG_ON that is using in phys_to_nid is an empty macro. This
> > results in two lines of error-checking code in phys_to_nid are not
> > actually working. It also covers up two compilation errors:
> > 1. error: ‘MAX_NUMNODES’ undeclared (first use in this function).
> >This is because MAX_NUMNODES is defined in xen/numa.h.
> >But asm/numa.h is a dependent file of xen/numa.h, we can't
> >include xen/numa.h in asm/numa.h. This error has been fixed
> >after we move phys_to_nid to xen/numa.h.
>
> This could easily be taken care of by move MAX_NUMNODES up ahead of
> the asm/numa.h inclusion point. And then the change here would become
> independent of the rest of the series (and could hence go in early).
>
> > 2. error: wrong type argument to unary exclamation mark.
> >This is becuase, the error-checking code contains !node_data[nid].
> >But node_data is a data structure variable, it's not a pointer.
> >
> > So, in this patch, we use ASSERT in VIRTUAL_BUG_ON to enable the two
> > lines of error-checking code.
>
> May I suggest to drop VIRTUAL_BUG_ON() and instead use ASSERT()
> directly?
>
Sure!
> Jan
