Re: [PATCH v2 1/5] libxenguest: support zstd compressed kernels
On Thu, Jan 21, 2021 at 04:05:39PM +0100, Jan Beulich wrote:
> On 21.01.2021 16:01, Wei Liu wrote:
> > On Tue, Jan 19, 2021 at 04:15:25PM +0100, Jan Beulich wrote:
> >> This follows the logic used for other decompression methods utilizing an
> >> external library, albeit here we can't ignore the 32-bit size field
> >> appended to the compressed image - its presence causes decompression to
> >> fail. Leverage the field instead to allocate the output buffer in one
> >> go, i.e. without incrementally realloc()ing.
> >>
> >> Note that, where possible, instead of #ifdef-ing xen/*.h inclusions,
> >> they get removed.
> >>
> >> Signed-off-by: Jan Beulich
> >
> >
> > Acked-by: Wei Liu
>
> Thanks, but I'm about to send v2.5 to address the issue reported
> by Michael Young (adjusting configure{.ac,} only).
>
> >> ---
> >> Note for committer: As an alternative to patching tools/configure here,
> >> autoconf may want re-running.
> >
> > Noted. FWIW I use Debian 10 to generate configure. If I don't get around
> > doing it someone who runs the same system should be able to help.
>
> Well, the version I've been using to re-generate isn't identical
> to yours, but allows easily filtering out and discarding the few
> extra differences, which is why I dared to provide a diff for
> tools/configure in the first place. IOW if I would commit this
> myself, all I would ask that you or someone else using the
> "original" autoconf to generate the committed version to double
> check.
This works too.
Wei.
>
> Jan
Re: [PATCH v2 1/5] libxenguest: support zstd compressed kernels
On 21.01.2021 16:01, Wei Liu wrote:
> On Tue, Jan 19, 2021 at 04:15:25PM +0100, Jan Beulich wrote:
>> This follows the logic used for other decompression methods utilizing an
>> external library, albeit here we can't ignore the 32-bit size field
>> appended to the compressed image - its presence causes decompression to
>> fail. Leverage the field instead to allocate the output buffer in one
>> go, i.e. without incrementally realloc()ing.
>>
>> Note that, where possible, instead of #ifdef-ing xen/*.h inclusions,
>> they get removed.
>>
>> Signed-off-by: Jan Beulich
>
>
> Acked-by: Wei Liu
Thanks, but I'm about to send v2.5 to address the issue reported
by Michael Young (adjusting configure{.ac,} only).
>> ---
>> Note for committer: As an alternative to patching tools/configure here,
>> autoconf may want re-running.
>
> Noted. FWIW I use Debian 10 to generate configure. If I don't get around
> doing it someone who runs the same system should be able to help.
Well, the version I've been using to re-generate isn't identical
to yours, but allows easily filtering out and discarding the few
extra differences, which is why I dared to provide a diff for
tools/configure in the first place. IOW if I would commit this
myself, all I would ask that you or someone else using the
"original" autoconf to generate the committed version to double
check.
Jan
Re: [PATCH v2 1/5] libxenguest: support zstd compressed kernels
On Tue, Jan 19, 2021 at 04:15:25PM +0100, Jan Beulich wrote: > This follows the logic used for other decompression methods utilizing an > external library, albeit here we can't ignore the 32-bit size field > appended to the compressed image - its presence causes decompression to > fail. Leverage the field instead to allocate the output buffer in one > go, i.e. without incrementally realloc()ing. > > Note that, where possible, instead of #ifdef-ing xen/*.h inclusions, > they get removed. > > Signed-off-by: Jan Beulich Acked-by: Wei Liu > --- > Note for committer: As an alternative to patching tools/configure here, > autoconf may want re-running. Noted. FWIW I use Debian 10 to generate configure. If I don't get around doing it someone who runs the same system should be able to help.
