Re: [PATCH v2 2/2] tools/xenstore: set open file descriptor limit for xenstored
Am Fri, 11 Jun 2021 09:07:24 +0200 schrieb Juergen Gross : > Isn't that a bug in fillup or the related rpm-macro? No. Fillup expects a certain pattern: a bunch of comments and a single key=var right after that. With such format it might be able to adjust the comment and leave the key=var as it is. Without key=var it will see it as a stale comment, and removes the entire section of comments during the next package update. Olaf pgpuK5DdIQlHg.pgp Description: Digitale Signatur von OpenPGP
Re: [PATCH v2 2/2] tools/xenstore: set open file descriptor limit for xenstored
On 11.06.21 07:46, Olaf Hering wrote: Am Fri, 11 Jun 2021 07:01:31 +0200 schrieb Juergen Gross : Why? You realize that above is a comment just documenting the default? That depends on the context. See https://bugzilla.opensuse.org/show_bug.cgi?id=1185682 for a reason why it should become an empty variable. But yes, we can patch that one too. Isn't that a bug in fillup or the related rpm-macro? A variable set in the existing /etc/sysconfig/xencommons file only should be preserved. In general I think we should be consistent in the file. In case there is no downside for other distributions I'd recommend to switch all variables to your suggested pattern. If there are disadvantages for others we should keep the current pattern as changing it now would break existing installations. Any thoughts? Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [PATCH v2 2/2] tools/xenstore: set open file descriptor limit for xenstored
Am Fri, 11 Jun 2021 07:01:31 +0200 schrieb Juergen Gross : > Why? You realize that above is a comment just documenting the default? That depends on the context. See https://bugzilla.opensuse.org/show_bug.cgi?id=1185682 for a reason why it should become an empty variable. But yes, we can patch that one too. Olaf pgp9e1bDV0Are.pgp Description: Digitale Signatur von OpenPGP
Re: [PATCH v2 2/2] tools/xenstore: set open file descriptor limit for xenstored
On 08.06.21 18:39, Olaf Hering wrote: Am Tue, 8 Jun 2021 07:58:39 +0200 schrieb Juergen Gross : +#XENSTORED_MAX_N_DOMAINS=32768 This will break fillup. Why? You realize that above is a comment just documenting the default? Provide an empty variable like it is done for a few others in that file. I'm following the pattern of basically all variables in that file, BTW. Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [PATCH v2 2/2] tools/xenstore: set open file descriptor limit for xenstored
Am Tue, 8 Jun 2021 07:58:39 +0200 schrieb Juergen Gross : > +#XENSTORED_MAX_N_DOMAINS=32768 This will break fillup. Provide an empty variable like it is done for a few others in that file. Olaf pgpV5bgbdAXTR.pgp Description: Digitale Signatur von OpenPGP
