Re: [PATCH v3 1/2] x86/HVM: expose VM assist hypercall

2020-04-22 Thread Julien Grall 




On 22/04/2020 10:04, Jan Beulich wrote:

On 22.04.2020 10:57, Julien Grall wrote:

On 21/04/2020 15:39, Jan Beulich wrote:

--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -269,6 +269,8 @@ static inline void free_vcpu_guest_conte
     static inline void arch_vcpu_block(struct vcpu *v) {}
   +#define arch_vm_assist_valid_mask(d) (1UL << 
VMASST_TYPE_runstate_update_flag)


NIT: Do we want to evaluate d?


I didn't think we need to, given the very limited use of the
macro.


Fair point. I thought I would ask just in case.




Reviewed-by: Julien Grall 


Thanks.

Jan



--
Julien Grall

Re: [PATCH v3 1/2] x86/HVM: expose VM assist hypercall

2020-04-22 Thread Jan Beulich 
On 22.04.2020 10:57, Julien Grall wrote:
> On 21/04/2020 15:39, Jan Beulich wrote:
>> --- a/xen/include/asm-arm/domain.h
>> +++ b/xen/include/asm-arm/domain.h
>> @@ -269,6 +269,8 @@ static inline void free_vcpu_guest_conte
>>     static inline void arch_vcpu_block(struct vcpu *v) {}
>>   +#define arch_vm_assist_valid_mask(d) (1UL << 
>> VMASST_TYPE_runstate_update_flag)
> 
> NIT: Do we want to evaluate d?

I didn't think we need to, given the very limited use of the
macro.

> Reviewed-by: Julien Grall 

Thanks.

Jan

Re: [PATCH v3 1/2] x86/HVM: expose VM assist hypercall

2020-04-22 Thread Julien Grall 

Hi Jan,

On 21/04/2020 15:39, Jan Beulich wrote:

--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -269,6 +269,8 @@ static inline void free_vcpu_guest_conte
  
  static inline void arch_vcpu_block(struct vcpu *v) {}
  
+#define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)


NIT: Do we want to evaluate d?

Reviewed-by: Julien Grall 

Cheers,

--
Julien Grall