Re: [XEN PATCH v3 13/25] tools/libs/util: cleanup Makefile

2022-07-05 Thread Bertrand Marquis
Hi Anthony,

> On 24 Jun 2022, at 17:04, Anthony PERARD  wrote:
> 
> Remove -I. from CFLAGS, it isn't necessary.
> 
> Removed $(AUTOSRCS), it isn't used.
> 
> Signed-off-by: Anthony PERARD 

Reviewed-by: Bertrand Marquis 

Cheers
Bertrand

> ---
> tools/libs/util/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
> index ffe507b379..493d2e00be 100644
> --- a/tools/libs/util/Makefile
> +++ b/tools/libs/util/Makefile
> @@ -11,7 +11,7 @@ OBJS-y += libxlu_pci.o
> 
> CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
>   -Wno-declaration-after-statement -Wformat-nonliteral
> -CFLAGS += -I. $(CFLAGS_libxenctrl)
> +CFLAGS += $(CFLAGS_libxenctrl)
> 
> CFLAGS += $(PTHREAD_CFLAGS)
> LDFLAGS += $(PTHREAD_LDFLAGS)
> @@ -29,7 +29,6 @@ ifeq ($(BISON),)
> endif
> 
> AUTOINCS = libxlu_cfg_y.h libxlu_cfg_l.h libxlu_disk_l.h
> -AUTOSRCS = libxlu_cfg_y.c libxlu_cfg_l.c
> 
> LIBHEADER := libxlutil.h
> PKG_CONFIG_NAME := Xlutil
> -- 
> Anthony PERARD
> 
> 




Re: [XEN PATCH v3 13/25] tools/libs/util: cleanup Makefile

2022-06-29 Thread Juergen Gross

On 24.06.22 18:04, Anthony PERARD wrote:

Remove -I. from CFLAGS, it isn't necessary.

Removed $(AUTOSRCS), it isn't used.

Signed-off-by: Anthony PERARD 


Reviewed-by: Juergen Gross 


Juergen


OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature