Re: [Xen-devel] [OSSTEST PATCH 3/3] mfi-*: Set appropriate PropMinVer:XenMin: hostflags, to honour XenMin property

2018-06-06 Thread Ian Jackson 
Anthony PERARD writes ("Re: [Xen-devel] [OSSTEST PATCH 3/3] mfi-*: Set 
appropriate PropMinVer:XenMin: hostflags, to honour XenMin property"):
> On Wed, Jun 06, 2018 at 12:04:56PM +0100, Ian Jackson wrote:
> > @@ -566,6 +573,13 @@ test_matrix_iterate () {
> >  if [ "x$min_linux_hostflag" != "x" ] ; then
> >  most_hostflags="$most_hostflags,$min_linux_hostflag"
> >  fi
> > +case "$xenbranch" in
> > +  xen-[0-9]*-testing)
> 
> I don't think that's going to work, xenbranch should contain string
> like "xen-4.3-testing". You want:
> 
>   xen-[0-9.]*-testing)

Thanks for the review.

However, it does work :-).  These patterns are glob patterns, so `*'
matches zero or more of any character.  This pattern is just here to
avoid turning `xen-unstable' into an attempt to set a `minimum xen
version' of `unstable'.

Regards,
Ian.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [OSSTEST PATCH 3/3] mfi-*: Set appropriate PropMinVer:XenMin: hostflags, to honour XenMin property

2018-06-06 Thread Anthony PERARD 
On Wed, Jun 06, 2018 at 12:04:56PM +0100, Ian Jackson wrote:
> @@ -566,6 +573,13 @@ test_matrix_iterate () {
>  if [ "x$min_linux_hostflag" != "x" ] ; then
>  most_hostflags="$most_hostflags,$min_linux_hostflag"
>  fi
> +case "$xenbranch" in
> +  xen-[0-9]*-testing)

I don't think that's going to work, xenbranch should contain string
like "xen-4.3-testing". You want:

  xen-[0-9.]*-testing)


-- 
Anthony PERARD

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [OSSTEST PATCH 3/3] mfi-*: Set appropriate PropMinVer:XenMin: hostflags, to honour XenMin property

2018-06-06 Thread Jan Beulich 
>>> On 06.06.18 at 13:04,  wrote:
> The motivation right now for this is that Xen 4.10 and earlier do not
> boot xen.gz on UEFI.  In earlier versions, one has to chainload
> xen.efi.  We don't support that in osstest right now on x86 (and it
> probably isn't worth fixing that logic).

This is 4.8 here; the actual code change has it that way. 4.10
was iirc mentioned by Julien as potentially needing special casing
on one of the ARM hosts, once commissioned.

Jan



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel