Re: [Xen-devel] [PATCH] x86/PV: fix off-by-one in I/O bitmap limit check

2018-02-26 Thread Andrew Cooper 
On 26/02/18 10:50, Jan Beulich wrote:
 On 26.02.18 at 11:44,  wrote:
>> On Mon, Feb 26, 2018 at 12:38:11AM -0700, Jan Beulich wrote:
>>> Signed-off-by: Jan Beulich 
>> Reviewed-by: Roger Pau Monné 
> Thanks.
>
>> I would however invert the check, my brain finds it easier to read
>> as:
>>
>> (port + bytes) <= v->arch.pv_vcpu.iobmp_limit
> My brain too, but I didn't want to make unrelated changes.

Reviewed-by: Andrew Cooper .  I think this is
a sufficiently small and well-describe change that rearranging the
expression for clarity is fine.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/PV: fix off-by-one in I/O bitmap limit check

2018-02-26 Thread Jan Beulich 
>>> On 26.02.18 at 11:44,  wrote:
> On Mon, Feb 26, 2018 at 12:38:11AM -0700, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich 
> 
> Reviewed-by: Roger Pau Monné 

Thanks.

> I would however invert the check, my brain finds it easier to read
> as:
> 
> (port + bytes) <= v->arch.pv_vcpu.iobmp_limit

My brain too, but I didn't want to make unrelated changes.

Jan

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/PV: fix off-by-one in I/O bitmap limit check

2018-02-26 Thread Roger Pau Monné 
On Mon, Feb 26, 2018 at 12:38:11AM -0700, Jan Beulich wrote:
> Signed-off-by: Jan Beulich 

Reviewed-by: Roger Pau Monné 

I would however invert the check, my brain finds it easier to read
as:

(port + bytes) <= v->arch.pv_vcpu.iobmp_limit

Thanks, Roger.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel