Re: [Xen-devel] [PATCH net-next] xen-netback: mark expected switch fall-through
>>> On 08.02.19 at 20:58, wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/xen-netback/xenbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/xenbus.c > b/drivers/net/xen-netback/xenbus.c > index 2625740bdc4a..330ddb64930f 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev, > set_backend_state(be, XenbusStateClosed); > if (xenbus_dev_is_online(dev)) > break; > - /* fall through if not online */ > + /* fall through - if not online */ > case XenbusStateUnknown: Considering the fall-through was already annotated, I don't think title and description really justify the change. Is the compiler after a particular wording here? Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH net-next] xen-netback: mark expected switch fall-through
On 2/8/19 2:21 PM, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Fri, 8 Feb 2019 13:58:38 -0600 > >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enabling >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva > > Applied. > Thanks, Dave. -- Gustavo ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH net-next] xen-netback: mark expected switch fall-through
From: "Gustavo A. R. Silva" Date: Fri, 8 Feb 2019 13:58:38 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva Applied. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
