Re: [Xen-devel] [PATCH v11 04/12] pci: split code to size BARs from pci_add_device

[Jan Beulich]

>>> On 22.03.18 at 11:31,  wrote:
> On Thu, Mar 22, 2018 at 04:15:06AM -0600, Jan Beulich wrote:
>> >>> On 20.03.18 at 16:15,  wrote:
>> > @@ -672,11 +722,16 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>> >  unsigned int i;
>> >  
>> >  BUILD_BUG_ON(ARRAY_SIZE(pdev->vf_rlen) != PCI_SRIOV_NUM_BARS);
>> > -for ( i = 0; i < PCI_SRIOV_NUM_BARS; ++i )
>> > +for ( i = 0; i < PCI_SRIOV_NUM_BARS; )
>> >  {
>> >  unsigned int idx = pos + PCI_SRIOV_BAR + i * 4;
>> >  u32 bar = pci_conf_read32(seg, bus, slot, func, idx);
>> > -u32 hi = 0;
>> > +pci_sbdf_t sbdf = {
>> > +.seg = seg,
>> > +.bus = bus,
>> > +.dev = slot,
>> > +.func = func,
>> > +};
>> 
>> So I've had everything up to patch 9 applied and ready for pushing,
>> when I did my usual secondary compile test on an old system: This
>> fails to compile with gcc 4.3 (due to there being a unnamed sub-
>> structure). A similar issue exists at least in patch 7. Since the
>> structure gets introduced in patch 1 (and hence may need changing
> 
> pci_sbdf_t is already in the source tree, it was introduced by
> 514f58d4468a40b5dd418a5ea1742681930c3f2d back in December.

Oh, I guess it's the test harness instance that I've mistakenly seen
in the grep output here.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v11 04/12] pci: split code to size BARs from pci_add_device

[Roger Pau Monné]

On Thu, Mar 22, 2018 at 04:15:06AM -0600, Jan Beulich wrote:
> >>> On 20.03.18 at 16:15,  wrote:
> > @@ -672,11 +722,16 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >  unsigned int i;
> >  
> >  BUILD_BUG_ON(ARRAY_SIZE(pdev->vf_rlen) != PCI_SRIOV_NUM_BARS);
> > -for ( i = 0; i < PCI_SRIOV_NUM_BARS; ++i )
> > +for ( i = 0; i < PCI_SRIOV_NUM_BARS; )
> >  {
> >  unsigned int idx = pos + PCI_SRIOV_BAR + i * 4;
> >  u32 bar = pci_conf_read32(seg, bus, slot, func, idx);
> > -u32 hi = 0;
> > +pci_sbdf_t sbdf = {
> > +.seg = seg,
> > +.bus = bus,
> > +.dev = slot,
> > +.func = func,
> > +};
> 
> So I've had everything up to patch 9 applied and ready for pushing,
> when I did my usual secondary compile test on an old system: This
> fails to compile with gcc 4.3 (due to there being a unnamed sub-
> structure). A similar issue exists at least in patch 7. Since the
> structure gets introduced in patch 1 (and hence may need changing

pci_sbdf_t is already in the source tree, it was introduced by
514f58d4468a40b5dd418a5ea1742681930c3f2d back in December.

> there, depending on how this is to be addressed), I'm not going to
> push any part of this series.

No patch in the series changes pci_sbdf_t at all, so in any case this
should be a pre-patch or a post-patch, but not really part of patch 1.

Thanks, Roger.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v11 04/12] pci: split code to size BARs from pci_add_device

[Jan Beulich]

>>> On 20.03.18 at 16:15,  wrote:
> @@ -672,11 +722,16 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>  unsigned int i;
>  
>  BUILD_BUG_ON(ARRAY_SIZE(pdev->vf_rlen) != PCI_SRIOV_NUM_BARS);
> -for ( i = 0; i < PCI_SRIOV_NUM_BARS; ++i )
> +for ( i = 0; i < PCI_SRIOV_NUM_BARS; )
>  {
>  unsigned int idx = pos + PCI_SRIOV_BAR + i * 4;
>  u32 bar = pci_conf_read32(seg, bus, slot, func, idx);
> -u32 hi = 0;
> +pci_sbdf_t sbdf = {
> +.seg = seg,
> +.bus = bus,
> +.dev = slot,
> +.func = func,
> +};

So I've had everything up to patch 9 applied and ready for pushing,
when I did my usual secondary compile test on an old system: This
fails to compile with gcc 4.3 (due to there being a unnamed sub-
structure). A similar issue exists at least in patch 7. Since the
structure gets introduced in patch 1 (and hence may need changing
there, depending on how this is to be addressed), I'm not going to
push any part of this series.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel