Re: convert the SCSI ULDs to the atomic queue limits API v2
On Fri, 31 May 2024 09:47:55 +0200, Christoph Hellwig wrote: > this series converts the SCSI upper level drivers to the atomic queue > limits API. > > The first patch is a bug fix for ubd that later patches depend on and > might be worth picking up for 6.10. > > The second patch changes the max_sectors calculation to take the optimal > I/O size into account so that sd, nbd and rbd don't have to mess with > the user max_sector value. I'd love to see a careful review from the > nbd and rbd maintainers for this one! > > [...] Applied, thanks! [01/14] ubd: refactor the interrupt handler commit: 5db755fbb1a0de4a4cfd5d5edfaa19853b9c56e6 [02/14] ubd: untagle discard vs write zeroes not support handling commit: 31ade7d4fdcf382beb8cb229a1f5d77e0f239672 [03/14] rbd: increase io_opt again commit: a00d4bfce7c6d7fa4712b8133ec195c9bd142ae6 [04/14] block: take io_opt and io_min into account for max_sectors commit: a23634644afc2f7c1bac98776440a1f3b161819e [05/14] sd: simplify the ZBC case in provisioning_mode_store commit: b3491b0db165c0cbe25874da66d97652c03db654 [06/14] sd: add a sd_disable_discard helper commit: b0dadb86a90bd5a7b723f9d3a6cf69da9b596496 [07/14] sd: add a sd_disable_write_same helper commit: 9972b8ce0d4ba373901bdd1e15e4de58fcd7f662 [08/14] sd: simplify the disable case in sd_config_discard commit: d15b9bd42cd3b2077812d4bf32f532a9bd5c4914 [09/14] sd: factor out a sd_discard_mode helper commit: f1e8185fc12c699c3abf4f39b1ff5d7793da3a95 [10/14] sd: cleanup zoned queue limits initialization commit: 9c1d339a1bf45f4d3a2e77bbf24b0ec51f02551c [11/14] sd: convert to the atomic queue limits API commit: 804e498e0496d889090f32f812b5ce1a4f2aa63e [12/14] sr: convert to the atomic queue limits API commit: 969f17e10f5b732c05186ee0126c8a08166d0cda [13/14] block: remove unused queue limits API commit: 1652b0bafeaa8281ca9a805d81e13d7647bd2f44 [14/14] block: add special APIs for run-time disabling of discard and friends commit: 73e3715ed14844067c5c598e72777641004a7f60 Best regards, -- Jens Axboe
Re: convert the SCSI ULDs to the atomic queue limits API v2
On Fri, May 31, 2024 at 08:07:54AM -0400, Martin K. Petersen wrote: > If you have other block layer changes depending on this series we'll > probably need a shared branch. I'll need to make several changes to sd.c > to fix reported issues, including a couple in the zeroing/discard > department. Yes, I also want to move the various feature flags that currently abususe queue->flags into the queue limits. In the worst case I could delay that for another merge window, but a shared branch would be a lot nicer.
Re: convert the SCSI ULDs to the atomic queue limits API v2
Christoph, > The patches are against Jens' block-6.10 tree. Due to the amount of > block layer changes in here, and other that will depend on it, it > would be good if this could eventually be merged through the block > tree, or at least a shared branch between the SCSI and block trees. If you have other block layer changes depending on this series we'll probably need a shared branch. I'll need to make several changes to sd.c to fix reported issues, including a couple in the zeroing/discard department. No objections to your series so far. Just trying to reconcile your changes with mine... -- Martin K. Petersen Oracle Linux Engineering
Re: convert the SCSI ULDs to the atomic queue limits API v2
On 31/05/2024 08:47, Christoph Hellwig wrote: Hi all, Just saying that b4 for some reason does not create a .mbox to apply for this series when using "b4 am". It also no longer does for v1 (when it did previously). I guess that the series versioning confused it. this series converts the SCSI upper level drivers to the atomic queue limits API. The first patch is a bug fix for ubd that later patches depend on and might be worth picking up for 6.10. The second patch changes the max_sectors calculation to take the optimal I/O size into account so that sd, nbd and rbd don't have to mess with the user max_sector value. I'd love to see a careful review from the nbd and rbd maintainers for this one! The following patches clean up a few lose ends in the sd driver, and then convert sd and sr to the atomic queue limits API. The final patches remove the now unused block APIs, and convert a few to be specific to their now more narrow use case. The patches are against Jens' block-6.10 tree. Due to the amount of block layer changes in here, and other that will depend on it, it would be good if this could eventually be merged through the block tree, or at least a shared branch between the SCSI and block trees. Changes since v1: - change the io_opt value for rbd - fix a left-over direct assignent to q->limits - add a new patch to refactor the ubd interrupt handler - use an else if to micro-optimize the ubd error handling - also remove disk_set_max_open_zones and disk_set_max_active_zones - use SECTOR_SHIFT in one more place - various spelling fixes - comment formating fix Diffstat: arch/um/drivers/ubd_kern.c | 50 +++-- block/blk-settings.c | 238 +-- drivers/block/nbd.c |2 drivers/block/rbd.c |3 drivers/block/xen-blkfront.c |4 drivers/scsi/sd.c| 222 drivers/scsi/sd.h|6 - drivers/scsi/sd_zbc.c| 27 ++-- drivers/scsi/sr.c| 42 --- include/linux/blkdev.h | 52 +++-- 10 files changed, 210 insertions(+), 436 deletions(-)
convert the SCSI ULDs to the atomic queue limits API v2
Hi all, this series converts the SCSI upper level drivers to the atomic queue limits API. The first patch is a bug fix for ubd that later patches depend on and might be worth picking up for 6.10. The second patch changes the max_sectors calculation to take the optimal I/O size into account so that sd, nbd and rbd don't have to mess with the user max_sector value. I'd love to see a careful review from the nbd and rbd maintainers for this one! The following patches clean up a few lose ends in the sd driver, and then convert sd and sr to the atomic queue limits API. The final patches remove the now unused block APIs, and convert a few to be specific to their now more narrow use case. The patches are against Jens' block-6.10 tree. Due to the amount of block layer changes in here, and other that will depend on it, it would be good if this could eventually be merged through the block tree, or at least a shared branch between the SCSI and block trees. Changes since v1: - change the io_opt value for rbd - fix a left-over direct assignent to q->limits - add a new patch to refactor the ubd interrupt handler - use an else if to micro-optimize the ubd error handling - also remove disk_set_max_open_zones and disk_set_max_active_zones - use SECTOR_SHIFT in one more place - various spelling fixes - comment formating fix Diffstat: arch/um/drivers/ubd_kern.c | 50 +++-- block/blk-settings.c | 238 +-- drivers/block/nbd.c |2 drivers/block/rbd.c |3 drivers/block/xen-blkfront.c |4 drivers/scsi/sd.c| 222 drivers/scsi/sd.h|6 - drivers/scsi/sd_zbc.c| 27 ++-- drivers/scsi/sr.c| 42 --- include/linux/blkdev.h | 52 +++-- 10 files changed, 210 insertions(+), 436 deletions(-)
