Re: [XenPPC] [xenppc-unstable] [XEN][POWERPC] Remove pfn2mfn() now that it is understood

2006-10-10 Thread Jimi Xenidis


On Oct 10, 2006, at 9:20 AM, Xen patchbot-xenppc-unstable wrote:


# HG changeset patch
# User Jimi Xenidis <[EMAIL PROTECTED]>
# Node ID 7af3636da4b955e556af19af91b03633b565cce2
# Parent  3583d270140501b208f08335e10105d3f05c52d8
[XEN][POWERPC] Remove pfn2mfn() now that it is understood

That should be "Remove pfn2mfn() BUG()..."


___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel


[XenPPC] [xenppc-unstable] [XEN][POWERPC] Remove pfn2mfn() now that it is understood

2006-10-10 Thread Xen patchbot-xenppc-unstable
# HG changeset patch
# User Jimi Xenidis <[EMAIL PROTECTED]>
# Node ID 7af3636da4b955e556af19af91b03633b565cce2
# Parent  3583d270140501b208f08335e10105d3f05c52d8
[XEN][POWERPC] Remove pfn2mfn() now that it is understood

It is possible (thank you xm-test) to initiate a grant copy to a page
belonging to a dying domain, the page end up being owned by nobody
which is what the original test asserted.

Signed-off-by: Jimi Xenidis <[EMAIL PROTECTED]>
---
 xen/arch/powerpc/mm.c |   13 -
 1 files changed, 12 insertions(+), 1 deletion(-)

diff -r 3583d2701405 -r 7af3636da4b9 xen/arch/powerpc/mm.c
--- a/xen/arch/powerpc/mm.c Sun Oct 08 11:52:28 2006 -0400
+++ b/xen/arch/powerpc/mm.c Tue Oct 10 09:09:38 2006 -0400
@@ -416,7 +416,18 @@ ulong pfn2mfn(struct domain *d, ulong pf
 cur_pfn += pe_pages;
 }
 }
-BUG_ON(t != PFN_TYPE_NONE && page_get_owner(mfn_to_page(mfn)) != d);
+#ifdef DEBUG
+if (t != PFN_TYPE_NONE &&
+(d->domain_flags & DOMF_dying) &&
+page_get_owner(mfn_to_page(mfn)) != d) {
+printk("%s: page type: %d owner Dom[%d]:%p expected Dom[%d]:%p\n",
+   __func__, t,
+   page_get_owner(mfn_to_page(mfn))->domain_id,
+   page_get_owner(mfn_to_page(mfn)),
+   d->domain_id, d);
+BUG();
+}
+#endif
 }
 
 if (t == PFN_TYPE_NONE) {

___
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel