Re: [PATCH] ipipe: noarch: Fix handling of PCIe MSI interrupts for dwc PCIe controller

[Greg Gallagher via Xenomai]

On Mon, Mar 21, 2022 at 8:43 AM Jan Kiszka  wrote:

> On 18.03.22 17:53, Scott Reed wrote:
> > Handling of PCIe MSI interrupts resulted in system
> > hanging or high latencies.
> >
> > Fix is to replaced missed call to generic_handle_irq with
> > ipipe_handle_irq().
> >
> > Signed-off-by: Scott Reed 
> > ---
> >  drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c
> b/drivers/pci/controller/dwc/pcie-designware-host.c
> > index c9fd4e4966ba..7b566da64438 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> > @@ -100,7 +100,7 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp)
> >   irq = irq_find_mapping(pp->irq_domain,
> >  (i * MAX_MSI_IRQS_PER_CTRL)
> +
> >  pos);
> > - generic_handle_irq(irq);
> > + ipipe_handle_demuxed_irq(irq);
> >   pos++;
> >   }
> >   }
>
> Thanks, applied to noarch, ipipe/master and stable/4.19.x.
>
> Greg, you can pick up.
>
> Jan
>
> --
> Siemens AG, Technology
> Competence Center Embedded Linux


Testing on arm now, arm64 shortly

-Greg

>
>

Re: [PATCH] ipipe: noarch: Fix handling of PCIe MSI interrupts for dwc PCIe controller

[Jan Kiszka via Xenomai]

On 18.03.22 17:53, Scott Reed wrote:
> Handling of PCIe MSI interrupts resulted in system
> hanging or high latencies.
> 
> Fix is to replaced missed call to generic_handle_irq with
> ipipe_handle_irq().
> 
> Signed-off-by: Scott Reed 
> ---
>  drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c 
> b/drivers/pci/controller/dwc/pcie-designware-host.c
> index c9fd4e4966ba..7b566da64438 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -100,7 +100,7 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp)
>   irq = irq_find_mapping(pp->irq_domain,
>  (i * MAX_MSI_IRQS_PER_CTRL) +
>  pos);
> - generic_handle_irq(irq);
> + ipipe_handle_demuxed_irq(irq);
>   pos++;
>   }
>   }

Thanks, applied to noarch, ipipe/master and stable/4.19.x.

Greg, you can pick up.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

[PATCH] ipipe: noarch: Fix handling of PCIe MSI interrupts for dwc PCIe controller

[Scott Reed via Xenomai]

Handling of PCIe MSI interrupts resulted in system
hanging or high latencies.

Fix is to replaced missed call to generic_handle_irq with
ipipe_handle_irq().

Signed-off-by: Scott Reed 
---
 drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c 
b/drivers/pci/controller/dwc/pcie-designware-host.c
index c9fd4e4966ba..7b566da64438 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -100,7 +100,7 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp)
irq = irq_find_mapping(pp->irq_domain,
   (i * MAX_MSI_IRQS_PER_CTRL) +
   pos);
-   generic_handle_irq(irq);
+   ipipe_handle_demuxed_irq(irq);
pos++;
}
}
-- 
2.25.1