[PATCH 1/2] kernel: cobalt: Fix up elf_hwcap
Update elf_hwcap to ELF_HWCAP, this will work for newer 5.4 kernels
Signen-off-by: Greg Gallagher
---
kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
index b7e3f52f2..291c9e5f0 100644
--- a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
+++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
@@ -23,7 +23,7 @@
#include
#include
-#define have_fp (elf_hwcap & HWCAP_FP)
+#define have_fp (ELF_HWCAP & HWCAP_FP)
static inline int fp_kernel_supported(void)
{
--
2.25.1
Re: [PATCH 1/2] kernel: cobalt: Fix up elf_hwcap
On 27.01.21 06:43, Greg Gallagher via Xenomai wrote:
> Update elf_hwcap to ELF_HWCAP, this will work for newer 5.4 kernels
>
I assume you mean "also work" - or does it break on certain older
kernels? Just asking before consulting our CI. ;)
> Signen-off-by: Greg Gallagher
> ---
> kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> index b7e3f52f2..291c9e5f0 100644
> --- a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> +++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> @@ -23,7 +23,7 @@
> #include
> #include
>
> -#define have_fp (elf_hwcap & HWCAP_FP)
> +#define have_fp (ELF_HWCAP & HWCAP_FP)
>
> static inline int fp_kernel_supported(void)
> {
>
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
Re: [PATCH 1/2] kernel: cobalt: Fix up elf_hwcap
On 27.01.21 07:13, Jan Kiszka via Xenomai wrote:
> On 27.01.21 06:43, Greg Gallagher via Xenomai wrote:
>> Update elf_hwcap to ELF_HWCAP, this will work for newer 5.4 kernels
>>
>
> I assume you mean "also work" - or does it break on certain older
> kernels? Just asking before consulting our CI. ;)
>
...and the same pattern exists on ARM.
Jan
>> Signen-off-by: Greg Gallagher
>> ---
>> kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> index b7e3f52f2..291c9e5f0 100644
>> --- a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> +++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> @@ -23,7 +23,7 @@
>> #include
>> #include
>>
>> -#define have_fp (elf_hwcap & HWCAP_FP)
>> +#define have_fp (ELF_HWCAP & HWCAP_FP)
>>
>> static inline int fp_kernel_supported(void)
>> {
>>
>
> Jan
>
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
Re: [PATCH 1/2] kernel: cobalt: Fix up elf_hwcap
On Wed, Jan 27, 2021 at 1:15 AM Jan Kiszka wrote:
> On 27.01.21 07:13, Jan Kiszka via Xenomai wrote:
> > On 27.01.21 06:43, Greg Gallagher via Xenomai wrote:
> >> Update elf_hwcap to ELF_HWCAP, this will work for newer 5.4 kernels
> >>
> >
> > I assume you mean "also work" - or does it break on certain older
> > kernels? Just asking before consulting our CI. ;)
> >
>
> ...and the same pattern exists on ARM.
>
> Jan
>
> >> Signen-off-by: Greg Gallagher
> >> ---
> >> kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> >> index b7e3f52f2..291c9e5f0 100644
> >> --- a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> >> +++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
> >> @@ -23,7 +23,7 @@
> >> #include
> >> #include
> >>
> >> -#define have_fp (elf_hwcap & HWCAP_FP)
> >> +#define have_fp (ELF_HWCAP & HWCAP_FP)
> >>
> >> static inline int fp_kernel_supported(void)
> >> {
> >>
> >
> > Jan
> >
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>
No problem, ACK. I'll put a more meaningful commit message as well. I
thought I changed that before I sent the patch.
-Greg
Re: [PATCH 1/2] kernel: cobalt: Fix up elf_hwcap
On Wed, Jan 27, 2021 at 9:26 AM Greg Gallagher
wrote:
>
>
> On Wed, Jan 27, 2021 at 1:15 AM Jan Kiszka wrote:
>
>> On 27.01.21 07:13, Jan Kiszka via Xenomai wrote:
>> > On 27.01.21 06:43, Greg Gallagher via Xenomai wrote:
>> >> Update elf_hwcap to ELF_HWCAP, this will work for newer 5.4 kernels
>> >>
>> >
>> > I assume you mean "also work" - or does it break on certain older
>> > kernels? Just asking before consulting our CI. ;)
>> >
>>
>> ...and the same pattern exists on ARM.
>>
>> Jan
>>
>> >> Signen-off-by: Greg Gallagher
>> >> ---
>> >> kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> >> index b7e3f52f2..291c9e5f0 100644
>> >> --- a/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> >> +++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/fptest.h
>> >> @@ -23,7 +23,7 @@
>> >> #include
>> >> #include
>> >>
>> >> -#define have_fp (elf_hwcap & HWCAP_FP)
>> >> +#define have_fp (ELF_HWCAP & HWCAP_FP)
>> >>
>> >> static inline int fp_kernel_supported(void)
>> >> {
>> >>
>> >
>> > Jan
>> >
>>
>> --
>> Siemens AG, T RDA IOT
>> Corporate Competence Center Embedded Linux
>>
>
> No problem, ACK. I'll put a more meaningful commit message as well. I
> thought I changed that before I sent the patch.
>
> -Greg
>
These don't need to be updated on the arm (aarch32) side of things. I have
that port running now and should have testing done this evening. I will
update this patch with a better commit message.
-Greg
