[Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM interrupt
Hi All,
I am trying to enable pinctrl-intel.c GPIO interrupt as RTDM interrupt. I use
rtdm_irq_request to replace devm_request_irq in probe function.
code is as following:
===
#if 1
if ((ret = rtdm_irq_request(&irq_rtdm,
irq, handler_interruption,
0,
"test", NULL)) != 0) {
printk("rtdm request error\n");
}
#else
ret = devm_request_irq(pctrl->dev, irq, intel_gpio_irq, IRQF_SHARED,
dev_name(pctrl->dev), pctrl);
if (ret) {
dev_err(pctrl->dev, "failed to request interrupt\n");
goto fail;
}
#endif
=
I check /proc/xenomai/irq, it shows GPIO interrupt has been registered as
XENOMAI interrupt.
=
[root@localhost devices]# cat /proc/xenomai/irq
IRQ CPU0CPU1CPU2CPU3
14: 0 0 0 0 test
4352: 0 0 0 0 [sync]
4353: 0 0 0 1 [reschedule]
4354: 1007738 987012 1007340 1082939 [timer/0]
4355: 1 1 0 1 [timer-ipi]
4419: 0 0 0 0 [virtual]
===
But once I trigger the GPIO interrupt, the interrupt handler can't be called.
Instead, it shows:
<3>[ 156.957511] DMAR: DRHD: handling fault status reg 2
<3>[ 156.957541] DMAR: INTR-REMAP: Request device [[f0:1f.0] fault index 0
<3>[ 156.957541] INTR-REMAP:[fault reason 37] Blocked a compatibility format
interrupt request
I also list lspci -v, there is no device named f0:1f.0.
Could someone help me with this? Did I miss something when request RTDM
interrupt?
Best Regards,
Archer Yan
___
Xenomai mailing list
Xenomai@xenomai.org
https://xenomai.org/mailman/listinfo/xenomai
Re: [Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM interrupt
I'm probably not much help but something similar was on the list a while ago:
https://xenomai.org/pipermail/xenomai/2017-November/038014.html
On Thu, Jun 7, 2018 at 11:55 AM, Yan, Hongliang wrote:
> Hi All,
> I am trying to enable pinctrl-intel.c GPIO interrupt as RTDM interrupt. I
> use rtdm_irq_request to replace devm_request_irq in probe function.
> code is as following:
> ===
> #if 1
> if ((ret = rtdm_irq_request(&irq_rtdm,
> irq, handler_interruption,
> 0,
> "test", NULL)) != 0) {
> printk("rtdm request error\n");
> }
>
> #else
> ret = devm_request_irq(pctrl->dev, irq, intel_gpio_irq, IRQF_SHARED,
>dev_name(pctrl->dev), pctrl);
> if (ret) {
> dev_err(pctrl->dev, "failed to request interrupt\n");
> goto fail;
> }
> #endif
> =
> I check /proc/xenomai/irq, it shows GPIO interrupt has been registered as
> XENOMAI interrupt.
> =
> [root@localhost devices]# cat /proc/xenomai/irq
> IRQ CPU0CPU1CPU2CPU3
>14: 0 0 0 0 test
> 4352: 0 0 0 0 [sync]
> 4353: 0 0 0 1 [reschedule]
> 4354: 1007738 987012 1007340 1082939 [timer/0]
> 4355: 1 1 0 1 [timer-ipi]
> 4419: 0 0 0 0 [virtual]
> ===
> But once I trigger the GPIO interrupt, the interrupt handler can't be called.
> Instead, it shows:
> <3>[ 156.957511] DMAR: DRHD: handling fault status reg 2
> <3>[ 156.957541] DMAR: INTR-REMAP: Request device [[f0:1f.0] fault index 0
> <3>[ 156.957541] INTR-REMAP:[fault reason 37] Blocked a compatibility format
> interrupt request
>
> I also list lspci -v, there is no device named f0:1f.0.
> Could someone help me with this? Did I miss something when request RTDM
> interrupt?
>
> Best Regards,
>
> Archer Yan
> ___
> Xenomai mailing list
> Xenomai@xenomai.org
> https://xenomai.org/mailman/listinfo/xenomai
___
Xenomai mailing list
Xenomai@xenomai.org
https://xenomai.org/mailman/listinfo/xenomai
Re: [Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM interrupt
On 06/07/2018 05:55 PM, Yan, Hongliang wrote:
> Hi All,
> I am trying to enable pinctrl-intel.c GPIO interrupt as RTDM interrupt. I
> use rtdm_irq_request to replace devm_request_irq in probe function.
> code is as following:
> ===
> #if 1
> if ((ret = rtdm_irq_request(&irq_rtdm,
> irq, handler_interruption,
> 0,
> "test", NULL)) != 0) {
> printk("rtdm request error\n");
> }
>
> #else
> ret = devm_request_irq(pctrl->dev, irq, intel_gpio_irq, IRQF_SHARED,
>dev_name(pctrl->dev), pctrl);
> if (ret) {
> dev_err(pctrl->dev, "failed to request interrupt\n");
> goto fail;
> }
> #endif
That won't work, unless you fixed up that GPIO driver to cope with interrupt
pipelining - which does not seem to be the case.
If you plan to implement those changes, please keep in mind that you won't be
able to share a common IRQ line between multiple GPIO controllers unlike
pinctrl-intel would originally allow for non-rt usage. The current I-pipe patch
implementation does not support this.
The code below was an attempt to adapt the pinctrl-intel driver to IRQ
pipelining, which broke in flight due to lack of time. It is very unlikely to
work as is, not even to build properly, I have no clue whether there is a
slightest chance this might work, but that's a starting point...to somewhere.
commit ab4493579d95de58718a8ea81ae1fffc6f2ed0f7 (wip/intel-pinctrl)
Author: Philippe Gerum
Date: Wed May 31 18:16:19 2017 +0200
drivers: inter-pinctrl: make I-pipe aware
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c
b/drivers/pinctrl/intel/pinctrl-intel.c
index 01443762e570..f8bf54b6d485 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -91,7 +91,11 @@ struct intel_pinctrl_context {
*/
struct intel_pinctrl {
struct device *dev;
+#ifdef CONFIG_IPIPE
+ ipipe_spinlock_t lock;
+#else
raw_spinlock_t lock;
+#endif
struct pinctrl_desc pctldesc;
struct pinctrl_dev *pctldev;
struct gpio_chip chip;
@@ -647,15 +651,13 @@ static const struct gpio_chip intel_gpio_chip = {
.set = intel_gpio_set,
};
-static void intel_gpio_irq_ack(struct irq_data *d)
+static void __intel_gpio_irq_ack(struct irq_data *d)
{
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
const struct intel_community *community;
unsigned pin = irqd_to_hwirq(d);
- raw_spin_lock(&pctrl->lock);
-
community = intel_get_community(pctrl, pin);
if (community) {
unsigned padno = pin_to_padno(community, pin);
@@ -664,7 +666,14 @@ static void intel_gpio_irq_ack(struct irq_data *d)
writel(BIT(gpp_offset), community->regs + GPI_IS + gpp * 4);
}
+}
+static void intel_gpio_irq_ack(struct irq_data *d)
+{
+ struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
+
+ raw_spin_lock(&pctrl->lock);
+ __intel_gpio_irq_ack(d);
raw_spin_unlock(&pctrl->lock);
}
@@ -694,18 +703,17 @@ static void intel_gpio_irq_enable(struct irq_data *d)
writel(value, community->regs + community->ie_offset + gpp * 4);
}
+ ipipe_unlock_irq(d->irq);
+
raw_spin_unlock_irqrestore(&pctrl->lock, flags);
}
-static void intel_gpio_irq_mask_unmask(struct irq_data *d, bool mask)
+static void __intel_gpio_irq_mask_unmask(struct irq_data *d, bool mask)
{
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
const struct intel_community *community;
unsigned pin = irqd_to_hwirq(d);
- unsigned long flags;
-
- raw_spin_lock_irqsave(&pctrl->lock, flags);
community = intel_get_community(pctrl, pin);
if (community) {
@@ -723,20 +731,55 @@ static void intel_gpio_irq_mask_unmask(struct irq_data
*d, bool mask)
value |= BIT(gpp_offset);
writel(value, reg);
}
-
- raw_spin_unlock_irqrestore(&pctrl->lock, flags);
}
static void intel_gpio_irq_mask(struct irq_data *d)
{
- intel_gpio_irq_mask_unmask(d, true);
+ struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
+ unsigned long flags;
+
+ raw_spin_lock_irqsave(&pctrl->lock, flags);
+ ipipe_lock_irq(d->irq);
+ __intel_gpio_irq_mask_unmask(d, true);
+ raw_spin_unlock_irqrestore(&pctrl->lock, flags);
}
static void intel_gpio_irq_unmask(struct irq_data *d)
{
- intel_gpio_irq_mask_unmask(d, false);
+ struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
+ unsigned long flags;
+
+ raw_spin_lock_irqsave(&pctrl->lock, flags);
+ __intel_gpio_irq_mask_unmask(d, false);
+ ipipe_unlock_irq(d->irq);
+ raw_spin_unlock_irqr
Re: [Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM interrupt
Hi Philippe,
May I ask why you use irq_set_chained_handler_and_data instead of
rtdm_irq_request? It seems irq_set_chained_handler_and_data register the irq as
ipipe_root_domain while rtdm_irq_request register the irq as
xnsched_realtime_domain. Can we use xnsched_realtime_domain for this GPIO
interrupt?
Best Regards,
Archer Yan
严鸿亮
-Original Message-
From: Philippe Gerum [mailto:r...@xenomai.org]
Sent: Friday, June 8, 2018 1:10 AM
To: Yan, Hongliang ; Xenomai@xenomai.org
Subject: Re: [Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM
interrupt
On 06/07/2018 05:55 PM, Yan, Hongliang wrote:
> Hi All,
> I am trying to enable pinctrl-intel.c GPIO interrupt as RTDM interrupt. I
> use rtdm_irq_request to replace devm_request_irq in probe function.
> code is as following:
> ==
> =
> #if 1
> if ((ret = rtdm_irq_request(&irq_rtdm,
> irq, handler_interruption,
> 0,
> "test", NULL)) != 0) {
> printk("rtdm request error\n"); }
>
> #else
> ret = devm_request_irq(pctrl->dev, irq, intel_gpio_irq, IRQF_SHARED,
>dev_name(pctrl->dev), pctrl);
> if (ret) {
> dev_err(pctrl->dev, "failed to request interrupt\n");
> goto fail;
> }
> #endif
That won't work, unless you fixed up that GPIO driver to cope with interrupt
pipelining - which does not seem to be the case.
If you plan to implement those changes, please keep in mind that you won't be
able to share a common IRQ line between multiple GPIO controllers unlike
pinctrl-intel would originally allow for non-rt usage. The current I-pipe patch
implementation does not support this.
The code below was an attempt to adapt the pinctrl-intel driver to IRQ
pipelining, which broke in flight due to lack of time. It is very unlikely to
work as is, not even to build properly, I have no clue whether there is a
slightest chance this might work, but that's a starting point...to somewhere.
commit ab4493579d95de58718a8ea81ae1fffc6f2ed0f7 (wip/intel-pinctrl)
Author: Philippe Gerum
Date: Wed May 31 18:16:19 2017 +0200
drivers: inter-pinctrl: make I-pipe aware
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c
b/drivers/pinctrl/intel/pinctrl-intel.c
index 01443762e570..f8bf54b6d485 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -91,7 +91,11 @@ struct intel_pinctrl_context {
*/
struct intel_pinctrl {
struct device *dev;
+#ifdef CONFIG_IPIPE
+ ipipe_spinlock_t lock;
+#else
raw_spinlock_t lock;
+#endif
struct pinctrl_desc pctldesc;
struct pinctrl_dev *pctldev;
struct gpio_chip chip;
@@ -647,15 +651,13 @@ static const struct gpio_chip intel_gpio_chip = {
.set = intel_gpio_set,
};
-static void intel_gpio_irq_ack(struct irq_data *d)
+static void __intel_gpio_irq_ack(struct irq_data *d)
{
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
const struct intel_community *community;
unsigned pin = irqd_to_hwirq(d);
- raw_spin_lock(&pctrl->lock);
-
community = intel_get_community(pctrl, pin);
if (community) {
unsigned padno = pin_to_padno(community, pin); @@ -664,7
+666,14 @@ static void intel_gpio_irq_ack(struct irq_data *d)
writel(BIT(gpp_offset), community->regs + GPI_IS + gpp * 4);
}
+}
+static void intel_gpio_irq_ack(struct irq_data *d) {
+ struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
+
+ raw_spin_lock(&pctrl->lock);
+ __intel_gpio_irq_ack(d);
raw_spin_unlock(&pctrl->lock);
}
@@ -694,18 +703,17 @@ static void intel_gpio_irq_enable(struct irq_data *d)
writel(value, community->regs + community->ie_offset + gpp * 4);
}
+ ipipe_unlock_irq(d->irq);
+
raw_spin_unlock_irqrestore(&pctrl->lock, flags); }
-static void intel_gpio_irq_mask_unmask(struct irq_data *d, bool mask)
+static void __intel_gpio_irq_mask_unmask(struct irq_data *d, bool mask)
{
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
const struct intel_community *community;
unsigned pin = irqd_to_hwirq(d);
- unsigned long flags;
-
- raw_spin_lock_irqsave(&pctrl->lock, flags);
community = intel_get_community(pctrl, pin);
if (community) {
@@ -723,20 +731,55 @@ static void intel_gpio_irq_mask_unmask(struct irq_data
*d, bool mask)
value |= BIT(gpp_offset);
writel(value, reg);
}
-
- raw_spin_unlock_irqrestore(&pctrl->
Re: [Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM interrupt
On 06/08/2018 07:22 AM, Yan, Hongliang wrote:
> Hi Philippe,
> May I ask why you use irq_set_chained_handler_and_data instead of
> rtdm_irq_request? It seems irq_set_chained_handler_and_data register the irq
> as ipipe_root_domain while rtdm_irq_request register the irq as
> xnsched_realtime_domain. Can we use xnsched_realtime_domain for this GPIO
> interrupt?
That is the other way around. The rtdm* API is based on the modified
genirq core from the Linux kernel. Modifying the pinctrl driver enables
IRQ pipelining, which in turn allows rtdm* calls to interpose on the IRQ
flow for handling events in rt mode.
>
> Best Regards,
>
> Archer Yan
> 严鸿亮
>
>
> -Original Message-
> From: Philippe Gerum [mailto:r...@xenomai.org]
> Sent: Friday, June 8, 2018 1:10 AM
> To: Yan, Hongliang ; Xenomai@xenomai.org
> Subject: Re: [Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM
> interrupt
>
> On 06/07/2018 05:55 PM, Yan, Hongliang wrote:
>> Hi All,
>> I am trying to enable pinctrl-intel.c GPIO interrupt as RTDM interrupt. I
>> use rtdm_irq_request to replace devm_request_irq in probe function.
>> code is as following:
>> ==
>> =
>> #if 1
>> if ((ret = rtdm_irq_request(&irq_rtdm,
>> irq, handler_interruption,
>> 0,
>> "test", NULL)) != 0) {
>> printk("rtdm request error\n"); }
>>
>> #else
>> ret = devm_request_irq(pctrl->dev, irq, intel_gpio_irq, IRQF_SHARED,
>>dev_name(pctrl->dev), pctrl);
>> if (ret) {
>> dev_err(pctrl->dev, "failed to request interrupt\n");
>> goto fail;
>> }
>> #endif
>
> That won't work, unless you fixed up that GPIO driver to cope with interrupt
> pipelining - which does not seem to be the case.
>
> If you plan to implement those changes, please keep in mind that you won't be
> able to share a common IRQ line between multiple GPIO controllers unlike
> pinctrl-intel would originally allow for non-rt usage. The current I-pipe
> patch implementation does not support this.
>
> The code below was an attempt to adapt the pinctrl-intel driver to IRQ
> pipelining, which broke in flight due to lack of time. It is very unlikely to
> work as is, not even to build properly, I have no clue whether there is a
> slightest chance this might work, but that's a starting point...to somewhere.
>
> commit ab4493579d95de58718a8ea81ae1fffc6f2ed0f7 (wip/intel-pinctrl)
> Author: Philippe Gerum
> Date: Wed May 31 18:16:19 2017 +0200
>
> drivers: inter-pinctrl: make I-pipe aware
>
> diff --git a/drivers/pinctrl/intel/pinctrl-intel.c
> b/drivers/pinctrl/intel/pinctrl-intel.c
> index 01443762e570..f8bf54b6d485 100644
> --- a/drivers/pinctrl/intel/pinctrl-intel.c
> +++ b/drivers/pinctrl/intel/pinctrl-intel.c
> @@ -91,7 +91,11 @@ struct intel_pinctrl_context {
> */
> struct intel_pinctrl {
> struct device *dev;
> +#ifdef CONFIG_IPIPE
> + ipipe_spinlock_t lock;
> +#else
> raw_spinlock_t lock;
> +#endif
> struct pinctrl_desc pctldesc;
> struct pinctrl_dev *pctldev;
> struct gpio_chip chip;
> @@ -647,15 +651,13 @@ static const struct gpio_chip intel_gpio_chip = {
> .set = intel_gpio_set,
> };
>
> -static void intel_gpio_irq_ack(struct irq_data *d)
> +static void __intel_gpio_irq_ack(struct irq_data *d)
> {
> struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
> struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
> const struct intel_community *community;
> unsigned pin = irqd_to_hwirq(d);
>
> - raw_spin_lock(&pctrl->lock);
> -
> community = intel_get_community(pctrl, pin);
> if (community) {
> unsigned padno = pin_to_padno(community, pin); @@ -664,7
> +666,14 @@ static void intel_gpio_irq_ack(struct irq_data *d)
>
> writel(BIT(gpp_offset), community->regs + GPI_IS + gpp * 4);
> }
> +}
>
> +static void intel_gpio_irq_ack(struct irq_data *d) {
> + struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
> +
> + raw_spin_lock(&pctrl->lock);
> + __intel_gpio_irq_ack(d);
> raw_spin_unlock(&pctrl->lock);
> }
>
> @@ -694,18 +703,17 @@ static void intel_gpio_irq_enable(struct irq_data *d)
> writel(value, community->regs + community->ie_offset + gpp * 4);
> }
>
> + ipipe_unlock_irq(d->irq);
> +
> raw_spin_unlock_irqrest
Re: [Xenomai] INTR-REMAP issue while enabling GPIO interrupt as RTDM interrupt
On 06/08/2018 09:07 AM, Philippe Gerum wrote: > On 06/08/2018 07:22 AM, Yan, Hongliang wrote: >> Hi Philippe, >> May I ask why you use irq_set_chained_handler_and_data instead of >> rtdm_irq_request? It seems irq_set_chained_handler_and_data register the irq >> as ipipe_root_domain while rtdm_irq_request register the irq as >> xnsched_realtime_domain. Can we use xnsched_realtime_domain for this GPIO >> interrupt? > > That is the other way around. The rtdm* API is based on the modified > genirq core from the Linux kernel. Modifying the pinctrl driver enables > IRQ pipelining, which in turn allows rtdm* calls to interpose on the IRQ > flow for handling events in rt mode. > This may be worth a read: http://git.xenomai.org/ipipe-noarch.git/tree/Documentation/ipipe.rst -- Philippe. ___ Xenomai mailing list Xenomai@xenomai.org https://xenomai.org/mailman/listinfo/xenomai
