Re: (unknown)
On 10.04.19 17:02, Lange Norbert wrote: -Original Message- From: Jan Kiszka Sent: Mittwoch, 10. April 2019 16:48 To: Lange Norbert ; Xenomai Subject: Re: (unknown) E-MAIL FROM A NON-ANDRITZ SOURCE: AS A SECURITY MEASURE, PLEASE EXERCISE CAUTION WITH E-MAIL CONTENT AND ANY LINKS OR ATTACHMENTS. [re-adding the list] On 10.04.19 16:44, Lange Norbert wrote: -Original Message- From: Xenomai On Behalf Of Jan Kiszka via Xenomai Sent: Mittwoch, 10. April 2019 16:36 To: Norbert Lange ; xenomai@xenomai.org Subject: Re: (unknown) E-MAIL FROM A NON-ANDRITZ SOURCE: AS A SECURITY MEASURE, PLEASE EXERCISE CAUTION WITH E-MAIL CONTENT AND ANY LINKS OR ATTACHMENTS. On 10.04.19 13:14, Norbert Lange via Xenomai wrote: V3 of the patchset, corrected many checkstyle issues, simplified condvar autoinit. I did not use ARRAY_SIZE, as that would need another include. All applied now. Patch 1 was not cleanly based on next, though. I think some local style cleanup was missing. I based all patches on master, thought this is the primary development branch? Line 566 in lib/cobalt/mutex.c had a trailing tab, your patch context did not, and that made the application fail. Maybe that was removed while transporting the patch into your mail client - better use git send-email in that case. I use git send-email, you would not be happy if I sent patches over our IT Server (one or two examples should reside somewhere in the ML) =). Yeah, I fully understand. I did use git-format-patch with --ignore-space-at-eol, maybe that’s the reason. I'm pretty sure that was it. OK - one off. I know there are a few holdouts, but since you got a gitlab server and ci running already, merge-requests could do all those style checks and test for build-failures without taking any time of the maintainers and shorter feedback cycles for the contributors. My IT is rather hostile to anything email based. Unfortunately, also with gitlab, the working mode decision remains a binary one: If we start allowing MRs and do review on that platform, we need to migrate everything over. There is no integration that allows to mirror one feed into the other to avoid community split. I do quite a few gitlab-based reviews as well, for internal stuff. It's making some things easier and others more complicated for me. Tracking the history of patch series can be easier. However, reviewing larger series requires large amounts of mouse clicks, and you easily lose overview. At least, gitlab is not as broken as github (github still reorders patches according to dates - ouch). And even in times of CI, and eventually also continuous testing, review remains a manual (visual) task. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
RE: (unknown)
> -Original Message- > From: Jan Kiszka > Sent: Mittwoch, 10. April 2019 16:48 > To: Lange Norbert ; Xenomai > > Subject: Re: (unknown) > > E-MAIL FROM A NON-ANDRITZ SOURCE: AS A SECURITY MEASURE, PLEASE > EXERCISE CAUTION WITH E-MAIL CONTENT AND ANY LINKS OR ATTACHMENTS. > > > [re-adding the list] > > On 10.04.19 16:44, Lange Norbert wrote: > > > > > >> -Original Message- > >> From: Xenomai On Behalf Of Jan Kiszka > via > >> Xenomai > >> Sent: Mittwoch, 10. April 2019 16:36 > >> To: Norbert Lange ; xenomai@xenomai.org > >> Subject: Re: (unknown) > >> > >> E-MAIL FROM A NON-ANDRITZ SOURCE: AS A SECURITY MEASURE, PLEASE > >> EXERCISE CAUTION WITH E-MAIL CONTENT AND ANY LINKS OR > ATTACHMENTS. > >> > >> > >> On 10.04.19 13:14, Norbert Lange via Xenomai wrote: > >>> V3 of the patchset, corrected many checkstyle issues, simplified > >>> condvar autoinit. > >>> > >>> I did not use ARRAY_SIZE, as that would need another include. > >>> > >> > >> All applied now. Patch 1 was not cleanly based on next, though. I think > >> some > >> local style cleanup was missing. > > > > I based all patches on master, thought this is the primary development > > branch? > > > > Line 566 in lib/cobalt/mutex.c had a trailing tab, your patch context did not, > and that made the application fail. Maybe that was removed while transporting > the patch into your mail client - better use git send-email in that case. I use git send-email, you would not be happy if I sent patches over our IT Server (one or two examples should reside somewhere in the ML) =). I did use git-format-patch with --ignore-space-at-eol, maybe that’s the reason. I know there are a few holdouts, but since you got a gitlab server and ci running already, merge-requests could do all those style checks and test for build-failures without taking any time of the maintainers and shorter feedback cycles for the contributors. My IT is rather hostile to anything email based. Norbert This message and any attachments are solely for the use of the intended recipients. They may contain privileged and/or confidential information or other information protected from disclosure. If you are not an intended recipient, you are hereby notified that you received this email in error and that any review, dissemination, distribution or copying of this email and any attachment is strictly prohibited. If you have received this email in error, please contact the sender and delete the message and any attachment from your system. ANDRITZ HYDRO GmbH Rechtsform/ Legal form: Gesellschaft mit beschränkter Haftung / Corporation Firmensitz/ Registered seat: Wien Firmenbuchgericht/ Court of registry: Handelsgericht Wien Firmenbuchnummer/ Company registration: FN 61833 g DVR: 0605077 UID-Nr.: ATU14756806 Thank You
Re: (unknown)
[re-adding the list] On 10.04.19 16:44, Lange Norbert wrote: -Original Message- From: Xenomai On Behalf Of Jan Kiszka via Xenomai Sent: Mittwoch, 10. April 2019 16:36 To: Norbert Lange ; xenomai@xenomai.org Subject: Re: (unknown) E-MAIL FROM A NON-ANDRITZ SOURCE: AS A SECURITY MEASURE, PLEASE EXERCISE CAUTION WITH E-MAIL CONTENT AND ANY LINKS OR ATTACHMENTS. On 10.04.19 13:14, Norbert Lange via Xenomai wrote: V3 of the patchset, corrected many checkstyle issues, simplified condvar autoinit. I did not use ARRAY_SIZE, as that would need another include. All applied now. Patch 1 was not cleanly based on next, though. I think some local style cleanup was missing. I based all patches on master, thought this is the primary development branch? Line 566 in lib/cobalt/mutex.c had a trailing tab, your patch context did not, and that made the application fail. Maybe that was removed while transporting the patch into your mail client - better use git send-email in that case. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
Re: (unknown)
On 10.04.19 13:14, Norbert Lange via Xenomai wrote: V3 of the patchset, corrected many checkstyle issues, simplified condvar autoinit. I did not use ARRAY_SIZE, as that would need another include. All applied now. Patch 1 was not cleanly based on next, though. I think some local style cleanup was missing. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
Re: (unknown)
On 10.04.19 13:17, Norbert Lange via Xenomai wrote: V2 of the patchset. Fixed checkstyle issues, better identation, and aded casts to silence (false) pedantic warnings. Both applied to next, thanks. You probably want to edit your cover letter subject as well - or use git format-patch. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
Re: (unknown)
On 10.04.19 13:14, Norbert Lange via Xenomai wrote: V3 of the patchset, corrected many checkstyle issues, simplified condvar autoinit. Thanks for the update! I did not use ARRAY_SIZE, as that would need another include. Ah, we do not have this construct in lib/ so far. There are private ARRAY_LEN macros in lib/analogy/calibration.c and utils/analogy/analogy_calibrate.h. Well, something that can be consolidates later. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
