[Xenomai-core] [PULL REQUEST] analogy: bug fixes in buffer size config
The following changes since commit c0993894a7ab56d9c3f5444e90e68602673288de: 16550A: Disable PCI configuration option for platforms without PCI (2011-01-08 01:05:02 +0100) are available in the git repository at: ssh+git://git.xenomai.org/xenomai-abe.git analogy Alexis Berlemont (5): analogy: fix the default size of the buffer analogy: [pcimio] minor fix in log messages analogy: implement configuration of buffer default size analogy: add a sys function for the ioctl BUFCONFIG analogy: add buffer configuration facility in analogy_config include/analogy/analogy.h|2 + include/analogy/buffer.h |8 + include/analogy/transfer.h |3 + include/analogy/types.h |4 +- ksrc/drivers/analogy/buffer.c| 17 +- ksrc/drivers/analogy/national_instruments/mite.c |2 +- ksrc/drivers/analogy/rtdm_interface.c| 10 +- ksrc/drivers/analogy/transfer.c |4 + src/drvlib/analogy/async.c |9 +- src/drvlib/analogy/sys.c | 33 +++ src/utils/analogy/analogy_config.c | 241 ++ 11 files changed, 223 insertions(+), 110 deletions(-) -- Alexis. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy bug fixes
Hi, Gilles Chanteperdrix wrote: Alexis Berlemont wrote: The following changes since commit 653a38669af4427471ed8cdd129eb0bbb33ba178: nucleus: finalize heap mapping sanitization (2010-07-04 18:57:54 +0200) Ok. Could you rebase on the current master? The commit message would be: Update autotools files Sorry for the delay. That should be better now. -- Gilles. -- Alexis. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
[Xenomai-core] [PULL REQUEST] analogy bug fixes
The following changes since commit 653a38669af4427471ed8cdd129eb0bbb33ba178: nucleus: finalize heap mapping sanitization (2010-07-04 18:57:54 +0200) are available in the git repository at: git://git.xenomai.org/xenomai-abe.git analogy ..BRANCH.NOT.VERIFIED.. Alexis Berlemont (48): analogy: change the context's role (broken) analogy: the buffer structure is now the central field of a4l_context (broken) analogy: the subdevice structure got a new status field (broken) analogy: the transfer structure is left with a minimal role (broken) analogy: first draft of buffer initialization functions (broken) analogy: adapt open, r/w, select and ioctl functions (broken) analogy: adapt a4l_set_dev() after a4l_context's overhaul (broken) analogy: update a4l_set_dev() declaration (broken) analogy: update comments on a4l_context (broken) analogy: changes related with subdevice's status field (broken) analogy: replace transfer setup functions with buffer setup ones (broken) analogy: update cancel functions (broken) analogy: rewrite the cancel ioctl handler (broken) analogy: fix bulk flag declaration in buffer.h (broken) analogy: update a4l_read and a4l_write (broken) analogy: update all a4l_buf_* functions (broken) analogy: last updates in the buffer part (broken) analogy: cosmetic changes (broken) analogy: declare the reserve / release functions at the subd level (broken) analogy: update a4l_get_minor function (broken) analogy: update a4l_set_dev and remove useless info traces (broken) analogy: use rtdm_context_to_private (broken) analogy: minor fix in the subdevice structure declaration analogy: add some helper macros to test the subdevice's characteristics analogy: remove useless functions in the subdevice part analogy: fix the buffer syscalls (ioctl + r/w) after buffer review (broken) analogy: fix the declaration of the structure a4l_context (broken) analogy: fix compilation issues and review the mmap ioctl handler (broken) analogy: cosmetic change (broken) analogy: fix buffer's compilation issues (broken) analogy: prettify some subdevice tests (broken) analogy: [pcimio] fix a huge hack in the mite initialization (broken) analogy: fix the last compilation problems analogy: fix a missing setting of the buf field in subdevice (broken) analogy: fix the subdevice status management analogy: fix buffer initialization/cleanup calls at open/close times analogy: [loop] add a debug trace when trigger is called analogy: fix test of subdevice status in a4l_write analogy: [fake - loop] remove volatile keywords analogy: add a detail in a4l_close doxygen doc analogy: add an arbitrary sleep in cmd_write before closing the device analogy: [ni_pcimio] really minor changes analogy: [ni_pcimio] add the missing allocation of the digital ring analogy: [ni_pcimio] fix timeout value in digital trigger analogy: remove a4l_subd_is_busy calls in analogy core analogy: remove calls of a4l_release/reserve_subd in the core analogy: remove some tests which become with the buffer overhaul analogy: fix a bug in a4l_fill_desc() when called on an idle device include/analogy/buffer.h | 72 ++- include/analogy/context.h | 37 +- include/analogy/device.h |7 +- include/analogy/subdevice.h| 47 ++- include/analogy/transfer.h | 17 +- ksrc/drivers/analogy/buffer.c | 629 +++- ksrc/drivers/analogy/command.c | 55 +- ksrc/drivers/analogy/device.c | 51 +-- ksrc/drivers/analogy/driver_facilities.c |4 +- ksrc/drivers/analogy/instruction.c | 11 +- .../analogy/national_instruments/mio_common.c | 39 +- ksrc/drivers/analogy/national_instruments/mite.c | 10 +- ksrc/drivers/analogy/national_instruments/mite.h |2 +- ksrc/drivers/analogy/national_instruments/pcimio.c |2 + ksrc/drivers/analogy/rtdm_interface.c | 137 +++--- ksrc/drivers/analogy/subdevice.c | 12 +- ksrc/drivers/analogy/testing/fake.c| 12 +- ksrc/drivers/analogy/testing/loop.c| 22 +- ksrc/drivers/analogy/transfer.c| 274 + src/drvlib/analogy/descriptor.c| 14 + src/utils/analogy/cmd_write.c |3 + 21 files changed, 655 insertions(+), 802 deletions(-) -- Alexis. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy bug fixes + rtdm_rt_capable related changes
Alexis Berlemont wrote: The following changes since commit e9b509c9021e0134117d0fe75d11e495f0e954b7: arm: add missing #include (2010-05-04 03:44:01 +0200) are available in the git repository at: git://git.xenomai.org/xenomai-abe.git analogy Pulled, thanks. -- Gilles. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
[Xenomai-core] [PULL REQUEST] analogy bug fixes + rtdm_rt_capable related changes
The following changes since commit e9b509c9021e0134117d0fe75d11e495f0e954b7: arm: add missing #include (2010-05-04 03:44:01 +0200) are available in the git repository at: git://git.xenomai.org/xenomai-abe.git analogy Alexis Berlemont (17): analogy: fix ring-buffer issues analogy: cosmetic fix analogy: fix buffer checkings so as to allow infinite acquisitions analogy: make cmd_read work with infinite acquisitions (-S 0) analogy: fix a misuse of channel descriptors in a4l_get_chan analogy: [pcimio] register the digital trigger routine analogy: minor change in the header command.h analogy: minor cosmetic fix analogy: add the test program cmd_bits (beta version) analogy: minor fix in insn_bits analogy: add triggering in cmd_bits analogy: in the core, call rtdm_in_rt_context() instead of a4l_test_rt() analogy: add calls to rtdm_rt_capable() in ioctl handlers analogy: remove useless device declarations in read / write syscalls handlers analogy: add rtdm_rt_capable() calls in read / write syscall handlers analogy: fix a stupid bug in the use of rtdm_rt_capable() analogy: make the command registering perform in NRT context Daniele Nicolodi (2): analogy: make a4l_find_range return the index of the selected range analogy: minor change (white spaces removals) include/analogy/buffer.h | 37 ++-- include/analogy/command.h | 15 +- ksrc/drivers/analogy/buffer.c | 57 +++-- ksrc/drivers/analogy/command.c |6 + ksrc/drivers/analogy/device.c |2 +- ksrc/drivers/analogy/instruction.c |6 + .../analogy/national_instruments/mio_common.c | 18 +- ksrc/drivers/analogy/rtdm_interface.c | 10 +- ksrc/drivers/analogy/subdevice.c |6 +- ksrc/drivers/analogy/transfer.c| 10 +- src/drvlib/analogy/range.c | 64 +++-- src/utils/analogy/Makefile.am | 10 +- src/utils/analogy/cmd_bits.c | 277 src/utils/analogy/cmd_read.c |6 +- src/utils/analogy/insn_bits.c |2 +- 15 files changed, 425 insertions(+), 101 deletions(-) create mode 100644 src/utils/analogy/cmd_bits.c -- Alexis. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes
Alexis Berlemont wrote: There is a bug in cmd_write and cmd_read. I have should have taken into account the buffers edges. I will fix it. The function a4l_mark_bufrw() is not designed to handle boundaries, that is why its arguments represent data size not addresses. That makes sense. I can provide a patch for cmd_read and cmd_write, as i got the same kind of code working in my own test programs, but I'm quite busy right now... Cheers, -- Daniele ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes
Daniele Nicolodi wrote: Alexis Berlemont wrote: If you want to test infinite acquisitions right now, you can clone my git repository. I just pushed the modifications on it. I have not made a pull request yet because I want to be sure there is no regression. Thanks! I'll test it as soon as possible. I'm testing it now. I think I just stumbled into the ring buffer bug you fixed in your repository :-) It took me a while to understand if the problem was in the hardware, in my code, or somewhere else in the stack... Unfortunately my ring buffer problem is not fixed by you patch. What I'm experiencing is exposed by this (pseudo) code: a4l_open(dsc, device) a4l_mmap(dsc, subdevice, bufsize, map) a4l_snd_command(dsc, cmd) /* preload buffer */ written = write_to_buffer(map, bufsize) /* send internal trigger */ a4l_snd_insn(dsc, cnt = 0; while (1) a4l_mark_bufrw(dsc, subdevice, written, towrite); cnt += written; /* 1 */ written = write_buffer(map + (cnt % bufsize), towrite) The problem is that at the place marked with (1) the total extension of the buffer region that gets written exceeds the ring buffer allocated memory. That is ((cnt % bufsize) + towrite) bufsize ! I do not know if this should be handled in my code, or in the driver. This situation is not handled in the cmd_write example code (where a simple memcpy() is done). What do you think? Cheers, -- Daniele ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes
Alexis Berlemont wrote: Daniele Nicolodi wrote: Alexis Berlemont wrote: The following changes since commit 8cfc1103fe1cf9e700698e8230baf562ffb5cf06: Gilles Chanteperdrix (1): x86 syscalls: make __xn_get_eip a macro are available in the git repository at: git://git.xenomai.org/xenomai-abe.git analogy Hello. Looking at your pull request, I see that my patch for correct buffer handling when using .stop_src = TRIG_NONE is not included. Does the patch need some more work? Or it simply get lost on the way? I have not forgotten it. I did not include it for two reasons: - I have not found time to (fully) test it - I wanted to properly modify the test program cmd_read so as to allow continuous acquisisitions Hi Alexis. Sorry for the late response. That's fine, I just wanted to be sure that the patch was not dropped by mistake. I'll test continuous output today and let you know if any other bugfix is necessary. I can also look into providing a patch for cmd_read and cmd_write. Cheers, -- Daniele ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes
Daniele Nicolodi wrote: Alexis Berlemont wrote: The following changes since commit 8cfc1103fe1cf9e700698e8230baf562ffb5cf06: Gilles Chanteperdrix (1): x86 syscalls: make __xn_get_eip a macro are available in the git repository at: git://git.xenomai.org/xenomai-abe.git analogy Hello. Looking at your pull request, I see that my patch for correct buffer handling when using .stop_src = TRIG_NONE is not included. Does the patch need some more work? Or it simply get lost on the way? I have not forgotten it. I did not include it for two reasons: - I have not found time to (fully) test it - I wanted to properly modify the test program cmd_read so as to allow continuous acquisisitions Thanks. Cheers, -- Daniele -- Alexis. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes
Alexis Berlemont wrote: The following changes since commit 8cfc1103fe1cf9e700698e8230baf562ffb5cf06: Gilles Chanteperdrix (1): x86 syscalls: make __xn_get_eip a macro are available in the git repository at: git://git.xenomai.org/xenomai-abe.git analogy Hello. Looking at your pull request, I see that my patch for correct buffer handling when using .stop_src = TRIG_NONE is not included. Does the patch need some more work? Or it simply get lost on the way? Thanks. Cheers, -- Daniele ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes + insn_bits
Alexis Berlemont wrote: The following changes since commit 4a5b93dabf66529e665c8f8422902347d4f6158f: Jan Kiszka (1): RTDM: Split up application and driver debugging are available in the git repository at: git://git.xenomai.org/xenomai-abe.git analogy Merged. -- Gilles. ___ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
