Re: [xml] [PATCH] always dllexport the singlethreaded variables

[Nick Wellnhofer]

On 25/05/2018 17:46, Michael Haubenwallner wrote:

When an application using libxml2 does not enable multithreaded support
for itself, we provide the singlethreaded variables, eventually tagged
with dllimport.  So even when we build the multithreaded libxml2, our
singlethreaded variables still eventually need the dllexport tag.


I don't understand the issue. Do you mean an application linked with a DLL 
configured without thread support and compiled with single-thread headers, and 
THEN swapping the DLL with a multi-thread version? I'm not sure whether this 
should be supported.


Nick
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] [PATCH] really declare dllexport/dllimport for Cygwin

[Nick Wellnhofer]

Thanks, patch applied here:

https://gitlab.gnome.org/GNOME/libxml2/commit/c65c9e8ee07e2dab0647392c2bd1795a5bc99829


On 25/05/2018 17:46, Michael Haubenwallner wrote:

Cygwin does not define _WIN32, but still requires dllexport/dllimport
tags for when applications use the --disable-auto-import linker flag,
probably set by the gl_WOE32_DLL autoconf macro in woe32-dll.m4 file.
---
  include/libxml/xmlexports.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/libxml/xmlexports.h b/include/libxml/xmlexports.h
index 2c79f814..bc8a90d4 100644
--- a/include/libxml/xmlexports.h
+++ b/include/libxml/xmlexports.h
@@ -131,8 +131,8 @@
#endif
  #endif
  
-/* Cygwin platform, GNU compiler */

-#if defined(_WIN32) && defined(__CYGWIN__)
+/* Cygwin platform (does not define _WIN32), GNU compiler */
+#if defined(__CYGWIN__)
#undef XMLPUBFUN
#undef XMLPUBVAR
#undef XMLCALL


___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml