Re: [xml] Entering freeze for release of libxml2-2.9.9
On Fri, 23 Nov 2018 23:12:13 +0100 Nick Wellnhofer wrote: > On 23/11/2018 22:38, Nick Wellnhofer wrote: > > On 23/11/2018 20:51, Shlomi Fish wrote: > >> I am getting a failure in one of the tests of > >> https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8: > > > > Can you check if it's caused by one of the following commits? > > Nevermind, it's this commit: > > https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c > > It seems that XML::LibXML implements its own workaround for > xmlTextReaderNextSibling only being supported on preparsed documents: > > https://github.com/shlomif/perl-XML-LibXML/blob/master/LibXML.xs#L8667 > > The function now claims to work without preparsed documents, so the > workaround isn't used. But apparently there's problem with the commit. I'm > CC'ing the author. If we can't get this fixed, let's revert. > > Nick thanks for investigating! -- - Shlomi Fish http://www.shlomifish.org/ http://www.shlomifish.org/humour/bits/facts/Emma-Watson/ Xena the warrior princess can meet King David for breakfast and Julius Caesar for lunch. Without time travel. — http://www.shlomifish.org/humour/bits/facts/Xena/ Please reply to list if it's a mailing list post - http://shlom.in/reply . ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Entering freeze for release of libxml2-2.9.9
On 24/11/2018 14:01, Daniel Veillard via xml wrote: Nick there seems to be 7 merge requests, maybe we need to go though those before I push an RC2, https://gitlab.gnome.org/GNOME/libxml2/merge_requests/5 This should be kept externally, IMO. https://gitlab.gnome.org/GNOME/libxml2/merge_requests/7 Also see the discussion in issue #2. I'd simply document that xmlInitGlobals shouldn't be called from application code. https://gitlab.gnome.org/GNOME/libxml2/merge_requests/8 I added a hardcoded newline separator which should be enough for now. https://gitlab.gnome.org/GNOME/libxml2/merge_requests/9 Should be discussed on this list first. Personally, I'm in favor of adding CMake support (as an option). In the long run, it could replace the weird Win32 build system with something more standard. https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10 That's Nikolas's merge request. https://gitlab.gnome.org/GNOME/libxml2/merge_requests/11 Trivial. https://gitlab.gnome.org/GNOME/libxml2/merge_requests/12 Looks good but I didn't have time to review properly. Nick ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Entering freeze for release of libxml2-2.9.9
Hi! Daniel Veillard, 2018-11-24 14:01: On Sat, Nov 24, 2018 at 12:14:06AM +0100, Nikolai Weibull wrote: Daniel Veillard via xml, 2018-11-22 18:32: > I have just tagged the Release Candidate 1 in git and > pushed a > signed > tarball and signed rpms to the usual place: Could we please get merge request 10 into https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10 Okay that looks different from the other patch for interleaves I applied earlier. Could you provide a little bit more description, seems it avoid creating a choice child of a choice element among other things, correct ? Yes, it is. I did provide some documentation in the commits, see below. They’re available in gitlab as well, but it’s not obvious how to show them (you press the … after the commit subject line). If you want more, I’ll try to expand on them. 0d0ad65b: Remove redefined starts and defines inside include elements When including a grammar from another grammar, we need to make sure that any redefines of starts and includes that that grammar does inside any of its include elements are also removed. 4f5d2b9b: Allow choice within choice in nameClass in RELAX NG The pattern nameClass allows for nested choice elements, for example a b c which is semantically equivalent to a b c The old code didn’t handle this correctly, as it never expected a choice inside another choice. This patch fixes this by flattening any nested choices. This pattern of nested choice elements comes up in RELAX NG simplification, where all choice elements are rewritten in this nested manner, see section 4.12 of the RELAX NG specification. 3cf2a68b: Look inside divs for starts and defines inside include RELAX NG allows for div elements inside of include elements. We need to look inside those div elements for start and define elements that may be redefining start and define elements in the included grammar. this release? It fixes various issues with the RELAX NG code and it even has tests! I have never been fond of the github interface and it seems gitlab is kind of mimicking it, In general I will fetch the raw patch, make sure this applies to master and make sure all commits are linear (c.f. from a gitk viewpoint). Nick there seems to be 7 merge requests, maybe we need to go though those before I push an RC2, Neither have I, I just saw that there were a bunch of merge requests already, so I figured that that was the way to go. I’ll post to the mailing list in the future. If you’d like for me to send the above patches to the mailing list instead, I’ll gladly do that as well. thanks for raising this Nikolai, and for your contributions :-) No problem, it has been fun. I’ve got a couple of more minor patches, but I don’t know if I have time to get them out (or if I want to bother you with more patches right before release). ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Entering freeze for release of libxml2-2.9.9
On Sat, Nov 24, 2018 at 12:14:06AM +0100, Nikolai Weibull wrote: > Hi! > > Daniel Veillard via xml, 2018-11-22 18:32: > > > I have just tagged the Release Candidate 1 in git and pushed a > > signed > > tarball and signed rpms to the usual place: > > Could we please get merge request 10 into > > https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10 Okay that looks different from the other patch for interleaves I applied earlier. Could you provide a little bit more description, seems it avoid creating a choice child of a choice element among other things, correct ? > this release? It fixes various issues with the RELAX NG code and it even > has tests! I have never been fond of the github interface and it seems gitlab is kind of mimicking it, In general I will fetch the raw patch, make sure this applies to master and make sure all commits are linear (c.f. from a gitk viewpoint). Nick there seems to be 7 merge requests, maybe we need to go though those before I push an RC2, thanks for raising this Nikolai, and for your contributions :-) Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/ ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
