[PATCH] Removal of a needless null statement
Hi,
This patch removes an unnecessary null statement from xserver master.
Fernando Carrijo.
diff --git a/dix/events.c b/dix/events.c
index dad786d..632c0f4 100644
--- a/dix/events.c
+++ b/dix/events.c
@@ -323,7 +323,7 @@ IsPointerDevice(DeviceIntPtr dev)
_X_EXPORT Bool
IsKeyboardDevice(DeviceIntPtr dev)
{
-return (dev->key && dev->kbdfeed) && !IsPointerDevice(dev);;
+return (dev->key && dev->kbdfeed) && !IsPointerDevice(dev);
}
static void DoEnterLeaveEvents(
--
1.5.6.3
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Removal of a needless null statement
> "Fernando" == Fernando Carrijo <[EMAIL PROTECTED]> writes: Fernando> This patch removes an unnecessary null statement from xserver master. Thanks for the report. I found several others and did a general s/;;$/;/. Pushed in commit b3c7e62664457a3802ebc23785446051624a8c2f. -JimC -- James Cloos <[EMAIL PROTECTED]> OpenPGP: 1024D/ED7DAEA6 ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Removal of a needless null statement
... and there are still others. XCB and libX11, to list a few! On Sat, 2008-11-08 at 12:23 -0500, James Cloos wrote: > > "Fernando" == Fernando Carrijo <[EMAIL PROTECTED]> writes: > > Fernando> This patch removes an unnecessary null statement from xserver > master. > > Thanks for the report. I found several others and did a general s/;;$/;/. > > Pushed in commit b3c7e62664457a3802ebc23785446051624a8c2f. > > -JimC ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Removal of a needless null statement
> "Fernando" == Fernando Carrijo <[EMAIL PROTECTED]> writes: Fernando> ... and there are still others. XCB and libX11, to list a few! Yes, we have to look in the other repos as well. Git grep makes is relatively easy, but only works one repo at a time. I'll get the ones in app and lib, but I lack commit privs on XCB and don't want to step on any toes for the drivers. The affected drivers are: xf86-input-digitaledge xf86-input-hyperpen xf86-input-summa xf86-video-ast xf86-video-cyrix xf86-video-i128 xf86-video-i740 xf86-video-intel xf86-video-nsc xf86-video-savage xf86-video-sis xf86-video-sisusb xf86-video-ati -JimC -- James Cloos <[EMAIL PROTECTED]> OpenPGP: 1024D/ED7DAEA6 ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Removal of a needless null statement
>> "Fernando" == Fernando Carrijo <[EMAIL PROTECTED]> writes:
>
> Fernando> ... and there are still others. XCB and libX11, to list a few!
>
> Yes, we have to look in the other repos as well. Git grep makes is
> relatively easy, but only works one repo at a time.
>
> I'll get the ones in app and lib, but I lack commit privs on XCB and
> don't want to step on any toes for the drivers.
>
> The affected drivers are:
>
> xf86-input-digitaledge xf86-input-hyperpen xf86-input-summa
> xf86-video-ast xf86-video-cyrix xf86-video-i128 xf86-video-i740
> xf86-video-intel xf86-video-nsc xf86-video-savage xf86-video-sis
> xf86-video-sisusb xf86-video-ati
I remember there were also a few cases of code like:
#define macro(object) (object)->field;
that would generate warnings of mixed code and declarations, as these
macros were used in code like:
type
function(arguments)
{
type variable = macro(object);
type other_variable;
...
}
> -JimC
Paulo
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Removal of a needless null statement
> "Paulo" == Paulo César Pereira de Andrade <[EMAIL PROTECTED]> writes: Paulo> I remember there were also a few cases of code like: Paulo> #define macro(object) (object)->field; Paulo> that would generate warnings of mixed code and declarations Indeed. There was one instance of which I was initially unsure, but a quick audit of similar usage showed that the doubled semis should be superfluous. -JimC -- James Cloos <[EMAIL PROTECTED]> OpenPGP: 1024D/ED7DAEA6 ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
