Re: [Q] Xorg VNC driver?

2009-10-01 Thread Pat Kane
  git clone git://xf4vnc.git.sourceforge.net/gitroot/xf4vnc/xserver

Thanks!   I was able  clone your tree without any trouble.
I've got a 1.7-ish version that mostly works -- until I move the pointer.
(Looks like the events argument to GetPointerEvents has changed).

Another problem is that window borders are not visible until the Xvnc
screen is refreshed, rfbPaintWindowBorder is not being called.
That used to be done in   mi/miwindow.c  miHandleValidateExposures(..)
like this:
   (*pScreen-PaintWindowBorder)(pWin,
val-after.borderExposed,
PW_BORDER);

but that code has been removed[1].   Does anyone know what needs to be
done to get window borders to appear?

Pat
---
[1] I added the lines back and borders are again visible, what will that
 break?  Composite maybe?





On Wed, Sep 30, 2009 at 4:30 AM, Alan Hourihane al...@fairlite.co.uk wrote:
 I've just exported a new git repository for the xf4vnc project. It just
 covers the xserver component at the moment.

 It's available at

 git clone git://xf4vnc.git.sourceforge.net/gitroot/xf4vnc/xserver

 I've briefly tested it and it seems to work, but I've not done anything
 extensive.

 Let me know how you get on.

 Thanks,

 Alan.


___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2009-09-29 Thread Peter Hutterer
On Wed, Sep 23, 2009 at 02:33:24PM -0500, Pat Kane wrote:
 On Wed, Sep 23, 2009 at 8:46 AM, Matthias Hopf mh...@suse.de wrote:
 
  On Sep 23, 09 08:09:58 -0500, Pat Kane wrote:
   Has anyone  ported xf4vnc to xorg-server  1.7 (1.6.99)?
  Sorry, porting was only to 1.6.3.901 (just noted that). However, they
  will probably a good start.
 
 They provide a very good staring point and  have saved me a lot of
 work, thank you.
 
 I think the the mouse init code, init.c, needs to look somthing like
 the attached snippet
  of code (sorry I can not make patches yet).  Does that look right?
 
 I am lookig forward to having the code in a git repo.
 
 Pat
 ---

 ...
 
 static int
 rfbMouseProc(pDevice, onoff)
 DeviceIntPtr pDevice;
 int onoff;
 {
 #define NBUTTONS 3
 #define NAXES 2
 BYTE map[NBUTTONS + 1];
 Atom btn_labels[NBUTTONS] = {0};
 Atom axes_labels[NAXES] = {0};
 DevicePtr pDev = (DevicePtr)pDevice;
 
 switch (onoff)
 {
 case DEVICE_INIT:
   PtrDeviceInit();
 map[1] = 1;
 map[2] = 2;
 map[3] = 3;
 
 btn_labels[0] = XIGetKnownProperty(BTN_LABEL_PROP_BTN_LEFT);
 btn_labels[1] = XIGetKnownProperty(BTN_LABEL_PROP_BTN_MIDDLE);
 btn_labels[2] = XIGetKnownProperty(BTN_LABEL_PROP_BTN_RIGHT);
 
 axes_labels[0] = XIGetKnownProperty(AXIS_LABEL_PROP_REL_X);
 axes_labels[1] = XIGetKnownProperty(AXIS_LABEL_PROP_REL_Y);
 
 
   if (! InitPointerDeviceStruct(pDev, map, 
   NBUTTONS, btn_labels,
   (PtrCtrlProcPtr)NoopDDA, 
   GetMotionHistorySize(), 
   NAXES, axes_labels))
 {
 ErrorF(Could not initialize device '%s'. Out of memory.\n,
pDev-name);
 return BadAlloc; /* IPDS only fails on allocs */
 }
 pDev-valuator-axisVal[0] = screenInfo.screens[0]-width / 2;
 pDev-last.valuators[0]= pDev-valuator-axisVal[0];
 pDev-valuator-axisVal[1] = screenInfo.screens[0]-height / 2;
 pDev-last.valuators[1]= pDev-valuator-axisVal[1];
 
 vncSetPointerDevice(pDevice);
   break;
 
 case DEVICE_ON:
 
   ...

yep, this is the standard snippet for devices that are fixed (LMR buttons
and 2 rel axes).

Cheers,
  Peter
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2009-09-29 Thread Peter Hutterer
On Tue, Sep 29, 2009 at 05:59:34PM +0200, Matthias Hopf wrote:
 On Sep 23, 09 14:33:24 -0500, Pat Kane wrote:
  On Wed, Sep 23, 2009 at 8:46 AM, Matthias Hopf mh...@suse.de wrote:
   Sorry, porting was only to 1.6.3.901 (just noted that). However, they
   will probably a good start.
  They provide a very good staring point and  have saved me a lot of
  work, thank you.
  
  I think the the mouse init code, init.c, needs to look somthing like
  the attached snippet
   of code (sorry I can not make patches yet).  Does that look right?
 
 It doesn't look wrong (though I'm unsure how z axis i.e. mouse wheel is
 handled, and in the code I can only see handling of 3 buttons and 2
 axes), but I'm not exactly fluent in that area.

if the driver posts wheels as buttons 4/5 the server will ignore them if it
isn't set up. So the previous snippet is correct though without mouse
wheel support.

To get the wheel support, just inc NBUTTONS to 7 and set it up with the
labels BTN_LABEL_PROP_BTN_WHEEL_UP, BTN_LABEL_PROP_BTN_WHEEL_DOWN,
BTN_LABEL_PROP_BTN_HWHEEL_LEFT, BTN_LABEL_PROP_BTN_HWHEEL_RIGHT.

Note that button labelling is still optional, a label of 0 is permitted.
Labels are a hint to clients so they know what a given button does. For any
button from 1-7 labels are arguably superfluous since we can't change much
anyway - too many clients rely on the current behaviour.

Cheers,
  Peter
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2009-09-23 Thread Pat Kane
Has anyone  ported xf4vnc to xorg-server  1.7 (1.6.99)?

After a quick look I see that the following needs to be done:

   1) calls to TryClientEvents in cutpaste.c  vncext.c
  need to be fixed.

   2) calls to  AddInputDevice, InitKeyboardDeviceStruct and
  InitPointerDeviceStruct in init.c need to be fixed.

what else needs to be done?

Pat
---





On Fri, Dec 5, 2008 at 12:53 PM, Alan Hourihane al...@fairlite.co.ukwrote:

 On Fri, 2008-12-05 at 11:37 -0600, Pat Kane wrote:
  Does anyone know of a loadable VNC driver for Xorg 1.5?
 
  What would it take to create such a thing?
 
  Would I need to create both an input driver and a
  video driver, or could I get by with one hybred beastie?

 Hi Pat,

 Check out xf4vnc.sf.net

 Alan.


___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Re: [Q] Xorg VNC driver?

2009-09-23 Thread Alan Hourihane
On Wed, 2009-09-23 at 08:09 -0500, Pat Kane wrote:
 Has anyone  ported xf4vnc to xorg-server  1.7 (1.6.99)?
 
 After a quick look I see that the following needs to be done:
 
1) calls to TryClientEvents in cutpaste.c  vncext.c  
   need to be fixed.
 
2) calls to  AddInputDevice, InitKeyboardDeviceStruct and 
   InitPointerDeviceStruct in init.c need to be fixed.
 
 what else needs to be done?

When 1.7 is tagged for release I'll import that into xf4vnc and fixup
accordingly.

If you have any patches in the mean time, send 'em along.

Thanks,

Alan.

___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2009-09-23 Thread Matthias Hopf
On Sep 23, 09 08:09:58 -0500, Pat Kane wrote:
 Has anyone  ported xf4vnc to xorg-server  1.7 (1.6.99)?

Sorry, porting was only to 1.6.3.901 (just noted that). However, they
will probably a good start.

Matthias

-- 
Matthias Hopf mh...@suse.de  ____   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__  m...@mshopf.de
Phone +49-911-74053-715   __)  |_|  __)  |__  R  D   www.mshopf.de
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2009-09-23 Thread Alan Hourihane
On Wed, 2009-09-23 at 15:46 +0200, Matthias Hopf wrote:
 On Sep 23, 09 08:09:58 -0500, Pat Kane wrote:
  Has anyone  ported xf4vnc to xorg-server  1.7 (1.6.99)?
 
 Sorry, porting was only to 1.6.3.901 (just noted that). However, they
 will probably a good start.

Thanks Matthias,

I'll get 1.6 imported and bring these in.

Alan.

___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2009-09-23 Thread Dan Nicholson
On Wed, Sep 23, 2009 at 7:19 AM, Alan Hourihane al...@fairlite.co.uk wrote:
 On Wed, 2009-09-23 at 07:00 -0700, Dan Nicholson wrote:
 On Wed, Sep 23, 2009 at 6:20 AM, Alan Hourihane al...@fairlite.co.uk wrote:
 
  When 1.7 is tagged for release I'll import that into xf4vnc and fixup
  accordingly.

 Alan,

 Have you given any thought to moving xf4vnc into git repos? It would
 make the merging much simpler, and it would allow others to keep up
 with xorg master much easier. Obviously, it's your project, but it
 would seem like a big win.

 Now that SF has git, I'll do that.

 I'll let you know when it's done.

Great. To facilitate merging with xorg-server, you may want to have
the server in it's own repository. If you want to pursue that, the
git-split script can be used to split the repo and keep history.

http://people.freedesktop.org/~jamey/git-split
http://github.com/rjp/git-split

--
Dan
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2009-09-23 Thread Pat Kane
On Wed, Sep 23, 2009 at 8:46 AM, Matthias Hopf mh...@suse.de wrote:

 On Sep 23, 09 08:09:58 -0500, Pat Kane wrote:
  Has anyone  ported xf4vnc to xorg-server  1.7 (1.6.99)?
 Sorry, porting was only to 1.6.3.901 (just noted that). However, they
 will probably a good start.

They provide a very good staring point and  have saved me a lot of
work, thank you.

I think the the mouse init code, init.c, needs to look somthing like
the attached snippet
 of code (sorry I can not make patches yet).  Does that look right?

I am lookig forward to having the code in a git repo.

Pat
---
...

static int
rfbMouseProc(pDevice, onoff)
DeviceIntPtr pDevice;
int onoff;
{
#define NBUTTONS 3
#define NAXES 2
BYTE map[NBUTTONS + 1];
Atom btn_labels[NBUTTONS] = {0};
Atom axes_labels[NAXES] = {0};
DevicePtr pDev = (DevicePtr)pDevice;

switch (onoff)
{
case DEVICE_INIT:
PtrDeviceInit();
map[1] = 1;
map[2] = 2;
map[3] = 3;

btn_labels[0] = XIGetKnownProperty(BTN_LABEL_PROP_BTN_LEFT);
btn_labels[1] = XIGetKnownProperty(BTN_LABEL_PROP_BTN_MIDDLE);
btn_labels[2] = XIGetKnownProperty(BTN_LABEL_PROP_BTN_RIGHT);

axes_labels[0] = XIGetKnownProperty(AXIS_LABEL_PROP_REL_X);
axes_labels[1] = XIGetKnownProperty(AXIS_LABEL_PROP_REL_Y);


if (! InitPointerDeviceStruct(pDev, map, 
  NBUTTONS, btn_labels,
  (PtrCtrlProcPtr)NoopDDA, 
  GetMotionHistorySize(), 
  NAXES, axes_labels))
{
ErrorF(Could not initialize device '%s'. Out of memory.\n,
   pDev-name);
return BadAlloc; /* IPDS only fails on allocs */
}
pDev-valuator-axisVal[0] = screenInfo.screens[0]-width / 2;
pDev-last.valuators[0]= pDev-valuator-axisVal[0];
pDev-valuator-axisVal[1] = screenInfo.screens[0]-height / 2;
pDev-last.valuators[1]= pDev-valuator-axisVal[1];

vncSetPointerDevice(pDevice);
break;

case DEVICE_ON:

  ...
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

[Q] Xorg VNC driver?

2008-12-05 Thread Pat Kane
Does anyone know of a loadable VNC driver for Xorg 1.5?

What would it take to create such a thing?

Would I need to create both an input driver and a
video driver, or could I get by with one hybred beastie?


Pat
---
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: [Q] Xorg VNC driver?

2008-12-05 Thread Alan Hourihane
On Fri, 2008-12-05 at 11:37 -0600, Pat Kane wrote:
 Does anyone know of a loadable VNC driver for Xorg 1.5?
 
 What would it take to create such a thing?
 
 Would I need to create both an input driver and a
 video driver, or could I get by with one hybred beastie?

Hi Pat,

Check out xf4vnc.sf.net

Alan.

___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg