Current tinderbox regression (libX11)

[Chris Ball]

http://tinderbox.x.org/builds/2009-02-21-0024/logs/libX11/#clean

$ make  clean
Making clean in man
make[1]: Entering directory `/home/cjb/xorg-git/xorg/lib/libX11/man'
Making clean in xkb
make[2]: Entering directory `/home/cjb/xorg-git/xorg/lib/libX11/man/xkb'
make[2]: *** No rule to make target `clean'.  Stop.
make[1]: *** [clean-recursive] Error 1
make: *** [clean-recursive] Error 1

-- 
Chris Ball   c...@laptop.org
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Current tinderbox regression (libX11)

[Colin Harrison]

Hi,

Chris, your fix makes the build work again..but there is no fi_FI stuff in
the produced locale directory?

Thanks
Colin

___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Re: Current tinderbox regression (libX11)

[Chris Ball]

Hi Colin,

Hi, Chris, your fix makes the build work again..but there is no
fi_FI stuff in the produced locale directory?

First line of fi_FI.UTF-8/Makefile.am:

   x11thislocaledir = $(X11_LOCALEDATADIR)/en_US.UTF-8

Looks bogus to me.  James/Julien, what do you think?

- Chris.
-- 
Chris Ball   c...@laptop.org
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Re: Current tinderbox regression (libX11)

[Chris Ball]

Hi,

First line of fi_FI.UTF-8/Makefile.am:
   
   x11thislocaledir = $(X11_LOCALEDATADIR)/en_US.UTF-8
   
Looks bogus to me.  James/Julien, what do you think?

Julien agrees, have tested and pushed a fix.

Thanks,

- Chris.
-- 
Chris Ball   c...@laptop.org
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Current tinderbox regression (libX11)

[Chris Ball]

http://tinderbox.x.org/builds/2008-10-25-0007/
http://tinderbox.x.org/builds/2008-10-25-0007/logs/libX11/#build

/bin/sh: line 1: 17581 Segmentation fault  ../src/util/makekeys 
/home/cjb/xorg-build/include/X11/keysymdef.h  ks_tables_h

-- 
Chris Ball   [EMAIL PROTECTED]
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Re: Current tinderbox regression (libX11)

[James Cloos]

[Grrr.  Forgot to CC the list -JimC]

 Chris == Chris Ball [EMAIL PROTECTED] writes:

Chris http://tinderbox.x.org/builds/2008-10-25-0007/
Chris http://tinderbox.x.org/builds/2008-10-25-0007/logs/libX11/#build

Chris /bin/sh: line 1: 17581 Segmentation fault  ../src/util/makekeys 
Chris /home/cjb/xorg-build/include/X11/keysymdef.h  ks_tables_h

I got a divide-by-zero error instead of a segv; assuming it is due to
the same bug, I just pushed a work-around:

commit b1022fa6d7e97640049e93ffa108083fc8d71b05
Author: James Cloos [EMAIL PROTECTED]
Date:   Sat Oct 25 09:12:45 2008 -0400

Increase size of working arrays in the makekeys utility program.

Makekeys is used to create an optimal hash of the keysyms defined
in x11proto’s keysymdef.h.

The recent addition of new keysyms there has triggered a bug in
makekeys where it tries to use a zero on the rhs of the % (mod)
operator (resulting in a divide by zero error) whenever it fails
to find a solution within its constraints.

Increasing the size of the arrays allows it to find a solution for
the current set of keysyms.

Makekeys is only run durring the build process, so this has no impact
on users of libX11, only on the amount of VM needed to build it.

It still needs a more complete fix, but this allows compiles to
progress until that is completed.

-JimC
-- 
James Cloos [EMAIL PROTECTED] OpenPGP: 1024D/ED7DAEA6
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg