Re: File `-lselinux' does not exist.

2009-08-20 Thread Eamon Walsh
On 08/16/2009 09:10 PM, Dan Nicholson wrote:
 On Sun, Aug 16, 2009 at 6:02 PM, Justin P.
 Mattockjustinmatt...@gmail.com  wrote:

 ooops!
 (as you can see my brain is mush, from looking
 at this all day). After doing the autoreconf
 with your patch finally the xserver compiled all the way through.
 (nice catch).
  
 Is Xorg actually linked to libselinux? Just want to make sure before I
 push the patch.



It is when configured with --enable-xselinux

Ack the patch, please push.



-- 
Eamon Walshewa...@tycho.nsa.gov
National Security Agency

___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: File `-lselinux' does not exist.

2009-08-20 Thread Justin P. Mattock
Eamon Walsh wrote:
 On 08/16/2009 09:10 PM, Dan Nicholson wrote:
 On Sun, Aug 16, 2009 at 6:02 PM, Justin P.
 Mattockjustinmatt...@gmail.com  wrote:
 ooops!
 (as you can see my brain is mush, from looking
 at this all day). After doing the autoreconf
 with your patch finally the xserver compiled all the way through.
 (nice catch).
 Is Xorg actually linked to libselinux? Just want to make sure before I
 push the patch.


 It is when configured with --enable-xselinux

 Ack the patch, please push.



yes, all other security options
will pass.

Justin P. Mattock
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


File `-lselinux' does not exist.

2009-08-16 Thread Justin Mattock
I've been racking my brain on this for a few days
without any results.
I can compile the xserver normally, but as seen as I enable
selinux I get an error during compilation time.

make -d shows this:

No need to remake target `../../xkb/libxkb.la'.
Considering target file `-lselinux'.
 File `-lselinux' does not exist.
 Looking for an implicit rule for `-lselinux'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `-lselinux.pre'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `-lselinux.c'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `-lselinux.o'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `-lselinux,v'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `RCS/-lselinux,v'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `RCS/-lselinux'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `s.-lselinux'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `SCCS/s.-lselinux'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `-lselinux.pre'.
 Looking for a rule with intermediate file `-lselinux.pre'.
  Avoiding implicit rule recursion.
  Trying pattern rule with stem `-lselinux.pre'.
  Trying implicit prerequisite `-lselinux.pre,v'.
  Trying pattern rule with stem `-lselinux.pre'.
  Trying implicit prerequisite `RCS/-lselinux.pre,v'.
  Trying pattern rule with stem `-lselinux.pre'.
  Trying implicit prerequisite `RCS/-lselinux.pre'.
  Trying pattern rule with stem `-lselinux.pre'.
  Trying implicit prerequisite `s.-lselinux.pre'.
  Trying pattern rule with stem `-lselinux.pre'.
  Trying implicit prerequisite `SCCS/s.-lselinux.pre'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `-lselinux.c'.
 Looking for a rule with intermediate file `-lselinux.c'.
  Avoiding implicit rule recursion.
  Trying pattern rule with stem `-lselinux'.
  Trying implicit prerequisite `-lselinux.w'.
  Trying pattern rule with stem `-lselinux.c'.
  Trying implicit prerequisite `-lselinux.c,v'.
  Trying pattern rule with stem `-lselinux.c'.
  Trying implicit prerequisite `RCS/-lselinux.c,v'.
  Trying pattern rule with stem `-lselinux.c'.
  Trying implicit prerequisite `RCS/-lselinux.c'.
  Trying pattern rule with stem `-lselinux.c'.
  Trying implicit prerequisite `s.-lselinux.c'.
  Trying pattern rule with stem `-lselinux.c'.
  Trying implicit prerequisite `SCCS/s.-lselinux.c'.
  Trying pattern rule with stem `-lselinux'.
  Trying implicit prerequisite `-lselinux.w'.
  Looking for a rule with intermediate file `-lselinux.w'.
   Avoiding implicit rule recursion.
   Avoiding implicit rule recursion.
   Trying pattern rule with stem `-lselinux.w'.
   Trying implicit prerequisite `-lselinux.w,v'.
   Trying pattern rule with stem `-lselinux.w'.
   Trying implicit prerequisite `RCS/-lselinux.w,v'.
   Trying pattern rule with stem `-lselinux.w'.
   Trying implicit prerequisite `RCS/-lselinux.w'.
   Trying pattern rule with stem `-lselinux.w'.
   Trying implicit prerequisite `s.-lselinux.w'.
   Trying pattern rule with stem `-lselinux.w'.
   Trying implicit prerequisite `SCCS/s.-lselinux.w'.
 Trying pattern rule with stem `-lselinux'.
 Trying implicit prerequisite `-lselinux.o'.
 Looking for a rule with intermediate file `-lselinux.o'.
  Avoiding implicit rule recursion.
  Trying pattern rule with stem `-lselinux'.
  Rejecting impossible implicit prerequisite `-lselinux.c'.
  Trying pattern rule with stem `-lselinux.o'.
  Trying implicit prerequisite `-lselinux.o,v'.
  Trying pattern rule with stem `-lselinux.o'.
  Trying implicit prerequisite `RCS/-lselinux.o,v'.
  Trying pattern rule with stem `-lselinux.o'.
  Trying implicit prerequisite `RCS/-lselinux.o'.
  Trying pattern rule with stem `-lselinux.o'.
  Trying implicit prerequisite `s.-lselinux.o'.
  Trying pattern rule with stem `-lselinux.o'.
  Trying implicit prerequisite `SCCS/s.-lselinux.o'.
 No implicit rule found for `-lselinux'.
 Finished prerequisites of target file `-lselinux'.
Must remake target `-lselinux'.
make[4]: Entering directory
`/home/justin/LFS/xserver/xorg-server-1.6.1.901/hw/xfree86'
make[4]: *** No rule to make target `-lselinux', needed by `Xorg'.  Stop.
make[4]: Leaving directory
`/home/justin/LFS/xserver/xorg-server-1.6.1.901/hw/xfree86'
Reaping losing child 0x00656860 PID 17449
make[3]: *** [all-recursive] Error 1
Removing child 0x00656860 PID 17449 from chain.
make[3]: Leaving directory
`/home/justin/LFS/xserver/xorg-server-1.6.1.901/hw/xfree86'
Reaping losing child 0x00657740 PID

Re: File `-lselinux' does not exist.

2009-08-16 Thread Dan Nicholson
On Sun, Aug 16, 2009 at 4:52 PM, Dan Nicholsondbn.li...@gmail.com wrote:
 On Sun, Aug 16, 2009 at 2:11 PM, Justin Mattockjustinmatt...@gmail.com 
 wrote:
 I've been racking my brain on this for a few days
 without any results.
 I can compile the xserver normally, but as seen as I enable
 selinux I get an error during compilation time.

 make -d shows this:

 No need to remake target `../../xkb/libxkb.la'.
    Considering target file `-lselinux'.
     File `-lselinux' does not exist.

 Try commenting the automake rule for libxorg_la_DEPENDENCIES in
 hw/xfree86/Makefile.am. The problem is that libxorg_la_DEPENDENCIES is
 defined as libxorg_la_LIBADD, which (rightly) includes -lselinux.
 However, DEPENDENCIES are used as make prerequisites, so make will try
 to find a file named -lselinux. DEPENDENCIES and LIBADD need to be
 untangled so that external libraries don't appear as make prereqs.

Try this (untested) patch.

--
Dan
diff --git a/configure.ac b/configure.ac
index 3287f9a..e7c0596 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1337,7 +1337,7 @@ if test x$XORG = xyes; then
 	XORG_OSINCS='-I$(top_srcdir)/hw/xfree86/os-support -I$(top_srcdir)/hw/xfree86/os-support/bus -I$(top_srcdir)/os'
 	XORG_INCS=$XORG_DDXINCS $XORG_OSINCS
 	XORG_CFLAGS=$XORGSERVER_CFLAGS -DHAVE_XORG_CONFIG_H
-	XORG_LIBS=$COMPOSITE_LIB $FIXES_LIB $XEXTXORG_LIB $GLX_LIBS $RANDR_LIB $RENDER_LIB $DAMAGE_LIB $MIEXT_DAMAGE_LIB $MIEXT_SHADOW_LIB $XI_LIB $XKB_LIB $SELINUX_LIB
+	XORG_LIBS=$COMPOSITE_LIB $FIXES_LIB $XEXTXORG_LIB $GLX_LIBS $RANDR_LIB $RENDER_LIB $DAMAGE_LIB $MIEXT_DAMAGE_LIB $MIEXT_SHADOW_LIB $XI_LIB $XKB_LIB
 
 	dnl ==
 	dnl symbol visibility
@@ -1390,7 +1390,7 @@ if test x$XORG = xyes; then
 	AC_CHECK_FUNCS([pci_device_is_boot_vga])
 	LIBS=$SAVE_LIBS
 	CFLAGS=$SAVE_CFLAGS
-	XORG_SYS_LIBS=$XORG_SYS_LIBS $PCIACCESS_LIBS $DLOPEN_LIBS $GLX_SYS_LIBS
+	XORG_SYS_LIBS=$XORG_SYS_LIBS $PCIACCESS_LIBS $DLOPEN_LIBS $GLX_SYS_LIBS $SELINUX_LIB
 	XORG_CFLAGS=$XORG_CFLAGS $PCIACCESS_CFLAGS
 
 	case $host_os in
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Re: File `-lselinux' does not exist.

2009-08-16 Thread Justin P. Mattock
Dan Nicholson wrote:
 On Sun, Aug 16, 2009 at 4:52 PM, Dan Nicholsondbn.li...@gmail.com  wrote:

 On Sun, Aug 16, 2009 at 2:11 PM, Justin Mattockjustinmatt...@gmail.com  
 wrote:
  
 I've been racking my brain on this for a few days
 without any results.
 I can compile the xserver normally, but as seen as I enable
 selinux I get an error during compilation time.

 make -d shows this:

 No need to remake target `../../xkb/libxkb.la'.
 Considering target file `-lselinux'.
  File `-lselinux' does not exist.

 Try commenting the automake rule for libxorg_la_DEPENDENCIES in
 hw/xfree86/Makefile.am. The problem is that libxorg_la_DEPENDENCIES is
 defined as libxorg_la_LIBADD, which (rightly) includes -lselinux.
 However, DEPENDENCIES are used as make prerequisites, so make will try
 to find a file named -lselinux. DEPENDENCIES and LIBADD need to be
 untangled so that external libraries don't appear as make prereqs.
  

 Try this (untested) patch.

 --
 Dan

Thanks you very much for the info,
and patch.

I cleaned out the xserver(distclean) then
applied your patch.
unfortunately I'm still hitting this
same error.

I can go and try looking at the Makefile to see,
if this approach works.

Justin P. Mattock
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


Re: File `-lselinux' does not exist.

2009-08-16 Thread Dan Nicholson
On Sun, Aug 16, 2009 at 6:02 PM, Justin P.
Mattockjustinmatt...@gmail.com wrote:

 ooops!
 (as you can see my brain is mush, from looking
 at this all day). After doing the autoreconf
 with your patch finally the xserver compiled all the way through.
 (nice catch).

Is Xorg actually linked to libselinux? Just want to make sure before I
push the patch.

--
Dan
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg