Re: [PATCH] Notify DRI when crtc regions change
On Tue, 2008-11-18 at 14:08 -0500, Adam Jackson wrote: > I'm not totally convinced that DisableUnusedFunctions is the right place > for this to get called, but it's merely overkill. Ack. Yeah, agreed, but DisableUnusedFunctions is the one thing which is always called at the end of any crtc modification. Someday we'll clean this stuff up... -- [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Notify DRI when crtc regions change
On Fri, 2008-11-14 at 12:50 -0800, Keith Packard wrote: > Drivers that care about crtc positions on the screen to ensure that vblank > works correctly need to be notified when crtcs are changed. > > Provide a hook in the mode setting code that is invoked whenever any > configuration is done to the screen. > > Use this new hook in the DRI code so that DRI clients are notified and > receive updated information. I'm not totally convinced that DisableUnusedFunctions is the right place for this to get called, but it's merely overkill. Ack. - ajax signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Notify DRI when crtc regions change
On Tue, 2008-11-04 at 15:48 -0500, Adam Jackson wrote: > I think it makes sense, although I'm kind of surprised we don't pick up > on it from ClipNotify on the root window. Still rotation is basically a > catastrophic clip change so might as well recompute the world. Rotation would hit ClipNotify, but just changing crtcs around without changing the size would not. > If we wanted a standard macro set I wouldn't complain. I'm loathe to > introduce more function calls to the standard wrap chains though, O(n) > devprivates was a bad enough performance hit to make me hesitant to > introduce more things that grow linearly with number of subsystems. Yeah. I'll just expose the structure and get DRI to wrap it in the usual way. -- [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Notify DRI when crtc regions change
On Tue, 2008-11-04 at 10:04 -0800, Keith Packard wrote: > On Tue, 2008-11-04 at 10:35 -0500, Adam Jackson wrote: > > > Please put this in the rrScrPrivRec instead. When we finally finish > > multi-GPU support in RANDR this will want to be per-ScreenRec. > > Yeah, I can imagine other extensions that will want to know when the > crtc configuration has changed. I was mostly interested in getting > review on whether this approach makes sense for DRI, or if there should > be some different method here. I think it makes sense, although I'm kind of surprised we don't pick up on it from ClipNotify on the root window. Still rotation is basically a catastrophic clip change so might as well recompute the world. > > (At which point it should probably be a proper wrap chain as well.) > > In the traditional style, there wouldn't be any API, just a public > structure with the callback in place. Should we start exposing an > abstract interface to wrapping? If we wanted a standard macro set I wouldn't complain. I'm loathe to introduce more function calls to the standard wrap chains though, O(n) devprivates was a bad enough performance hit to make me hesitant to introduce more things that grow linearly with number of subsystems. - ajax signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Notify DRI when crtc regions change
On Tue, 2008-11-04 at 10:35 -0500, Adam Jackson wrote: > Please put this in the rrScrPrivRec instead. When we finally finish > multi-GPU support in RANDR this will want to be per-ScreenRec. Yeah, I can imagine other extensions that will want to know when the crtc configuration has changed. I was mostly interested in getting review on whether this approach makes sense for DRI, or if there should be some different method here. > (At which point it should probably be a proper wrap chain as well.) In the traditional style, there wouldn't be any API, just a public structure with the callback in place. Should we start exposing an abstract interface to wrapping? -- [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH] Notify DRI when crtc regions change
On Tue, 2008-11-04 at 02:07 -0800, Keith Packard wrote:
> diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c
> index df47598..0ae1e4d 100644
> --- a/hw/xfree86/modes/xf86Crtc.c
> +++ b/hw/xfree86/modes/xf86Crtc.c
> @@ -2545,6 +2545,14 @@ xf86SaveScreen(ScreenPtr pScreen, int mode)
> return TRUE;
> }
>
> +static void (*dri_crtc_notify_hook) (ScreenPtr pScreen);
> +
> +_X_EXPORT void
> +xf86_set_dri_crtc_notify_hook (void (*hook) (ScreenPtr pScreen))
> +{
> +dri_crtc_notify_hook = hook;
> +}
> +
> /**
> * Disable all inactive crtcs and outputs
> */
Please put this in the rrScrPrivRec instead. When we finally finish
multi-GPU support in RANDR this will want to be per-ScreenRec.
(At which point it should probably be a proper wrap chain as well.)
- ajax
signature.asc
Description: This is a digitally signed message part
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg
