Re: Current tinderbox regression (xserver, OS X)
gah. It's using the older system headers rather than the ones installed by the build ... this is a bug in my jhbuild rather than a bug in the server ... On May 14, 2010, at 22:05, Chris Ball wrote: > http://tinderbox.x.org/builds/2010-05-15-0003/logs/xserver/#build > > ../include/os.h:302: error: syntax error before '_X_NORETURN' > ../include/os.h:302: warning: data definition has no type or storage class > ../include/os.h:302: warning: type defaults to 'int' in declaration of > '_X_NORETURN' > > http://cgit.freedesktop.org/xorg/xserver/commit/?id=bca85e2e127a8a23e3a2debcfeb3ae07cd3c66ac > > -- > Chris Ball > One Laptop Per Child ___ xorg@lists.freedesktop.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Mon, Sep 14, 2009 at 07:56:51AM +0200, Werner LEMBERG wrote: > >> http://tinderbox.x.org/builds/2009-09-13-/logs/xserver/#build > >> > >> In file included from dmx.c:61: > >> /home/cjb/xorg-build/include/X11/extensions/dmxext.h:69: error: > >> expected specifier-qualifier-list before 'XRectangle' > > > > Fixed, sorry about that. > > > > http://cgit.freedesktop.org/xorg/xserver/commit/?id=e85775aa64d1e9322c82090a26256af5e1fede0a > > Are such fixes reflected in the supermodule? How do I update > properly? The 7.5 supermodule is on .900 which doesn't have the dmx fixes in yet. Best is to wait for RC1 if you want it done automatically. However, note that the supermodule simple records the commit of the submodules, nothing else. So you can simply go into xserver and run git pull (switch to the master branch first though). next time you run git submodule update it'll set you back onto the recorded commit. Cheers, Peter ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
>> http://tinderbox.x.org/builds/2009-09-13-/logs/xserver/#build >> >> In file included from dmx.c:61: >> /home/cjb/xorg-build/include/X11/extensions/dmxext.h:69: error: >> expected specifier-qualifier-list before 'XRectangle' > > Fixed, sorry about that. > > http://cgit.freedesktop.org/xorg/xserver/commit/?id=e85775aa64d1e9322c82090a26256af5e1fede0a Are such fixes reflected in the supermodule? How do I update properly? Werner ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Sun, Sep 13, 2009 at 02:31:23PM -0400, Chris Ball wrote: > http://tinderbox.x.org/builds/2009-09-13-/logs/xserver/#build > > In file included from dmx.c:61: > /home/cjb/xorg-build/include/X11/extensions/dmxext.h:69: error: > expected specifier-qualifier-list before 'XRectangle' Fixed, sorry about that. http://cgit.freedesktop.org/xorg/xserver/commit/?id=e85775aa64d1e9322c82090a26256af5e1fede0a Cheers, Peter ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Fri, Jun 12, 2009 at 08:31:34PM -0400, Chris Ball wrote: > http://tinderbox.x.org/builds/2009-06-12-0011/logs/xserver/#build > > xiselectev.c: In function 'SProcXISelectEvents': > xiselectev.c:49: error: 'xXISelectEventsReq' has no member named 'window' I could have sworn I i pushed this on Friday. Sorry about that, fixed. Cheers, Peter ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
Chris Ball wrote: > http://tinderbox.x.org/builds/2009-01-30-0005/logs/xserver/#build > > In file included from ../Xext/panoramiX.h:43, from dispatch.c:134: > /home/cjb/xorg-build/include/X11/extensions/panoramiXext.h:48: > error: expected ')' before '*' token > /home/cjb/xorg-build/include/X11/extensions/panoramiXext.h:53: > error: expected '=', ',', ';', 'asm' or '__attribute__' > before 'XPanoramiXQueryVersion' It is me striking again :-) Since there was already one missing prototype declared in panoramiXext.h, I just added the remaining ones, but that requires defining "Display" to something (yes, I did not remember the X Server build could include that header...) The X Server build only needs the macros PANORAMIX_MAJOR_VERSION and PANORAMIX_MINOR_VERSION from One option is to use the schema used by some other related cases, and protect the prototypes there with something like: #ifndef _PANORAMIX_SERVER ... #endif Or move those macros to X11/extensions/panoramiXproto.h like is done in other similar cases. There is also some code doing weird things to get Display defined, see xserver/Xext/securitysrv.h To avoid the risk of breaking things elsewhere, the proper correction should be to protect the prototypes with: #ifndef _PANORAMIX_SERVER and add _XFUNCPROTOBEGIN/_XFUNCPROTOEND while at it. > -- > Chris Ball Paulo ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Mon, Jan 26, 2009 at 06:45:28PM -0800, Eric Anholt wrote: > On Fri, 2009-01-23 at 10:26 +1100, Daniel Stone wrote: > > Yeah, Xnest and Xdmx are broken, sorry. That being said, we've talked a > > lot about just deleting Xnest in favour of Xephyr: anyone got any > > compelling counter-arguments? > > Pretty sure the compelling argument was that Xnest would pass through > requests so that you got acceleration from your host server. Except > that it doesn't support modern extensions, so you get no acceleration > and clients shaking their fists at you instead. I haven't heard of any > use for it as a debugging platform, either. > > Nuke away, in my opinion. Yep. Just got to add full Xnest command-line compatibility, then it's gone. Cheers, Daniel signature.asc Description: Digital signature ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Fri, 2009-01-23 at 10:26 +1100, Daniel Stone wrote: > On Thu, Jan 22, 2009 at 10:08:04AM -0500, Chris Ball wrote: > > Keyboard.c: In function 'xnestKeyboardProc': > > Keyboard.c:177: warning: passing argument 1 of 'XkbSetRulesDflts' from > > incompatible pointer type > > Keyboard.c:177: error: too many arguments to function 'XkbSetRulesDflts' > > Keyboard.c:178: warning: implicit declaration of function > > 'XkbInitKeyboardDeviceStruct' > > Keyboard.c:178: warning: nested extern declaration of > > 'XkbInitKeyboardDeviceStruct' > > Keyboard.c:206: warning: passing argument 1 of 'InitKeyboardDeviceStruct' > > from incompatible pointer type > > Keyboard.c:206: warning: passing argument 2 of 'InitKeyboardDeviceStruct' > > from incompatible pointer type5B > > Keyboard.c:122: warning: unused variable 'j' > > Keyboard.c:117: warning: unused variable 'modifier_keymap' > > Keyboard.c: In function 'xnestUpdateModifierState': > > Keyboard.c:227: error: 'struct _KeyClassRec' has no member named 'state' > > Keyboard.c:235: error: 'struct _KeyClassRec' has no member named 'state' > > Keyboard.c:256: error: 'struct _KeyClassRec' has no member named 'state' > > Yeah, Xnest and Xdmx are broken, sorry. That being said, we've talked a > lot about just deleting Xnest in favour of Xephyr: anyone got any > compelling counter-arguments? Pretty sure the compelling argument was that Xnest would pass through requests so that you got acceleration from your host server. Except that it doesn't support modern extensions, so you get no acceleration and clients shaking their fists at you instead. I haven't heard of any use for it as a debugging platform, either. Nuke away, in my opinion. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Thu, Jan 22, 2009 at 10:08:04AM -0500, Chris Ball wrote: > Keyboard.c: In function 'xnestKeyboardProc': > Keyboard.c:177: warning: passing argument 1 of 'XkbSetRulesDflts' from > incompatible pointer type > Keyboard.c:177: error: too many arguments to function 'XkbSetRulesDflts' > Keyboard.c:178: warning: implicit declaration of function > 'XkbInitKeyboardDeviceStruct' > Keyboard.c:178: warning: nested extern declaration of > 'XkbInitKeyboardDeviceStruct' > Keyboard.c:206: warning: passing argument 1 of 'InitKeyboardDeviceStruct' > from incompatible pointer type > Keyboard.c:206: warning: passing argument 2 of 'InitKeyboardDeviceStruct' > from incompatible pointer type5B > Keyboard.c:122: warning: unused variable 'j' > Keyboard.c:117: warning: unused variable 'modifier_keymap' > Keyboard.c: In function 'xnestUpdateModifierState': > Keyboard.c:227: error: 'struct _KeyClassRec' has no member named 'state' > Keyboard.c:235: error: 'struct _KeyClassRec' has no member named 'state' > Keyboard.c:256: error: 'struct _KeyClassRec' has no member named 'state' Yeah, Xnest and Xdmx are broken, sorry. That being said, we've talked a lot about just deleting Xnest in favour of Xephyr: anyone got any compelling counter-arguments? Cheers, Daniel signature.asc Description: Digital signature ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Tue, Jan 20, 2009 at 02:47:51PM -0800, Alan Coopersmith wrote: > Ian Romanick wrote: > > With that fixed, I hit the following failure: > > > > kbd.c:148: error: ‘__XKBDEFRULES__’ undeclared here (not in a function) > > That's from the XKB --configure/define patch Daniel just pushed, as I > warned last week. I'll push a kbd driver fix for that in a few. Sorry, pushing that was unintentional. Cheers, Daniel ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
Ian Romanick wrote: > With that fixed, I hit the following failure: > > kbd.c:148: error: ‘__XKBDEFRULES__’ undeclared here (not in a function) That's from the XKB --configure/define patch Daniel just pushed, as I warned last week. I'll push a kbd driver fix for that in a few. -- -Alan Coopersmith- alan.coopersm...@sun.com Sun Microsystems, Inc. - X Window System Engineering ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
Ian Romanick wrote: > On Tue, 2009-01-20 at 14:30 -0500, Chris Ball wrote: >> http://tinderbox.x.org/builds/2009-01-20-0024/logs/xserver/#build >> >> ./.libs/libxorg.a(sdksyms.o):(.data.rel+0x308): undefined reference to >> `CreateUnclippedWinSize' >> >> http://cgit.freedesktop.org/xorg/xserver/commit/?id=20d2117eb82fb7ce91afd4f01fe1b9d4b1bf0459 >> > > I'm seeing this also. It seems like the sdksyms.sh script should try to > pull in this symbol since it isn't decorated with _X_EXPORT. The > attached patch makes that part of the build work, but > is...eh...unpleasant to my eyes. The "magic" in sdksyms.sh is to remove the "extern" before the symbol name. But really, this should not be done, and instead, such symbols should be declared on non sdk headers, or at least add a comment telling that this symbol is in the header, but should not be used by drivers... I will try to rework on a more complete "initial" patch to correct most sdk headers problems; last time I posted one, I did not receive much love :-) > With that fixed, I hit the following failure: > > kbd.c:148: error: â__XKBDEFRULES__â undeclared here (not in a > function) Paulo ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Tue, 2009-01-20 at 14:30 -0500, Chris Ball wrote:
> http://tinderbox.x.org/builds/2009-01-20-0024/logs/xserver/#build
>
> ./.libs/libxorg.a(sdksyms.o):(.data.rel+0x308): undefined reference to
> `CreateUnclippedWinSize'
>
> http://cgit.freedesktop.org/xorg/xserver/commit/?id=20d2117eb82fb7ce91afd4f01fe1b9d4b1bf0459
>
I'm seeing this also. It seems like the sdksyms.sh script should try to
pull in this symbol since it isn't decorated with _X_EXPORT. The
attached patch makes that part of the build work, but
is...eh...unpleasant to my eyes.
With that fixed, I hit the following failure:
kbd.c:148: error: ‘__XKBDEFRULES__’ undeclared here (not in a function)
diff --git a/Xext/mbuf.c b/Xext/mbuf.c
index 8276032..43a905f 100644
--- a/Xext/mbuf.c
+++ b/Xext/mbuf.c
@@ -57,6 +57,8 @@ in this Software without prior written authorization from The Open Group.
#define ValidEventMasks (ExposureMask|MultibufferClobberNotifyMask|MultibufferUpdateNotifyMask)
+RegionPtr CreateUnclippedWinSize(WindowPtr);
+
static int MultibufferEventBase;
static int MultibufferErrorBase;
static int MultibufferScreenPrivKeyIndex;
diff --git a/Xext/mbufpx.c b/Xext/mbufpx.c
index 01811d9..72de3c9 100644
--- a/Xext/mbufpx.c
+++ b/Xext/mbufpx.c
@@ -49,6 +49,7 @@ in this Software without prior written authorization from The Open Group.
#define _MULTIBUF_PIXMAP_
#include
+extern RegionPtr CreateUnclippedWinSize(WindowPtr);
static Bool NoopDDA_True() { return TRUE; }
diff --git a/include/window.h b/include/window.h
index 8c25799..6fb2f8c 100644
--- a/include/window.h
+++ b/include/window.h
@@ -156,8 +156,6 @@ extern _X_EXPORT void GetWindowAttributes(
ClientPtr /*client*/,
xGetWindowAttributesReply* /* wa */);
-extern RegionPtr CreateUnclippedWinSize(WindowPtr);
-
extern _X_EXPORT void GravityTranslate(
int /*x*/,
int /*y*/,
signature.asc
Description: This is a digitally signed message part
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
Hi Paulo, > Correction just pushed. Thanks. > Do you also build on other architectures and operating systems? > I have interest at least in builds on Solaris and BSD. At the moment the three machines on http://tinderbox.x.org/ are Linux sparc64, Linux ppc64 and Linux i686, and I'd be happy to include others. The steps for setting up a new machine are: * Read http://tinderbox.x.org/participate, get a username/pass * Set up jhbuild; see http://wiki.x.org/wiki/JhBuildInstructions * "jhbuild build xorg-libs xserver xorg-drivers xorg-apps"; check that the build completes and you have the appropriate dependencies. * Once you're ready to add the machine to the tinderbox front page, set up a crontab such as: 0 */2 * * *bin/jhbuild autobuild -a -c --report-url="http://USER:[EMAIL PROTECTED]/builds/rpc" xorg-libs xserver xorg-drivers xorg-apps The tinderbox code can also launch the generated X server and perform checks/benchmarks against it, but I don't have easy instructions for how to do that with a new machine yet -- if someone wants to add that to a machine (the "construct" i686 machine does so already) let me know. Thanks, - Chris. -- Chris Ball <[EMAIL PROTECTED]> ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
> Hi, Hi, Thanks for the report. Correction just pushed. >> commit b1dac41fb3853ca8182048ea57b88b6e84ecceb3 >> Author: Paulo Cesar Pereira de Andrade <[EMAIL PROTECTED]> Date: >> Sun Dec 7 02:22:19 2008 -0200 >> >> Use libtool convenience libraries and better "symbol" table. > > http://tinderbox.x.org/builds/2008-12-07-0007/ > http://tinderbox.x.org/builds/2008-12-07-0007/logs/xserver/#build > > ./.libs/libxorg.a(sdksyms.o):(.data.rel+0x13d4): undefined reference to > `xf86acpiDisableFlag' > collect2: ld returned 1 exit status Do you also build on other architectures and operating systems? I have interest at least in builds on Solaris and BSD. > -- > Chris Ball <[EMAIL PROTECTED]> Paulo ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
> http://tinderbox.x.org/builds/2008-12-05-0010/ > http://tinderbox.x.org/builds/2008-12-05-0010/logs/xserver/#build > > loader.c:77:17: error: sym.h: No such file or directory > loader.c: In function 'LoaderInit': > loader.c:110: error: 'dixLookupTab' undeclared (first use in this > function) > loader.c:110: error: 'extLookupTab' undeclared (first use in this > function) > loader.c:111: error: 'miLookupTab' undeclared (first use in this function) > loader.c:111: error: 'xfree86LookupTab' undeclared (first use in this > function) Thanks for the report. It was my fault of not making a clean build last night. This was not the only problem tough. Due to removing the static symbol tables, X Server and modules built in the X Server tree had all linkage problems, as symbols were not added to the linkage of the X Server, or it failed to resolved dependencies, so order of libraries should be modified when linking. I readded a "simplified" version of the previous *sym.c files. I will try to have it generated automatically from the sdk headers, to avoid a difficult maintenance process, with the requirement of updating things in two places (header files and file with vector of symbols addresses). > http://cgit.freedesktop.org/xorg/xserver/commit/?id=44c8c3cf7de589fb8e987f4ab931294eaf0b405f > > -- > Chris Ball <[EMAIL PROTECTED]> Paulo ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver, xf86-video-intel)
> http://tinderbox.x.org/builds/2008-12-03-0010/ > http://tinderbox.x.org/builds/2008-12-03-0010/logs/xf86-video-intel/#build > > In file included from bios_reader.c:45: > /home/cjb/xorg-build/include/xorg/edid.h:550: error: expected '=', ',', > ';', 'asm' or '__attribute__' before 'xf86MonPtr' Thanks. Corrected by including before "edid.h". Some work should be done to ensure including either sdk header will work correctly by "pushing it's dependencies", but unfortunately, this is still not true even for the standard /usr/include/X11 headers. > -- > Chris Ball <[EMAIL PROTECTED]> > Paulo ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
> http://tinderbox.x.org/builds/2008-12-03-0012/ > http://tinderbox.x.org/builds/2008-12-03-0012/logs/xserver/#build > > In file included from Pci.c:130: > ../../../../hw/xfree86/common/compiler.h:1041: error: expected '=', ',', > ';', 'asm' or '__attribute__' before 'volatile' > ../../../../hw/xfree86/common/compiler.h: In function 'outb': > ../../../../hw/xfree86/common/compiler.h:1212: error: 'ioBase' undeclared > (first use in this function) > > Oddly, this is only happening on the "bombadil" machine so far, with > gcc version 4.1.2 20070925 (Red Hat 4.1.2-33) on ppc64-redhat-linux. Thanks for the report. I added a check for _X_EXPORT to compiler.h, and if it is not defined, it will include > -- > Chris Ball <[EMAIL PROTECTED]> Paulo ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Current tinderbox regression (xserver)
On Wed, 2008-11-26 at 09:27 -0500, Chris Ball wrote: > http://tinderbox.x.org/builds/2008-11-26-0010/ > http://tinderbox.x.org/builds/2008-11-26-0010/logs/xserver/#build > > rrcrtc.c: In function 'ProcRRSetCrtcTransform': > rrcrtc.c:1083: error: 'xRRSetCrtcTransformReq' undeclared > rrcrtc.c:1083: error: 'stuff' undeclared (first use in this function) > rrcrtc.c:1083: error: expected expression before ')' token The libXrandr & randrproto transform-proposal branches are required, until Keith merges them to their respective trunks. Alan. ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
