Re: bumping mesa's texture limit to 4kx4k in 7.4?

2009-02-02 Thread Ian Romanick
On Mon, 2009-02-02 at 21:55 +0100, Khashayar Naderehvandi wrote:
> Any chance commit 954dfba12986f578f2d8461818f9e9ac1f8f2b41 in
> mesa/mesa, the one that bumps mesa's texture limit to 4kx4k for i965
> will end up in the 7.4 branch? It's such a small patch, and it does
> fix a seriously annoying bug that has been present for way too long.

NAK.

As is, this patch is completely broken.  Any attempt to create a
mipmapped 4Kx4K texture on 965 will break.  At the very least,
MAX_TEXTURE_LEVELS and MAX_TEXTURE_RECT_SIZE in src/mesa/main/config.h
also need to be increased.  MAX_TEXTURE_LEVELS is used to size arrays in
various structures.

Keith, why didn't you use the patch that I sent you?  It correctly
increased these constants while only exposing 2Kx2K textures in the
software rasterizer.



signature.asc
Description: This is a digitally signed message part
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Re: bumping mesa's texture limit to 4kx4k in 7.4?

2009-02-02 Thread Keith Packard
On Mon, 2009-02-02 at 17:02 -0700, Brian Paul wrote:

> I'd be willing to include it in 7.4.  But I think I'll wait a little bit 
> to see if any regressions pop up.  I'm doing work with the i965 driver 
> so I'll keep my eyes open.

The 965 hardware can go up to 8kx8k, so any border issues shouldn't be a
problem at 4kx4k. However, I don't exactly understand all of the
constants that are set up for texture boundaries, so a review of the
remaining values would be most appreciated.

-- 
keith.pack...@intel.com


signature.asc
Description: This is a digitally signed message part
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

Re: bumping mesa's texture limit to 4kx4k in 7.4?

2009-02-02 Thread Brian Paul
Khashayar Naderehvandi wrote:
> Any chance commit 954dfba12986f578f2d8461818f9e9ac1f8f2b41 in
> mesa/mesa, the one that bumps mesa's texture limit to 4kx4k for i965
> will end up in the 7.4 branch? It's such a small patch, and it does
> fix a seriously annoying bug that has been present for way too long.

I'd be willing to include it in 7.4.  But I think I'll wait a little bit 
to see if any regressions pop up.  I'm doing work with the i965 driver 
so I'll keep my eyes open.

-Brian
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg


bumping mesa's texture limit to 4kx4k in 7.4?

2009-02-02 Thread Khashayar Naderehvandi
Any chance commit 954dfba12986f578f2d8461818f9e9ac1f8f2b41 in
mesa/mesa, the one that bumps mesa's texture limit to 4kx4k for i965
will end up in the 7.4 branch? It's such a small patch, and it does
fix a seriously annoying bug that has been present for way too long.

Thanks,
Khashayar
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg