xorg/driver/xf86-input-mouse: [PATCH] Janitor: use $PKG_CONFIG and update .gitignore.
Update .gitignore for files remaining after make and make distcheck, as well as entry for the default tags file. Also, from this patch on at least, start using non bash'isms (because it is how it is done in other packages) and use $PKG_CONFIG to better work on some build environments (as suggested by Dan Nicholson). >From 259dfd693b543f96aa52a0fb226740951929bd58 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade Date: Wed, 4 Feb 2009 20:48:33 -0200 Subject: [PATCH] Janitor: use $PKG_CONFIG and update .gitignore. Signed-off-by: Paulo Cesar Pereira de Andrade --- .gitignore |6 ++ configure.ac |2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index 2df4a8d..dfb9348 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,5 @@ +.deps +.libs Makefile Makefile.in *.la @@ -18,3 +20,7 @@ ltmain.sh missing stamp-h1 *~ +*.4 +xf86-input-mouse-*.tar.* +ChangeLog +tags diff --git a/configure.ac b/configure.ac index 9c4f034..db57697 100644 --- a/configure.ac +++ b/configure.ac @@ -63,7 +63,7 @@ XORG_DRIVER_CHECK_EXT(XINPUT, inputproto) # Checks for pkg-config packages PKG_CHECK_MODULES(XORG, [xorg-server >= 1.0.99.901] xproto $REQUIRED_MODULES) -sdkdir=$(pkg-config --variable=sdkdir xorg-server) +sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server` # Checks for libraries. -- 1.6.1 ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: xorg/driver/xf86-input-mouse: [PATCH] Janitor: use $PKG_CONFIG and update .gitignore.
On Wed, Feb 4, 2009 at 3:21 PM, Paulo César Pereira de Andrade wrote: > Update .gitignore for files remaining after make and > make distcheck, as well as entry for the default tags file. > > Also, from this patch on at least, start using non > bash'isms (because it is how it is done in other packages) > and use $PKG_CONFIG to better work on some build environments > (as suggested by Dan Nicholson). Thank you. -- Dan ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: xorg/driver/xf86-input-mouse: [PATCH] Janitor: use $PKG_CONFIG and update .gitignore.
Paulo César Pereira de Andrade wrote: > Update .gitignore for files remaining after make and > make distcheck, as well as entry for the default tags file. > > Also, from this patch on at least, start using non > bash'isms (because it is how it is done in other packages) > and use $PKG_CONFIG to better work on some build environments > (as suggested by Dan Nicholson). Pushed. (And those building on Solaris 10 and earlier, where /bin/sh is an ancient Bourne shell that supports `` but not $() also thank you. Eventually we'll get most of them to migrate to OpenSolaris, where /bin/sh is ksh93, but there's always stragglers on old OS versions.) -- -Alan Coopersmith- alan.coopersm...@sun.com Sun Microsystems, Inc. - X Window System Engineering ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: xorg/driver/xf86-input-mouse: [PATCH] Janitor: use $PKG_CONFIG and update .gitignore.
On Wed, 2009-02-04 at 21:21 -0200, Paulo César Pereira de Andrade wrote: > Also, from this patch on at least, start using non > bash'isms (because it is how it is done in other packages) $() isn't a bashism. It's POSIX sh. Cheers, Julien ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: xorg/driver/xf86-input-mouse: [PATCH] Janitor: use $PKG_CONFIG and update .gitignore.
On Thu, Feb 05, 2009 at 10:42:13AM +0100, Julien Cristau wrote: > On Wed, 2009-02-04 at 21:21 -0200, Paulo C?sar Pereira de Andrade wrote: > > Also, from this patch on at least, start using non > > bash'isms (because it is how it is done in other packages) > > $() isn't a bashism. It's POSIX sh. It doesn't work with older /bin/sh on Solaris. But yes, it is part of POSIX. Joerg ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
