Re: (Crowd funded) fix for SiS 671/771 video cards
On 05/18/2013 10:28 PM, Tormod Volden wrote: On Sat, May 18, 2013 at 7:52 PM, Pander wrote: (manual) patch results in [74.465] (II) LoadModule: sisimedia [74.465] (II) Loading /usr/lib/xorg/modules/drivers/sisimedia_drv.so [74.465] (EE) Failed to load /usr/lib/xorg/modules/drivers/sisimedia_drv.so: /usr/lib/xorg/modules/drivers/sisimedia_drv.so: undefined symbol: SiSUploadToScratch [74.465] (II) UnloadModule: sisimedia [74.465] (II) Unloading sisimedia [74.465] (EE) Failed to load module sisimedia (loader failed, 7) I used this file: http://pastebin.com/XkYfxrQy It would be more useful if you told which file it is and which version instead of paste-binning it. I assume this is the src/sis310_accel.c from git://gitorious.org/xf86-video-sis671/sis-671-fix.git Sorry, I forgot indeed that filename. I have removed declarations and usage of SiSUploadToScreen, SiSUploadToScratch and SiSDownloadFromScreen. Do I need to do that also for void SiSScratchSave(ScreenPtr pScreen, ExaOffscreenArea *area); ? How can I fix this? Connor's pastebin patch only removed SiSUploadToScratch() from that one file. You will have to remove all references to that function. git grep SiSUploadToScratch will help you. Regards, Tormod ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:libX11] Make sure internal headers include required headers
On Fri, May 17, 2013 at 03:28:04PM -0700, Alan Coopersmith wrote:
From: Niveditha Rau niveditha@oracle.com
Fixes builds with Solaris Studio 12.3 when lint is enabled, since it no
longer ignores *.h files, but complains when they reference undefined
typedefs or macros.
Signed-off-by: Niveditha Rau niveditha@oracle.com
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
Cheers,
Peter
---
src/Cmap.h |2 ++
src/Cr.h |2 ++
src/Key.h |3 +++
src/Xintatom.h |1 +
src/Xintconn.h |1 +
src/Xprivate.h |2 ++
src/Xresinternal.h |2 ++
src/locking.h |2 ++
8 files changed, 15 insertions(+)
diff --git a/src/Cmap.h b/src/Cmap.h
index 062b538..78cc3ea 100644
--- a/src/Cmap.h
+++ b/src/Cmap.h
@@ -2,6 +2,8 @@
#ifndef _CMAP_H_
#define _CMAP_H_
+#include X11/Xlib.h
+
extern void
_XcmsDeleteCmapRec(
Display *dpy,
diff --git a/src/Cr.h b/src/Cr.h
index 800c9ab..635e9e4 100644
--- a/src/Cr.h
+++ b/src/Cr.h
@@ -2,6 +2,8 @@
#ifndef _CR_H_
#define _CR_H_
+#include X11/Xlib.h
+
extern int _XUpdateGCCache(
register GC gc,
register unsigned long mask,
diff --git a/src/Key.h b/src/Key.h
index 0fe89ba..bb25439 100644
--- a/src/Key.h
+++ b/src/Key.h
@@ -2,6 +2,9 @@
#ifndef _KEY_H_
#define _KEY_H_
+#include X11/Xlib.h
+#include X11/Xresource.h
+
#ifndef NEEDKTABLE
extern const unsigned char _XkeyTable[];
#endif
diff --git a/src/Xintatom.h b/src/Xintatom.h
index 82dba36..516a72b 100644
--- a/src/Xintatom.h
+++ b/src/Xintatom.h
@@ -2,6 +2,7 @@
#ifndef _XINTATOM_H_
#define _XINTATOM_H_ 1
+#include X11/Xlib.h
#include X11/Xfuncproto.h
/* IntAtom.c */
diff --git a/src/Xintconn.h b/src/Xintconn.h
index db59061..cd9aee3 100644
--- a/src/Xintconn.h
+++ b/src/Xintconn.h
@@ -3,6 +3,7 @@
#define _XINTCONN_H_ 1
#include X11/Xfuncproto.h
+#include X11/Xlib.h
_XFUNCPROTOBEGIN
diff --git a/src/Xprivate.h b/src/Xprivate.h
index 006b170..6bfe70b 100644
--- a/src/Xprivate.h
+++ b/src/Xprivate.h
@@ -8,6 +8,8 @@
#ifndef XPRIVATE_H
#define XPRIVATE_H
+#include X11/Xlib.h
+
extern _X_HIDDEN void _XIDHandler(Display *dpy);
extern _X_HIDDEN void _XSeqSyncFunction(Display *dpy);
extern _X_HIDDEN void _XSetPrivSyncFunction(Display *dpy);
diff --git a/src/Xresinternal.h b/src/Xresinternal.h
index c2f355f..b5cc7ff 100644
--- a/src/Xresinternal.h
+++ b/src/Xresinternal.h
@@ -2,6 +2,8 @@
#ifndef _XRESINTERNAL_H_
#define _XRESINTERNAL_H_
+#include X11/Xlib.h
+#include X11/Xresource.h
#include inttypes.h
/* type defines */
diff --git a/src/locking.h b/src/locking.h
index 96019fc..5251a60 100644
--- a/src/locking.h
+++ b/src/locking.h
@@ -36,6 +36,8 @@ in this Software without prior written authorization from
The Open Group.
#define xmalloc(s) Xmalloc(s)
#define xfree(s) Xfree(s)
+#include X11/Xlib.h
+#include X11/Xlibint.h
#include X11/Xthreads.h
struct _XCVList {
--
1.7.9.2
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: (Crowd funded) fix for SiS 671/771 video cards
On 19/05/13 09:48 AM, Pander wrote: On 05/18/2013 10:28 PM, Tormod Volden wrote: On Sat, May 18, 2013 at 7:52 PM, Pander wrote: (manual) patch results in [74.465] (II) LoadModule: sisimedia [74.465] (II) Loading /usr/lib/xorg/modules/drivers/sisimedia_drv.so [74.465] (EE) Failed to load /usr/lib/xorg/modules/drivers/sisimedia_drv.so: /usr/lib/xorg/modules/drivers/sisimedia_drv.so: undefined symbol: SiSUploadToScratch [74.465] (II) UnloadModule: sisimedia [74.465] (II) Unloading sisimedia [74.465] (EE) Failed to load module sisimedia (loader failed, 7) I used this file: http://pastebin.com/XkYfxrQy It would be more useful if you told which file it is and which version instead of paste-binning it. I assume this is the src/sis310_accel.c from git://gitorious.org/xf86-video-sis671/sis-671-fix.git Sorry, I forgot indeed that filename. I have removed declarations and usage of SiSUploadToScreen, SiSUploadToScratch and SiSDownloadFromScreen. Do I need to do that also for void SiSScratchSave(ScreenPtr pScreen, ExaOffscreenArea *area); ? No, that can be left in. Sorry for messing up the patch. signature.asc Description: OpenPGP digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
where does CARD18 come from?
Hello, I was wondering where the names of various data types listed here may come from: http://www.x.org/wiki/XSessionManagementProtocol#Data_Types Most of them are clear, but these ones picked my interest: CARD8 a one-byte unsigned integer CARD16 a two-byte unsigned integer CARD32 a four-byte unsigned integer Do you know what is the etymology of these type names? Do they mean character..., but what does d stand for? In Lisp car is a function that returns the first element of the list but I think Xorg has nothing to do with Lisp. History is interesting ;) -- wemp...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: where does CARD18 come from?
I was wondering where the names of various data types listed here may come from: http://www.x.org/wiki/XSessionManagementProtocol#Data_Types Most of them are clear, but these ones picked my interest: CARD8 a one-byte unsigned integer CARD16 a two-byte unsigned integer CARD32 a four-byte unsigned integer If memory serves, it just means Graphics card. Dave. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: where does CARD18 come from?
It's short for Cardinal, as in Cardinal number http://en.wikipedia.org/wiki/Cardinal_numbers On Mon, May 20, 2013 at 1:12 AM, wemp...@gmail.com wrote: Hello, I was wondering where the names of various data types listed here may come from: http://www.x.org/wiki/XSessionManagementProtocol#Data_Types Most of them are clear, but these ones picked my interest: CARD8 a one-byte unsigned integer CARD16 a two-byte unsigned integer CARD32 a four-byte unsigned integer Do you know what is the etymology of these type names? Do they mean character..., but what does d stand for? In Lisp car is a function that returns the first element of the list but I think Xorg has nothing to do with Lisp. History is interesting ;) -- wemp...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel -- Jasper ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
