[PATCH] release: fix mesa url detection after migration to gitlab
Mesa's migration to gitlab has changed the URL and made things not work. --- release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release.sh b/release.sh index b2071b6..6b8e441 100755 --- a/release.sh +++ b/release.sh @@ -240,7 +240,7 @@ get_section() { module_url=`echo $module_url | cut -d'/' -f3,4` else # The look for mesa, xcb, etc... - module_url=`echo "$full_module_url" | $GREP -o -e "/mesa/.*" -e "/xcb/.*" -e "/xkeyboard-config" -e "/nouveau/xf86-video-nouveau" -e "/libevdev" -e "/wayland/.*" -e "/evemu"` + module_url=`echo "$full_module_url" | $GREP -o -e "mesa/.*" -e "/xcb/.*" -e "/xkeyboard-config" -e "/nouveau/xf86-video-nouveau" -e "/libevdev" -e "/wayland/.*" -e "/evemu"` if [ $? -eq 0 ]; then module_url=`echo $module_url | cut -d'/' -f2,3` else -- 2.17.1 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] modesetting: use drmmode_bo_import() for rotate_fb
On Fri, Jun 15, 2018 at 8:57 AM, Olivier Fourdan wrote: > drmmode_shadow_allocate() still uses drmModeAddFB() which may fail if > the format is not as expected, preventing from using a rotated output. > > Change it to use the new function drmmode_bo_import() which takes care > of calling the drmModeAddFB2() API. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106715 > Signed-off-by: Olivier Fourdan > --- > hw/xfree86/drivers/modesetting/drmmode_display.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c > b/hw/xfree86/drivers/modesetting/drmmode_display.c > index 859a21a9d..ec11b3f56 100644 > --- a/hw/xfree86/drivers/modesetting/drmmode_display.c > +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c > @@ -1794,11 +1794,8 @@ drmmode_shadow_allocate(xf86CrtcPtr crtc, int width, > int height) > return NULL; > } > > -ret = drmModeAddFB(drmmode->fd, width, height, crtc->scrn->depth, > - drmmode->kbpp, > - drmmode_bo_get_pitch(&drmmode_crtc->rotate_bo), > - drmmode_bo_get_handle(&drmmode_crtc->rotate_bo), > - &drmmode_crtc->rotate_fb_id); > +ret = drmmode_bo_import(drmmode, &drmmode_crtc->rotate_bo, > +&drmmode_crtc->rotate_fb_id); > > if (ret) { > ErrorF("failed to add rotate fb\n"); > -- > 2.17.1 > Tested successfully downstream by Tom Pelka, so adding: Tested-by: Tomas Pelka Thanks Tom! Olivier. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 0/2] xwayland: couple of EGL backend API cleanup
Hi, On Fri, Jun 15, 2018 at 9:46 AM, Olivier Fourdan wrote: > Hi Emil, > > On Thu, Jun 14, 2018 at 7:38 PM, Emil Velikov > wrote: >> What's the blocker of pushing these - short on commit access, other? >> If the former, that should be addressed. You have done some serious >> work on Xwayland. > > I don't think I have commit access myself, never tried actually, never dare > to! Well, I could think of a reason why it hasn't been picked up yet... Those patch series are quite a lot of refactoring, and considering we haven't branched 1.20 yet, it might be unclear if this is material for master or xserver-1.20-branch (once it's created). FWIW, I reckon those series are a feature fix primarily, i.e. enable EGLStream support automatically when needed without requiring to change all compositors to add “-eglstream” explicitly, which would crash in different and creative ways with the current code (unknown option if Xwayland was built without EGLStream support, or crash if EGLStream support is there in Xwayland but the hardware isn't). So, IMHO, these patches should be part of 1.20 at some point, but I understand that it's quite a lot of change for a stable tree (even if released only recently) so I would leave that to whoever takes the role of release manager to decide :) Cheers, Olivier ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 0/2] xwayland: couple of EGL backend API cleanup
Hi Emil, On Thu, Jun 14, 2018 at 7:38 PM, Emil Velikov wrote: > What's the blocker of pushing these - short on commit access, other? > If the former, that should be addressed. You have done some serious > work on Xwayland. I don't think I have commit access myself, never tried actually, never dare to! > That said, the series is > Reviewed-by: Emil Velikov Thanks! Olivier ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel