Re: [PATCH xserver 2/2] xfree86: Wrap RRCrtcIsLeased and RROutputIsLeased to check for DIX structures
On Thu, 2018-06-28 at 11:45 -0700, Keith Packard wrote: > Before DIX structures are allocated for crtcs and outputs, we don't > want to call DIX randr code with NULL pointers. This can happen if the > driver sets video modes early in server initialization, which Nouveau > does in zaphod mode. > > Cc: thellst...@vmware.com > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=106772 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=106960 > Signed-off-by: Keith Packard Merged the series, thanks: remote: I: patch #233515 updated using rev c55a44a9a86aaece17c1a2e73c77e3e665c4888e. remote: I: patch #226987 updated using rev 2faf4cef8bcf9bb2034a27219a656ea7221afc6c. remote: I: 2 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 49283e238a..2faf4cef8b master -> master - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] xf86-video-modesetting: Lease planes as well if using atomic
On Wed, 2018-06-27 at 10:41 +0100, Daniel Stone wrote: > Hi, > > On Wed, 27 Jun 2018 at 00:35, Keith Packard wrote: > > @@ -3251,6 +3251,9 @@ drmmode_create_lease(RRLeasePtr lease, int *fd) > > > > nobjects = ncrtc + noutput; > > > > +if (ms->atomic_modeset) > > +nobjects += ncrtc; > > This seems like it definitely wants a comment as to why we add ncrtc > twice (for the primary plane). But, with that (and no need to pass it > through the list again): > Reviewed-by: Daniel Stone Added such comment, and merged the series: remote: I: patch #232471 updated using rev 4a11f66e4690f9e94dc61cb264f5ef78dbdb255a. remote: E: failed to find patch for rev d83efc47b7a524b4f8d4a993c27a3e402a98fa7c. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 2faf4cef8b..d83efc47b7 master -> master - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] meson: ensure the libc has RPC functions when secure-rpc is enabled
On Fri, 2018-06-22 at 12:49 -0400, Lyude Paul wrote: > Currently our meson.build just makes the assumption that the libc is > going to provide RPC functions. This doesn't actually seem to be the > case on Fedora, which causes compilation to fail unexpectedly: > > ../../Projects/xserver/os/rpcauth.c:47:10: fatal error: rpc/rpc.h: No such > file or directory > #include > ^~~ > compilation terminated. > > So, in the event that we can't use libtirpc ensure that we actually > check whether or not the libc provides rpc/rpc.h. If it doesn't, raise > an error. > > Signed-off-by: Lyude Paul Merged, thanks: remote: I: patch #231304 updated using rev d95a1310ef8e08a93a28f9766d1b4093f7891404. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver d83efc47b7..d95a1310ef master -> master - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel