Re: [PATCH:modular] build.sh: remove xf86-input-mouse from Linux
On 14-01-06 09:56 AM, Trevor Woerner wrote: > A couple days ago I took the list of projects available on fd.o, sorted > them by their last change, and noticed there are a number of them > missing from the list of modules built by build.sh which appear to still > be active projects. For example: mesa/glu, mesa/glut, mesa/demos, > mesa/mesa-test, cairo, and a bunch of others (I haven't finished yet). > Do you think it would be worth my time to submit a patch to add some of > these active projects into the list of modules built by build.sh? Interesting work... It all depends on how one sees the "mission" of build.sh. My opinion is the script main goal is to build all of the modules needed to have a working copy of X on any platform. There are probably as many "lists" as there are people. The bare minimum set of modules is the one xorg publishes on the web for a release. That's the bare minimum. Add to that legacy apps, drivers and libraries, and you get what you have today. The list has been crafted over time by developers who add/remove modules based on some consensus. It's not an exact science and there is a good error margin. Here is the challenge: if we add a module that is not maintained, it breaks and adds noise on xorg-devel. Same goes for an unstable module during early development, or a module with external dependencies not available on distros. Same for test or demo modules. So, yes, it is best to propose modules on a case by case basis (or an RFC). For the mesa modules you mentioned, I don't think they should be included as they are not directly involved in running X out-of-the-box (I could be wrong on this). Mesa is not an X project, but a dependency, so only the bits needed by X should be included. Looking at all fdo modules may not be the right approach. This would yield too many modules unrelated to xorg. Note the path in the git URL: xorg/... which indicates an xorg module. Dependencies have been added over time such as XCB (which is now part of X) which I documented here: http://www.x.org/wiki/Building_the_X_Window_System/#index8h3 X has many dependencies and some of them may coincidentally be an fdo module. We would not add it to build.sh if it is commonly available on distros. Again, to reduce the complexity of the build and chances of build breaks. My impression is that build.sh has been fairly well maintained over the years. Recently I revamped the jhbuild xorg.modules list so both are in sync now. All the dependencies are listed, so you can start from scratch specifying just one module and everything needed will be pulled in. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:modular] build.sh: remove xf86-input-mouse from Linux
On 01/ 6/14 06:56 AM, Trevor Woerner wrote: A couple days ago I took the list of projects available on fd.o, sorted them by their last change, and noticed there are a number of them missing from the list of modules built by build.sh which appear to still be active projects. For example: mesa/glu, mesa/glut, mesa/demos, mesa/mesa-test, cairo, and a bunch of others (I haven't finished yet). Do you think it would be worth my time to submit a patch to add some of these active projects into the list of modules built by build.sh? build.sh isn't intended to build every project on freedesktop.org - I don't think we need to go around adding things like cairo or fontconfig to it. It was originally intended as a quick replacement for "make World" from the old X.Org monolith (which included Mesa), to build the X Window System. As for the mesa ones, those were originally part of the main mesa repo but got split out later and we never added them to build.sh - whether that was accidental or intentional, I'm not sure. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:modular] build.sh: remove xf86-input-mouse from Linux
Hello Gaetan, On 01/05/14 19:19, Gaetan Nadon wrote: > On 14-01-05 04:58 PM, Trevor Woerner wrote: >> Remove xf86-input-mouse from the list of modules to build for a Linux target >> since Linux uses xf86-input-evdev instead. >> >> Signed-off-by: Trevor Woerner > As long as it builds on Linux, it's fine. The primary reason for > platform check is to prevent build breaks for people not familiar with > X. It saves them time and saves us from receiving posts and bug reports. > > Majority of drivers are only useful on very specific hardware, like > video cards, tablets and so on. Even so, only a fraction of the C code > is not portable. The configuration, man pages or docs can be maintained > on any platforms. Developers also need to know where code may break when > they change ABI, so it is helpful to have more modules than less that > builds on the platform where they work. > > I am aware this is only one of many perspectives. It is much easier to > remove a module from the list than hunting down for missing modules. I > also do not think build.sh helps anyone make a decision as to which > module should be include in the project they are working on. Thank you for this explanation. I agree with everything you've said, so I have no issues with leaving xf86-input-mouse in the list of modules which are built on a Linux host. A couple days ago I took the list of projects available on fd.o, sorted them by their last change, and noticed there are a number of them missing from the list of modules built by build.sh which appear to still be active projects. For example: mesa/glu, mesa/glut, mesa/demos, mesa/mesa-test, cairo, and a bunch of others (I haven't finished yet). Do you think it would be worth my time to submit a patch to add some of these active projects into the list of modules built by build.sh? Best regards, Trevor ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:modular] build.sh: remove xf86-input-mouse from Linux
On 14-01-05 04:58 PM, Trevor Woerner wrote: > Remove xf86-input-mouse from the list of modules to build for a Linux target > since Linux uses xf86-input-evdev instead. > > Signed-off-by: Trevor Woerner As long as it builds on Linux, it's fine. The primary reason for platform check is to prevent build breaks for people not familiar with X. It saves them time and saves us from receiving posts and bug reports. Majority of drivers are only useful on very specific hardware, like video cards, tablets and so on. Even so, only a fraction of the C code is not portable. The configuration, man pages or docs can be maintained on any platforms. Developers also need to know where code may break when they change ABI, so it is helpful to have more modules than less that builds on the platform where they work. I am aware this is only one of many perspectives. It is much easier to remove a module from the list than hunting down for missing modules. I also do not think build.sh helps anyone make a decision as to which module should be include in the project they are working on. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH:modular] build.sh: remove xf86-input-mouse from Linux
Remove xf86-input-mouse from the list of modules to build for a Linux target
since Linux uses xf86-input-evdev instead.
Signed-off-by: Trevor Woerner
---
build.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/build.sh b/build.sh
index 3500a70..d606983 100755
--- a/build.sh
+++ b/build.sh
@@ -1175,11 +1175,11 @@ build_all_modules() {
;;
*)
build driver xf86-input-keyboard
- build driver xf86-input-mouse
build driver xf86-input-synaptics
build driver xf86-input-void
case $HOST_OS in
FreeBSD)
+ build driver xf86-input-mouse
case $HOST_CPU in
sparc64)
build driver xf86-video-sunffb
@@ -1187,6 +1187,7 @@ build_all_modules() {
esac
;;
NetBSD | OpenBSD)
+ build driver xf86-input-mouse
build driver xf86-video-wsfb
build driver xf86-video-sunffb
;;
@@ -1205,6 +1206,7 @@ build_all_modules() {
esac
case $HOST_CPU in
sparc | sparc64)
+ build driver xf86-input-mouse
build driver xf86-video-suncg14
build driver xf86-video-suncg3
build driver xf86-video-suncg6
--
1.8.5.2.227.g53f3478
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
