Re: [PATCH] Fix build regression on ia64.
Right, but in the meanwhile, I'd still prefer symmetry between all the
{in,out}{b,l,w} ... Having some one way and others another way is just asking
for trouble.
Can we just stop exporting all 6 now (or even remove all 6) rather than just
the one?
Sent from my iPad
On Dec 24, 2011, at 15:48, Cyril Brulebois wrote:
> Jeremy Huddleston (24/12/2011):
>> Right ... I understand how it works around the issue ... my concern is
>> that I don't think this is the fix. Why is it happening only for outl
>> (ie why isnt it happening for outb or others)... I think all 6 should
>> not be exported... perhaps all 6 should not be declared...
>
> Given how painful sdksyms* is, I guess the fix would be killing that
> entirely. In the meanwhile…
>
> Mraw,
> KiBi.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Fix build regression on ia64.
Jeremy Huddleston (24/12/2011): > Right ... I understand how it works around the issue ... my concern is > that I don't think this is the fix. Why is it happening only for outl > (ie why isnt it happening for outb or others)... I think all 6 should > not be exported... perhaps all 6 should not be declared... Given how painful sdksyms* is, I guess the fix would be killing that entirely. In the meanwhile… Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Fix build regression on ia64.
Right ... I understand how it works around the issue ... my concern is that I don't think this is the fix. Why is it happening only for outl (ie why isnt it happening for outb or others)... I think all 6 should not be exported... perhaps all 6 should not be declared... Sent from my iPhone... On Dec 23, 2011, at 19:20, Alan Coopersmith wrote: > On 12/23/11 15:59, Jeremy Huddleston wrote: >> I'm sorry, but I fail to see why this would be the fix to your issue... Can >> you please provide some context. > >>> | CCLD Xorg >>> | sdksyms.o:(.data.rel+0x27d8): undefined reference to `outl' >>> -extern _X_EXPORT void outl(unsigned long port, unsigned int val); > > sdksyms.c is the autogenerated source file containing a pointer to every > struct marked as _X_EXPORT in some header, so as long as there is a header > processed by the sdksyms script claiming we export that function, sdksyms > will generate a reference to it so the linker pulls it into the resulting > Xorg binary. > > -- >-Alan Coopersmith-alan.coopersm...@oracle.com > Oracle Solaris Platform Engineering: X Window System > ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Fix build regression on ia64.
On 12/23/11 15:59, Jeremy Huddleston wrote: I'm sorry, but I fail to see why this would be the fix to your issue... Can you please provide some context. | CCLD Xorg | sdksyms.o:(.data.rel+0x27d8): undefined reference to `outl' -extern _X_EXPORT void outl(unsigned long port, unsigned int val); sdksyms.c is the autogenerated source file containing a pointer to every struct marked as _X_EXPORT in some header, so as long as there is a header processed by the sdksyms script claiming we export that function, sdksyms will generate a reference to it so the linker pulls it into the resulting Xorg binary. -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Fix build regression on ia64.
I'm sorry, but I fail to see why this would be the fix to your issue... Can you please provide some context. Sent from my iPad On Dec 22, 2011, at 19:27, Cyril Brulebois wrote: > Regression introduced in aa0bfb0f133481c57762012e8e30c05ffa151423: > | CCLD Xorg > | sdksyms.o:(.data.rel+0x27d8): undefined reference to `outl' > | collect2: ld returned 1 exit status > > Explanation: outl was still declared on linux ia64, but no longer > defined. Fix that by no longer declaring it. > > Bugzilla: https://bugs.freedesktop.org/43985 > > Signed-off-by: Cyril Brulebois > --- > hw/xfree86/common/compiler.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > Cc: author, reviewers of the guilty commit. > > Maybe that line a few lines above could go away accordingly BTW: > #undef outl > > diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common/compiler.h > index 9e00d75..3d7fabb 100644 > --- a/hw/xfree86/common/compiler.h > +++ b/hw/xfree86/common/compiler.h > @@ -411,7 +411,6 @@ extern _X_EXPORT unsigned int inl(unsigned int port); > #undef inl > extern _X_EXPORT void outb(unsigned long port, unsigned char val); > extern _X_EXPORT void outw(unsigned long port, unsigned short val); > -extern _X_EXPORT void outl(unsigned long port, unsigned int val); > extern _X_EXPORT unsigned int inb(unsigned long port); > extern _X_EXPORT unsigned int inw(unsigned long port); > extern _X_EXPORT unsigned int inl(unsigned long port); > -- > 1.7.7.3 > ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Fix build regression on ia64.
Regression introduced in aa0bfb0f133481c57762012e8e30c05ffa151423: | CCLD Xorg | sdksyms.o:(.data.rel+0x27d8): undefined reference to `outl' | collect2: ld returned 1 exit status Explanation: outl was still declared on linux ia64, but no longer defined. Fix that by no longer declaring it. Bugzilla: https://bugs.freedesktop.org/43985 Signed-off-by: Cyril Brulebois --- hw/xfree86/common/compiler.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) Cc: author, reviewers of the guilty commit. Maybe that line a few lines above could go away accordingly BTW: #undef outl diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common/compiler.h index 9e00d75..3d7fabb 100644 --- a/hw/xfree86/common/compiler.h +++ b/hw/xfree86/common/compiler.h @@ -411,7 +411,6 @@ extern _X_EXPORT unsigned int inl(unsigned int port); #undef inl extern _X_EXPORT void outb(unsigned long port, unsigned char val); extern _X_EXPORT void outw(unsigned long port, unsigned short val); -extern _X_EXPORT void outl(unsigned long port, unsigned int val); extern _X_EXPORT unsigned int inb(unsigned long port); extern _X_EXPORT unsigned int inw(unsigned long port); extern _X_EXPORT unsigned int inl(unsigned long port); -- 1.7.7.3 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
